New issue
Advanced search Search tips

Issue 653223 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Gerrit CQ: improve error messages with dependent CLs

Project Member Reported by tandrii@chromium.org, Oct 5 2016

Issue description

If dependent (child) CL is CQ-ed *before* its dependency (parent) CL lands, when CQ calls REST api "submit", Gerrit may reply with this:

Failed to submit 1 change due to the following problems:
Change 392207: Change could not be merged due to a path conflict. Please rebase the change locally and upload the rebased commit for review.

(example: https://chromium-review.googlesource.com/c/392207/)

But other times, Gerrit would complain that parent CL hasn't landed, which is better. IMO, CQ should just check for parent Cls, if any, and abort *right before issuing Submit call*.

This confuses users. For Rietveld, CQ would abort before even scheduling tryjobs in this situation.
 
Labels: -Pri-1 Pri-2
This actually might not be the case. This seems more like Gerrit bug.
Status: Unconfirmed (was: Available)
Status: WontFix (was: Unconfirmed)
Filed internally https://b.corp.google.com/issues/31970251 as I really think this is a Gerrit bug. There were no dependent CLs actually.

Sign in to add a comment