New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 653209 link

Starred by 1 user
Status: Fixed
Owner:
█ yzshen@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
█ roc...@chromium.org
█ yzshen@chromium.org
haraken@chromium.org
esprehn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Finetuning string16 in mojo

Project Member Reported by zqzh...@chromium.org, Oct 5 2016 
We need to find a way to avoid calling memcpy() in mojo serialization of string16 on the Blink side.

Or, should we avoid sending string16 from Blink to chromium?
Currently, there are a number of instances using string16 on both sides.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/510a9fab8b58db770bc5ce698612dec9b7163df8

commit 510a9fab8b58db770bc5ce698612dec9b7163df8
Author: yzshen <yzshen@chromium.org>
Date: Wed Nov 02 20:54:04 2016

Mojo C++ bindings: some improvements for String16 struct traits.

- map nullable String16 to WTF::String (instead of WTF::Optional<WTF::String>);
- avoid unnecessary copies and null checks;
- add one more test case.

BUG= 653209 

Review-Url: https://codereview.chromium.org/2464793004
Cr-Commit-Position: refs/heads/master@{#429397}

[modify] https://crrev.com/510a9fab8b58db770bc5ce698612dec9b7163df8/mojo/common/common_custom_types_struct_traits.cc
[modify] https://crrev.com/510a9fab8b58db770bc5ce698612dec9b7163df8/mojo/common/common_custom_types_struct_traits.h
[modify] https://crrev.com/510a9fab8b58db770bc5ce698612dec9b7163df8/third_party/WebKit/Source/platform/mojo/CommonCustomTypes.typemap
[modify] https://crrev.com/510a9fab8b58db770bc5ce698612dec9b7163df8/third_party/WebKit/Source/platform/mojo/CommonCustomTypesStructTraits.cpp
[modify] https://crrev.com/510a9fab8b58db770bc5ce698612dec9b7163df8/third_party/WebKit/Source/platform/mojo/CommonCustomTypesStructTraits.h
[modify] https://crrev.com/510a9fab8b58db770bc5ce698612dec9b7163df8/third_party/WebKit/Source/platform/mojo/CommonCustomTypesStructTraitsTest.cpp
[modify] https://crrev.com/510a9fab8b58db770bc5ce698612dec9b7163df8/third_party/WebKit/Source/platform/mojo/DEPS

Comment 2 by yzshen@chromium.org, Nov 2 2016

Owner: yzshen@chromium.org
Status: Fixed (was: Untriaged)

Comment 3 by esprehn@chromium.org, Nov 2 2016

Cc: haraken@chromium.org
Fwiw I think never sending String16 over mojo and always using utf8 would be reasonable too. All of those old IPCs should be updated.
►

Sign in to add a comment