Harmony - dropdown button corner radius too large, needs 1px stroke, and should not stroke blue for focus |
|||||||||||
Issue descriptionCurrently the dropdown button's corner radius is too large. You can see this when comparing the corners of a textfield vs. one of these buttons. This radius also causes the dialog background to peek through in between the edge of the button and its focus ring. Please see the attached screenshots. Additionally, it looks like the dropdown button is using a 1pt stroke, which should be 1px. Finally, the dropdown button should not stroke itself in blue when focused (it now displays the soft focus ring). Attached is the relevant portion of the spec showing that the corner radius should be 2pt (covers both textfields and dropdowns).
,
Oct 5 2016
oops, didn't mean to assign to Elly (fix should be pretty easy even for me)
,
Oct 5 2016
In general the Mac is running the same code as everywhere else, but in this case it looks like the Mac side is doing some custom drawing for the dropdown button. My guess is it's a holdover from the Shiny Modern days. I will assign it to ellyjones@ - probably easy for her to undo whatever is happening.
,
Oct 5 2016
https://codereview.chromium.org/2391393002/
,
Oct 6 2016
thanks for posting those!
,
Oct 6 2016
Looks good - thank you for the change.
,
Oct 10 2016
,
Oct 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca213587627e1b6dfd80040398db3cff98131579 commit ca213587627e1b6dfd80040398db3cff98131579 Author: estade <estade@chromium.org> Date: Mon Oct 10 20:33:26 2016 Harmony - Use FocusableBorder for comboboxes on Mac BUG= 653207 Review-Url: https://codereview.chromium.org/2391393002 Cr-Commit-Position: refs/heads/master@{#424224} [modify] https://crrev.com/ca213587627e1b6dfd80040398db3cff98131579/ui/views/BUILD.gn [modify] https://crrev.com/ca213587627e1b6dfd80040398db3cff98131579/ui/views/controls/combobox/combobox.cc [delete] https://crrev.com/8bbf1f000cade879906cb08fe089122f61b6d68b/ui/views/style/mac/combobox_background_mac.cc [delete] https://crrev.com/8bbf1f000cade879906cb08fe089122f61b6d68b/ui/views/style/mac/combobox_background_mac.h [modify] https://crrev.com/ca213587627e1b6dfd80040398db3cff98131579/ui/views/style/platform_style.cc [modify] https://crrev.com/ca213587627e1b6dfd80040398db3cff98131579/ui/views/style/platform_style.h [modify] https://crrev.com/ca213587627e1b6dfd80040398db3cff98131579/ui/views/style/platform_style_mac.mm
,
Oct 10 2016
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by est...@chromium.org
, Oct 5 2016Owner: ellyjo...@chromium.org