New issue
Advanced search Search tips

Issue 653198 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 630904



Sign in to add a comment

Remove SVN support from the CQ

Project Member Reported by aga...@chromium.org, Oct 5 2016

Issue description

It's got a lot of SVN logic baked into it, which can now be removed.
 
I think I've already mostly done this.
agable@ can you point to something SVN specific you've seen in CQ recently? If not, I'd rather dup it to issue 626055
$ cd commit_queue
$ git grep -i svn | wc -l
184

Most of it is in utils/ (patch.py, rietveld.py, and upload.py), but there are also vestiges in checkouts.py, tools/count, and test/mocks.
Cc: -serg...@chromium.org
Owner: serg...@chromium.org
Status: Assigned (was: Available)
CL: https://chromereviews.googleplex.com/520267014/
CL: https://chromereviews.googleplex.com/520987013/
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/b49971cc70aa6392e30967112bb359a67e425f66

commit b49971cc70aa6392e30967112bb359a67e425f66
Author: sergiyb <sergiyb@google.com>
Date: Thu Oct 13 10:47:14 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/69f12f9b25a7845712dc5570020cae178f91ace8

commit 69f12f9b25a7845712dc5570020cae178f91ace8
Author: Sergiy Byelozyorov <sergiyb@google.com>
Date: Thu Nov 17 17:58:31 2016

Status: Fixed (was: Assigned)
Removed most SVN references from CQ code. The ones remaining should stay there (e.g. detecting legacy entries in configs) or should be removed as part of the depot_tools.

Sign in to add a comment