The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12596183761900660c2f5a8208a861e0ba19e7e6

commit 12596183761900660c2f5a8208a861e0ba19e7e6
Author: mthiesse <mthiesse@chromium.org>
Date: Fri Oct 07 15:15:28 2016

Remove unused WindowAndroid parameter from TabModelSelectorFactory

BUG= 653182 

Review-Url: https://codereview.chromium.org/2398223002
Cr-Commit-Position: refs/heads/master@{#423862}

[modify] https://crrev.com/12596183761900660c2f5a8208a861e0ba19e7e6/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/12596183761900660c2f5a8208a861e0ba19e7e6/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/12596183761900660c2f5a8208a861e0ba19e7e6/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java
[modify] https://crrev.com/12596183761900660c2f5a8208a861e0ba19e7e6/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabWindowManager.java
[modify] https://crrev.com/12596183761900660c2f5a8208a861e0ba19e7e6/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistencePolicyTest.java
[modify] https://crrev.com/12596183761900660c2f5a8208a861e0ba19e7e6/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/ContextMenuLoadUrlParamsTest.java
[modify] https://crrev.com/12596183761900660c2f5a8208a861e0ba19e7e6/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java
[modify] https://crrev.com/12596183761900660c2f5a8208a861e0ba19e7e6/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java
[modify] https://crrev.com/12596183761900660c2f5a8208a861e0ba19e7e6/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabWindowManagerTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcff60d80166f6e2a9a4d5518c7a94c18b70befe

commit dcff60d80166f6e2a9a4d5518c7a94c18b70befe
Author: mthiesse <mthiesse@chromium.org>
Date: Mon Oct 17 21:38:48 2016

Refactor ChromeActivity references out of TabModelSelectorImpl

BUG= 653182 

Review-Url: https://codereview.chromium.org/2394373002
Cr-Commit-Position: refs/heads/master@{#425784}

[modify] https://crrev.com/dcff60d80166f6e2a9a4d5518c7a94c18b70befe/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/dcff60d80166f6e2a9a4d5518c7a94c18b70befe/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/dcff60d80166f6e2a9a4d5518c7a94c18b70befe/chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java
[modify] https://crrev.com/dcff60d80166f6e2a9a4d5518c7a94c18b70befe/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/dcff60d80166f6e2a9a4d5518c7a94c18b70befe/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java
[modify] https://crrev.com/dcff60d80166f6e2a9a4d5518c7a94c18b70befe/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
[modify] https://crrev.com/dcff60d80166f6e2a9a4d5518c7a94c18b70befe/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java
[modify] https://crrev.com/dcff60d80166f6e2a9a4d5518c7a94c18b70befe/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabWindowManager.java
[modify] https://crrev.com/dcff60d80166f6e2a9a4d5518c7a94c18b70befe/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java
[modify] https://crrev.com/dcff60d80166f6e2a9a4d5518c7a94c18b70befe/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/dcff60d80166f6e2a9a4d5518c7a94c18b70befe/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistencePolicyTest.java
[modify] https://crrev.com/dcff60d80166f6e2a9a4d5518c7a94c18b70befe/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/ContextMenuLoadUrlParamsTest.java
[modify] https://crrev.com/dcff60d80166f6e2a9a4d5518c7a94c18b70befe/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java
[modify] https://crrev.com/dcff60d80166f6e2a9a4d5518c7a94c18b70befe/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabWindowManagerTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db320fb20abdc36642a1148fa24224a7fabaa620

commit db320fb20abdc36642a1148fa24224a7fabaa620
Author: mthiesse <mthiesse@chromium.org>
Date: Thu Oct 27 21:00:08 2016

Exit VR Shell on pause (And fix a bunch of minor bugs).

Also fixed a possible bug where we'd incorrectly reset rotation.
Fixed a bug where the control container was hidden on resume, and pages without scrolling couldn't bring it back.
Fixed a crash exiting VR shortly after entering.

BUG= 653182 , 659707 

Review-Url: https://codereview.chromium.org/2453943002
Cr-Commit-Position: refs/heads/master@{#428132}

[modify] https://crrev.com/db320fb20abdc36642a1148fa24224a7fabaa620/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/db320fb20abdc36642a1148fa24224a7fabaa620/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/db320fb20abdc36642a1148fa24224a7fabaa620/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/db320fb20abdc36642a1148fa24224a7fabaa620/chrome/browser/android/vr_shell/vr_shell_delegate.h
[modify] https://crrev.com/db320fb20abdc36642a1148fa24224a7fabaa620/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc

I assume the crash fixed in comment #6 is NOT the one reported here: https://bugs.chromium.org/p/chromium/issues/detail?id=644533.

The description sounds similar, but the changes don't seem like they would address that issue.

Correct, it's not the same crash.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/368b1b6d305d9b6f864ce7071186a85a8950c033

commit 368b1b6d305d9b6f864ce7071186a85a8950c033
Author: mthiesse <mthiesse@chromium.org>
Date: Fri Oct 28 20:19:19 2016

Remove VR Shell from Daydream home.

BUG= 653182 

Review-Url: https://codereview.chromium.org/2454503004
Cr-Commit-Position: refs/heads/master@{#428472}

[modify] https://crrev.com/368b1b6d305d9b6f864ce7071186a85a8950c033/chrome/android/java/AndroidManifest.xml

What is the status of this effort?

On hold?

My latest thinking is the uncoupling is way too much effort and introduces way too much complexity around tab management to make it possibly worthwhile. I'm trying to come up with ways to get the behaviour we need without having a separate Activity.

At the outset we were worried about how intrusive we would be to ChromeTabbedActivity, but it turns out that we're not hugely intrusive, and probably less intrusive than code to share tabs would be...

+cc Ted Choc, Does this sound crazy? How badly would you like to see VR decoupled from CTA?

I don't think it is hugely pressing, but I also don't think the current setup is ideal.

The VR code messes with the internal implementation details too much.  I think regardless of whether we keep it in CTA or split it out, we need to have the concept of detaching the compositor from listening to tab info (i.e. remove all handling of views and such).

I'm going to close this, as we have since implemented the concept of detaching the compositor.

Ted, if there are more issues you have with the current architecture, finer-grained bugs or feedback would be appreciated. We're working on a comprehensive architecture document that I expect you'll be a part of reviewing when we go through launch review.