New issue
Advanced search Search tips

Issue 653172 link

Starred by 1 user
Status: Fixed
Owner:
tandrii@chromium.org
Closed: Mar 2017
Cc:
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

git cl upload/status show/warn if uploader is not an owner

Project Member Reported by tandrii@chromium.org, Oct 5 2016 
git cl upload / git cl status should check if uploader is already owning a CL, and if not, ask for confirmation.

Comment 1 by benhenry@google.com, Oct 25 2016

Labels: Pri-2

Comment 3 by tandrii@chromium.org, Mar 22 2017

Owner: tandrii@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/bb86fbbef1e7b8eb279a88f4548f059527d2810b

commit bb86fbbef1e7b8eb279a88f4548f059527d2810b
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Fri Mar 24 14:03:48 2017

git cl upload for Gerrit: warn if uploader is not CL owner.

R=agable@chromium.org
BUG= 653172 

Change-Id: I141a1422a8f526040fe80522a41d14e2cd8cfc07
Reviewed-on: https://chromium-review.googlesource.com/458421
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/bb86fbbef1e7b8eb279a88f4548f059527d2810b/tests/git_cl_test.py
[modify] https://crrev.com/bb86fbbef1e7b8eb279a88f4548f059527d2810b/git_cl.py
[modify] https://crrev.com/bb86fbbef1e7b8eb279a88f4548f059527d2810b/gerrit_util.py

Comment 5 by tandrii@chromium.org, Mar 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment