Issue metadata
Sign in to add a comment
|
Gerrit + CQ: send email if patchset being CQed is after patchset that was LGTM-ed (CR+1ed) |
||||||||||||||||||||||
Issue description(from Chrome Gerrit summit) Add something that will add email reviewer X if patchset is being sent to CQ which is after patchset that was LGTM-ed by reviewer X (= we have it for Rietveld right now). @rmistry
,
Oct 5 2016
See also https://groups.google.com/a/chromium.org/d/msg/chromium-dev/oIhePZsN3tw/5rwrPxMmInkJ for discussion wrt to original feature in Rietveld.
,
Jan 12 2017
Not having these emails is a regression, so this should be a launch blocker, but it isn't a dogfood blocker.
,
Jan 13 2017
,
Jan 23 2017
,
Apr 7 2017
This can be computed by comparing the change_info.current_revision.created timestamp against the change_info.labels['Code-Review'].all[<latest via sorting by date>].date field. We'll have to be careful to check the timestamp of the revision (patchset) that the CQ was triggered on, not the patchset that is automatically created via rebasing during submission. I think I have a handle on this.
,
Apr 13 2017
By the way, don't you think that this message should be sent also if a CL is landed using "SUBMIT" button?
,
Apr 13 2017
That would require a wholly separate implementation built into a gerrit plugin instead of built into the CQ. I agree that it seems useful but should be tracked in a separate bug (in the Afterglow milestone, since Rietveld doesn't have that message when a CL is landed by git-cl-land).
,
Apr 21 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/f57ea359c871ea81bbbd4fa1b95e5096699a35f4 commit f57ea359c871ea81bbbd4fa1b95e5096699a35f4 Author: Aaron Gable <agable@chromium.org> Date: Fri Apr 21 20:45:19 2017
,
Apr 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/d578cef21dbdff1a9927bf7320dbdbf36e9343bd commit d578cef21dbdff1a9927bf7320dbdbf36e9343bd Author: Aaron Gable <agable@chromium.org> Date: Mon Apr 24 18:21:35 2017
,
Apr 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/d578cef21dbdff1a9927bf7320dbdbf36e9343bd commit d578cef21dbdff1a9927bf7320dbdbf36e9343bd Author: Aaron Gable <agable@chromium.org> Date: Mon Apr 24 18:21:35 2017
,
Apr 24 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/8cec6aa4f7c11f9de1a5238ce1f365e8e4c1ef3b commit 8cec6aa4f7c11f9de1a5238ce1f365e8e4c1ef3b Author: Vadim Shtayura <vadimsh@google.com> Date: Mon Apr 24 19:09:11 2017
,
Apr 25 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/7dbbd9b6c9a18462245bd296e660df34fcb344fb commit 7dbbd9b6c9a18462245bd296e660df34fcb344fb Author: Aaron Gable <agable@chromium.org> Date: Tue Apr 25 18:39:02 2017
,
Apr 25 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/7dbbd9b6c9a18462245bd296e660df34fcb344fb commit 7dbbd9b6c9a18462245bd296e660df34fcb344fb Author: Aaron Gable <agable@chromium.org> Date: Tue Apr 25 18:39:02 2017
,
Apr 25 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/7dbbd9b6c9a18462245bd296e660df34fcb344fb commit 7dbbd9b6c9a18462245bd296e660df34fcb344fb Author: Aaron Gable <agable@chromium.org> Date: Tue Apr 25 18:39:02 2017
,
Apr 25 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/22a6f2cf39c54842e69228abf12b5dac8eb03ced commit 22a6f2cf39c54842e69228abf12b5dac8eb03ced Author: Andrii Shyshkalov <tandrii@google.com> Date: Tue Apr 25 19:04:10 2017
,
Apr 25 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/d2cf3cd12d1b13765980b0ec94f5e781c06f9696 commit d2cf3cd12d1b13765980b0ec94f5e781c06f9696 Author: Aaron Gable <agable@chromium.org> Date: Tue Apr 25 22:39:19 2017 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tandrii@chromium.org
, Oct 5 2016