New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653131 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

[PresentationAPI] getAvailability() should return SameObject (same Promise)

Project Member Reported by mfo...@chromium.org, Oct 5 2016

Issue description

Implement when the spec change lands to resolve https://github.com/w3c/presentation-api/issues/335.

 
Cc: -binzhao@chromium.org zhaobin@chromium.org
Also update ContentBrowserTest::AvailabilityNotUndefined.
Status: Available (was: Untriaged)
BTW, I had a look at this when fixing the undefined return for getAvailability() and it seems that [SameObject] can't be used in our WebIDL implementations if it's not a readonly attribute according to the documentation. We might need to implement the mechanism in PresentationRequest.cpp directly.
Owner: zhaobin@chromium.org
Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c627c11ac9fbcd803153a5bd77839cabaf29c96

commit 9c627c11ac9fbcd803153a5bd77839cabaf29c96
Author: zhaobin <zhaobin@chromium.org>
Date: Sat Dec 17 01:04:51 2016

[Presentation API] PresentationRequest::getAvailability() should return the same promise

Add a ScriptPromiseProperty to PresentationRequest to store PresentationAvailability promise object. getAvailability() will always return the same promise object.

BUG= 653131 

Review-Url: https://codereview.chromium.org/2572473003
Cr-Commit-Position: refs/heads/master@{#439269}

[modify] https://crrev.com/9c627c11ac9fbcd803153a5bd77839cabaf29c96/third_party/WebKit/LayoutTests/presentation/presentationrequest.html
[modify] https://crrev.com/9c627c11ac9fbcd803153a5bd77839cabaf29c96/third_party/WebKit/Source/modules/presentation/BUILD.gn
[modify] https://crrev.com/9c627c11ac9fbcd803153a5bd77839cabaf29c96/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp
[modify] https://crrev.com/9c627c11ac9fbcd803153a5bd77839cabaf29c96/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h
[modify] https://crrev.com/9c627c11ac9fbcd803153a5bd77839cabaf29c96/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.cpp
[modify] https://crrev.com/9c627c11ac9fbcd803153a5bd77839cabaf29c96/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.h
[modify] https://crrev.com/9c627c11ac9fbcd803153a5bd77839cabaf29c96/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp
[modify] https://crrev.com/9c627c11ac9fbcd803153a5bd77839cabaf29c96/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp
[modify] https://crrev.com/9c627c11ac9fbcd803153a5bd77839cabaf29c96/third_party/WebKit/Source/modules/presentation/PresentationError.cpp
[modify] https://crrev.com/9c627c11ac9fbcd803153a5bd77839cabaf29c96/third_party/WebKit/Source/modules/presentation/PresentationError.h
[add] https://crrev.com/9c627c11ac9fbcd803153a5bd77839cabaf29c96/third_party/WebKit/Source/modules/presentation/PresentationPromiseProperty.h
[modify] https://crrev.com/9c627c11ac9fbcd803153a5bd77839cabaf29c96/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
[modify] https://crrev.com/9c627c11ac9fbcd803153a5bd77839cabaf29c96/third_party/WebKit/Source/modules/presentation/PresentationRequest.h

Status: Fixed (was: Started)

Comment 8 by mfo...@chromium.org, Mar 24 2017

Labels: -PresentationAPI

Sign in to add a comment