See https://webaudio.github.io/web-audio-api/#MediaStreamAudioSourceNode The dictionary is also missing.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05b49ea11c1011743e9665dbc294fac169b6ec76 commit 05b49ea11c1011743e9665dbc294fac169b6ec76 Author: rtoy <rtoy@chromium.org> Date: Mon Oct 10 17:16:03 2016 Add constructor for MediaStreamAudioSourceNode This was missed when the other constructors were implemented. The original intent and feature: Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/QpOwpM15YRA/SQJbPmuuAAAJ Feature: https://www.chromestatus.com/features/6409704485945344 BUG= 653129 , 626449 TEST=constructor/mediastreamaudiosource.html Review-Url: https://codereview.chromium.org/2398713002 Cr-Commit-Position: refs/heads/master@{#424174} [add] https://crrev.com/05b49ea11c1011743e9665dbc294fac169b6ec76/third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiosource.html [modify] https://crrev.com/05b49ea11c1011743e9665dbc294fac169b6ec76/third_party/WebKit/Source/modules/modules_idl_files.gni [modify] https://crrev.com/05b49ea11c1011743e9665dbc294fac169b6ec76/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp [modify] https://crrev.com/05b49ea11c1011743e9665dbc294fac169b6ec76/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h [modify] https://crrev.com/05b49ea11c1011743e9665dbc294fac169b6ec76/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.idl [add] https://crrev.com/05b49ea11c1011743e9665dbc294fac169b6ec76/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceOptions.idl
It would be nice to have this constructor available with all of the other WebAudio AudioNode constructors that have already landed in M55 (See issue 626449 ). This is not critical, but a nice-to-have for consistency.
Your change meets the bar and is auto-approved for M55 (branch: 2883)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24bb7c9279f106b90da36e915de49b1bf65585dc commit 24bb7c9279f106b90da36e915de49b1bf65585dc Author: Raymond Toy <rtoy@chromium.org> Date: Tue Oct 18 17:19:30 2016 Add constructor for MediaStreamAudioSourceNode This was missed when the other constructors were implemented. The original intent and feature: Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/QpOwpM15YRA/SQJbPmuuAAAJ Feature: https://www.chromestatus.com/features/6409704485945344 BUG= 653129 , 626449 TEST=constructor/mediastreamaudiosource.html Review-Url: https://codereview.chromium.org/2398713002 Cr-Commit-Position: refs/heads/master@{#424174} (cherry picked from commit 05b49ea11c1011743e9665dbc294fac169b6ec76) Review URL: https://codereview.chromium.org/2431653003 . Cr-Commit-Position: refs/branch-heads/2883@{#177} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [add] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/LayoutTests/webaudio/constructor/mediastreamaudiosource.html [modify] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/Source/modules/modules_idl_files.gni [modify] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp [modify] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.h [modify] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.idl [add] https://crrev.com/24bb7c9279f106b90da36e915de49b1bf65585dc/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceOptions.idl
[Automated comment] removing mislabelled merge-merged-2840
Comment 1 by bugdroid1@chromium.org
, Oct 10 2016