New issue
Advanced search Search tips

Issue 653123 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Change title of auto sign-in first-run dialog

Project Member Reported by sabineb@chromium.org, Oct 5 2016

Issue description

Change title of auto sign-in first-run dialog from "Sign in easily on this device" to "Sign in easily" for users who are not syncing passwords. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e9a1a9fd97ac749d424539726cc17e98f8f2643

commit 7e9a1a9fd97ac749d424539726cc17e98f8f2643
Author: vasilii <vasilii@chromium.org>
Date: Fri Oct 07 15:52:45 2016

Change the auto sign-in first run title.

The new string better suits the use case when the user signs into Chrome after accepting the promo.

BUG= 653123 

Review-Url: https://codereview.chromium.org/2396373002
Cr-Commit-Position: refs/heads/master@{#423869}

[modify] https://crrev.com/7e9a1a9fd97ac749d424539726cc17e98f8f2643/chrome/app/generated_resources.grd

Labels: Merge-Request-55
I want to merge r423869 (strings only).

Comment 3 by dimu@chromium.org, Oct 7 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Please merge your change to M55 branch 2883 ASAP so we can get it translated.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 10 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c8e789e03a077dd0a0ccddd10cea4b00de3b0da

commit 5c8e789e03a077dd0a0ccddd10cea4b00de3b0da
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Oct 10 14:00:03 2016

Change the auto sign-in first run title.

The new string better suits the use case when the user signs into Chrome after accepting the promo.

BUG= 653123 

Review-Url: https://codereview.chromium.org/2396373002
Cr-Commit-Position: refs/heads/master@{#423869}
(cherry picked from commit 7e9a1a9fd97ac749d424539726cc17e98f8f2643)

Review URL: https://codereview.chromium.org/2405863002 .

Cr-Commit-Position: refs/branch-heads/2883@{#12}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/5c8e789e03a077dd0a0ccddd10cea4b00de3b0da/chrome/app/generated_resources.grd

Status: Fixed (was: Assigned)
Verified the string changes on Chrome version 55.0.2883.9 on Windows 7,10, Mac 10.11.6 and Linux(ubuntu 14.04Lts)

Steps to reproduce :
1. launch Clean or newly installed Chrome
2. navigate to https://w3c.github.io/webappsec/demos/credential-management/
3. Sign in to the page
4. Save the credential
5. repeat step 3 
6. See an account chooser shows up
7. Select the saved credential's

Observed behavior:
Observed a dialog with Sign in easily please find the attached screenshot.
SigninEasily-1.png
5.7 KB View Download
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c8e789e03a077dd0a0ccddd10cea4b00de3b0da

commit 5c8e789e03a077dd0a0ccddd10cea4b00de3b0da
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Oct 10 14:00:03 2016

Change the auto sign-in first run title.

The new string better suits the use case when the user signs into Chrome after accepting the promo.

BUG= 653123 

Review-Url: https://codereview.chromium.org/2396373002
Cr-Commit-Position: refs/heads/master@{#423869}
(cherry picked from commit 7e9a1a9fd97ac749d424539726cc17e98f8f2643)

Review URL: https://codereview.chromium.org/2405863002 .

Cr-Commit-Position: refs/branch-heads/2883@{#12}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/5c8e789e03a077dd0a0ccddd10cea4b00de3b0da/chrome/app/generated_resources.grd

Comment 9 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment