Migrate WebRTC stats browser test fully to telemetry |
|||||
Issue descriptionThat is, migrate https://cs.chromium.org/chromium/src/chrome/browser/media/webrtc/webrtc_perf_browsertest.cc?q=webrtc_perf&sq=package:chromium&l=1 which reports the following metrics: https://cs.chromium.org/chromium/src/chrome/browser/media/webrtc/webrtc_browsertest_perf.cc?sq=package:chromium We have a partial implementation in Telemetry that covers some metrics already: https://cs.chromium.org/chromium/src/tools/perf/metrics/webrtc_stats.py?q=webrtc_st&sq=package:chromium&l=1 We need to 1) migrate the rest of the metrics 2) get a ref video playing (if feasible, otherwise the default spinning green ball will have to do) 3) check all metrics and ensure they're reasonable, prune out unstable or uninteresting metrics 4) make sure this measurement runs for the 45-sec 720p test 5) implement a one-way call 6) implement support for running the test once per main codec (vp8, vp9, h264)* * as is done here: https://cs.chromium.org/chromium/src/chrome/browser/media/webrtc/webrtc_perf_browsertest.cc?sq=package:chromium&l=229
,
Oct 5 2016
,
Oct 5 2016
,
Jan 4 2017
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/f7f7fb9cf8706aee5cb2e5ebf5335622f6193eba commit f7f7fb9cf8706aee5cb2e5ebf5335622f6193eba Author: ehmaldonado <ehmaldonado@webrtc.org> Date: Wed Mar 15 17:45:49 2017 Add traces for some video events. This CL adds traces to compute the following metrics that getStats() captures for video: - googFrameRateSent - googFrameRateInput - googFirsReceived - googNacksReceived - googFrameWidthSent - googFrameHeightSent - googAvgEncodeMs - googEncodeUsagePercent BUG= chromium:653087 Review-Url: https://codereview.webrtc.org/2746903004 Cr-Commit-Position: refs/heads/master@{#17260} [modify] https://crrev.com/f7f7fb9cf8706aee5cb2e5ebf5335622f6193eba/webrtc/video/send_statistics_proxy.cc
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/c1b5ea959ed058c7b44c437f1cbbbccf6d9daf6c commit c1b5ea959ed058c7b44c437f1cbbbccf6d9daf6c Author: ehmaldonado <ehmaldonado@webrtc.org> Date: Tue May 23 16:06:13 2017 Add traces for some video receive statistics. This CL adds traces to compute the following metrics that getStats() captures for video: - googFrameRateOutput - packetsLost - googFrameWidthReceived - googFrameHeightReceived - googCurrentDelayMs - googTargetDelayMs - googDecodeMs - googMaxDecodeMs - googJitterBufferMs - googRenderDelayMs BUG= chromium:653087 Review-Url: https://codereview.webrtc.org/2884643004 Cr-Commit-Position: refs/heads/master@{#18242} [modify] https://crrev.com/c1b5ea959ed058c7b44c437f1cbbbccf6d9daf6c/webrtc/video/receive_statistics_proxy.cc
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/a26196bc65bbc627ad4520070ebbb896b95708c8 commit a26196bc65bbc627ad4520070ebbb896b95708c8 Author: ehmaldonado <ehmaldonado@webrtc.org> Date: Tue Jul 18 10:30:29 2017 Trace stats in RTCStatsCollector. BUG= chromium:653087 Review-Url: https://codereview.webrtc.org/2975793002 Cr-Commit-Position: refs/heads/master@{#19069} [modify] https://crrev.com/a26196bc65bbc627ad4520070ebbb896b95708c8/webrtc/pc/rtcstatscollector.cc
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/b0b721a68c2d90f5b6476c01cff0d4298d58c08a commit b0b721a68c2d90f5b6476c01cff0d4298d58c08a Author: ehmaldonado <ehmaldonado@webrtc.org> Date: Tue Jul 18 11:27:08 2017 Increase the size of the buffer for type.name.id. BUG= chromium:653087 Review-Url: https://codereview.webrtc.org/2977363002 Cr-Commit-Position: refs/heads/master@{#19072} [modify] https://crrev.com/b0b721a68c2d90f5b6476c01cff0d4298d58c08a/webrtc/pc/rtcstatscollector.cc
,
Jul 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/80c829f25382f98e97b30a5803322552f350f983 commit 80c829f25382f98e97b30a5803322552f350f983 Author: ehmaldonado <ehmaldonado@webrtc.org> Date: Tue Jul 18 14:35:19 2017 Enable tracing on rtcstats_integrationtest.cc BUG= chromium:653087 Review-Url: https://codereview.webrtc.org/2979203002 Cr-Commit-Position: refs/heads/master@{#19076} [modify] https://crrev.com/80c829f25382f98e97b30a5803322552f350f983/webrtc/pc/rtcstats_integrationtest.cc [modify] https://crrev.com/80c829f25382f98e97b30a5803322552f350f983/webrtc/pc/rtcstatscollector.cc
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/d083e851f66004b913459670a61cebbc801af53f commit d083e851f66004b913459670a61cebbc801af53f Author: ehmaldonado <ehmaldonado@webrtc.org> Date: Mon Jul 24 16:00:13 2017 Remove traces from {send,receive}_statistics_proxy.cc These traces will be traced instead when getStats() is called by JavaScript. BUG= chromium:653087 Review-Url: https://codereview.webrtc.org/2972393002 Cr-Commit-Position: refs/heads/master@{#19124} [modify] https://crrev.com/d083e851f66004b913459670a61cebbc801af53f/webrtc/video/receive_statistics_proxy.cc [modify] https://crrev.com/d083e851f66004b913459670a61cebbc801af53f/webrtc/video/send_statistics_proxy.cc
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/35a872c0e6752f1c2ccd1fd15f6f721612ee180a commit 35a872c0e6752f1c2ccd1fd15f6f721612ee180a Author: ehmaldonado <ehmaldonado@webrtc.org> Date: Fri Jul 28 14:29:12 2017 Make RTCStatsReport::ToString() return JSON-parseable string. BUG= chromium:653087 Review-Url: https://codereview.webrtc.org/2983243002 Cr-Commit-Position: refs/heads/master@{#19180} [modify] https://crrev.com/35a872c0e6752f1c2ccd1fd15f6f721612ee180a/webrtc/api/stats/rtcstats.h [modify] https://crrev.com/35a872c0e6752f1c2ccd1fd15f6f721612ee180a/webrtc/api/stats/rtcstatsreport.h [modify] https://crrev.com/35a872c0e6752f1c2ccd1fd15f6f721612ee180a/webrtc/pc/rtcstats_integrationtest.cc [modify] https://crrev.com/35a872c0e6752f1c2ccd1fd15f6f721612ee180a/webrtc/pc/rtcstatscollector_unittest.cc [modify] https://crrev.com/35a872c0e6752f1c2ccd1fd15f6f721612ee180a/webrtc/stats/BUILD.gn [modify] https://crrev.com/35a872c0e6752f1c2ccd1fd15f6f721612ee180a/webrtc/stats/rtcstats.cc [modify] https://crrev.com/35a872c0e6752f1c2ccd1fd15f6f721612ee180a/webrtc/stats/rtcstats_unittest.cc [modify] https://crrev.com/35a872c0e6752f1c2ccd1fd15f6f721612ee180a/webrtc/stats/rtcstatsreport.cc
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/80c65780e618f90369295fe5daf8075e9b374c26 commit 80c65780e618f90369295fe5daf8075e9b374c26 Author: ehmaldonado <ehmaldonado@webrtc.org> Date: Mon Aug 14 16:51:26 2017 Trace the stats report as JSON instead of each stat separately. Trace the whole report as a string instead of each field on it's own. And test that the traces collected are valid. R=tommi@webrtc.org, hbos@webrtc.org BUG= chromium:653087 Review-Url: https://codereview.webrtc.org/2986453002 Cr-Commit-Position: refs/heads/master@{#19341} [modify] https://crrev.com/80c65780e618f90369295fe5daf8075e9b374c26/webrtc/pc/rtcstats_integrationtest.cc [modify] https://crrev.com/80c65780e618f90369295fe5daf8075e9b374c26/webrtc/pc/rtcstatscollector.cc
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/3439c893585e0958502ef397056a372be1777688 commit 3439c893585e0958502ef397056a372be1777688 Author: mbonadei <mbonadei@webrtc.org> Date: Tue Aug 15 06:48:03 2017 Revert of Trace the stats report as JSON instead of each stat separately. (patchset #3 id:100001 of https://codereview.webrtc.org/2986453002/ ) Reason for revert: It breaks a downstream project. Original issue's description: > Trace the stats report as JSON instead of each stat separately. > > Trace the whole report as a string instead of each field on it's own. And test that the traces collected are valid. > > R=tommi@webrtc.org, hbos@webrtc.org > BUG= chromium:653087 > > Review-Url: https://codereview.webrtc.org/2986453002 > Cr-Commit-Position: refs/heads/master@{#19341} > Committed: https://chromium.googlesource.com/external/webrtc/+/80c65780e618f90369295fe5daf8075e9b374c26 TBR=hbos@webrtc.org,tommi@webrtc.org,ehmaldonado@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= chromium:653087 Review-Url: https://codereview.webrtc.org/3001683002 Cr-Commit-Position: refs/heads/master@{#19344} [modify] https://crrev.com/3439c893585e0958502ef397056a372be1777688/webrtc/pc/rtcstats_integrationtest.cc [modify] https://crrev.com/3439c893585e0958502ef397056a372be1777688/webrtc/pc/rtcstatscollector.cc
,
Sep 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/8ab0fd80ad4af302d8f72e94e577458084772288 commit 8ab0fd80ad4af302d8f72e94e577458084772288 Author: ehmaldonado <ehmaldonado@webrtc.org> Date: Mon Sep 04 21:35:04 2017 Reland of Trace the stats report as JSON instead of each stat separately. (patchset #1 id:1 of https://codereview.webrtc.org/3001683002/ ) Reason for revert: Fixed Original issue's description: > Revert of Trace the stats report as JSON instead of each stat separately. (patchset #3 id:100001 of https://codereview.webrtc.org/2986453002/ ) > > Reason for revert: > It breaks a downstream project. > > Original issue's description: > > Trace the stats report as JSON instead of each stat separately. > > > > Trace the whole report as a string instead of each field on it's own. And test that the traces collected are valid. > > > > R=tommi@webrtc.org, hbos@webrtc.org > > BUG= chromium:653087 > > > > Review-Url: https://codereview.webrtc.org/2986453002 > > Cr-Commit-Position: refs/heads/master@{#19341} > > Committed: https://chromium.googlesource.com/external/webrtc/+/80c65780e618f90369295fe5daf8075e9b374c26 > > TBR=hbos@webrtc.org,tommi@webrtc.org,ehmaldonado@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= chromium:653087 > > Review-Url: https://codereview.webrtc.org/3001683002 > Cr-Commit-Position: refs/heads/master@{#19344} > Committed: https://chromium.googlesource.com/external/webrtc/+/3439c893585e0958502ef397056a372be1777688 BUG= chromium:653087 Review-Url: https://codereview.webrtc.org/3000943002 Cr-Commit-Position: refs/heads/master@{#19673} [modify] https://crrev.com/8ab0fd80ad4af302d8f72e94e577458084772288/webrtc/pc/rtcstats_integrationtest.cc [modify] https://crrev.com/8ab0fd80ad4af302d8f72e94e577458084772288/webrtc/pc/rtcstatscollector.cc
,
Jan 24 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by phoglund@chromium.org
, Oct 5 2016Labels: -Type-Bug -Pri-3 Pri-2 Type-Feature