New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653075 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Chrome tabs do not display Learnzillion favicon

Reported by manoranj...@learnzillion.com, Oct 5 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36

Steps to reproduce the problem:
1. Open chrome (version 53)
2. Enter url https://www.learnzillion.com
3. After page load, verify the tab head for Learnzillion logo

What is the expected behavior?
Learnzillion logo should be displayed on tab heads

What went wrong?
Learnzillion logo is not displayed on chrome tab heads. Issue is happening on following versions of chrome
53(latest) - Not displayed
54(Beta) - Not Displayed
55(Dev) - Not Displayed
On chrome version 52 and lower, the logo is displayed. Logo is displayed  for other browsers like firefox & IE.
Please see the screenshots attached. Chromium logo is not displayed. Whilst logos for other websites are displayed.

Did this work before? Yes Till Chrome version 52

Chrome version: 53.0.2785.116  Channel: stable
OS Version: OS X 10.11.3
Flash Version: Shockwave Flash 23.0 r0

Tested this issue on Mac,Linux and Windows machines for browsers  firefox, chrome, IE11/10 and MS Edge. Issue occurs on all specified OS, on chrome versions(53, 54beta and 55 Dev) 
Tested & confirmed the issue on browser stack tool as well.
 
chrome_tab_logo_not_displayed.png
92.9 KB View Download
LZ_logo_other_borwsertabs.png
1.7 MB View Download
Cc: scroggo@chromium.org fmalita@chromium.org pkasting@chromium.org
Components: -UI Internals>Images>Codecs
Labels: -Type-Bug M-54 ReleaseBlock-Stable Type-Bug-Regression
Owner: aleksand...@intel.com
Status: Assigned (was: Unconfirmed)
Summary: Chrome tabs do not display Learnzillion favicon (was: Chrome tabs do not display Learnzillion logo on tab heads)
Confirmed. And this appears to be a regression, so I bisected down to:

You are probably looking for a change made after 400373 (known good), but no later than 400388 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/a6c129b2ccf0a7e1c75638bb6c9432d5f638b546..757686ec13f667253c9ecc47597e4a8502f720be

https://chromium.googlesource.com/chromium/src/+/f32e119c6c7ec9e98298fcd43a285b735f021952 seems like the likely candidate.
Status: Started (was: Assigned)
Uploaded potential fix to review: crrev.com/2391073003/

manoranjiniramachandran@learnzillion.com,
Do you know what authoring tool the designers used to create favicon.ico file (https://lzcms.wpengine.com/p/wp-content/themes/learnzillion/images/favicon.ico?ver=2)?
Thanks.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3f6d43c1b2d245063da70a1d49247e8e2d5ee21

commit c3f6d43c1b2d245063da70a1d49247e8e2d5ee21
Author: aleksandar.stojiljkovic <aleksandar.stojiljkovic@intel.com>
Date: Thu Oct 06 02:21:06 2016

ICO: Skip checking declared entry bounds when file is completelly received.

It is relativelly common that the last entry offset + bytesize is two bytes over
file byte size. When calculating frame count, return entry count and allow
decoder to decode file.

BUG= 653075 

Review-Url: https://codereview.chromium.org/2391073003
Cr-Commit-Position: refs/heads/master@{#423398}

[modify] https://crrev.com/c3f6d43c1b2d245063da70a1d49247e8e2d5ee21/content/test/data/invalid.ico
[add] https://crrev.com/c3f6d43c1b2d245063da70a1d49247e8e2d5ee21/third_party/WebKit/LayoutTests/fast/images/resources/bug653075.ico
[modify] https://crrev.com/c3f6d43c1b2d245063da70a1d49247e8e2d5ee21/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp
[modify] https://crrev.com/c3f6d43c1b2d245063da70a1d49247e8e2d5ee21/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoderTest.cpp

Status: Fixed (was: Started)
Labels: TE-Verified-55.0.2883.6 TE-Verified-M55
Verified this issue on Mac OS 10.12 using chrome latest Dev #55.0.2883.6 by following steps mentioned in the original comment. Observed the Learnzillion logo is displayed on the tab heads as expected. Hence adding TE-Verified label.
Screen Shot 2016-10-10 at 4.08.22 PM.png
823 KB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3f6d43c1b2d245063da70a1d49247e8e2d5ee21

commit c3f6d43c1b2d245063da70a1d49247e8e2d5ee21
Author: aleksandar.stojiljkovic <aleksandar.stojiljkovic@intel.com>
Date: Thu Oct 06 02:21:06 2016

ICO: Skip checking declared entry bounds when file is completelly received.

It is relativelly common that the last entry offset + bytesize is two bytes over
file byte size. When calculating frame count, return entry count and allow
decoder to decode file.

BUG= 653075 

Review-Url: https://codereview.chromium.org/2391073003
Cr-Commit-Position: refs/heads/master@{#423398}

[modify] https://crrev.com/c3f6d43c1b2d245063da70a1d49247e8e2d5ee21/content/test/data/invalid.ico
[add] https://crrev.com/c3f6d43c1b2d245063da70a1d49247e8e2d5ee21/third_party/WebKit/LayoutTests/fast/images/resources/bug653075.ico
[modify] https://crrev.com/c3f6d43c1b2d245063da70a1d49247e8e2d5ee21/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp
[modify] https://crrev.com/c3f6d43c1b2d245063da70a1d49247e8e2d5ee21/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoderTest.cpp

Comment 8 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment