Issue metadata
Sign in to add a comment
|
Regression:Contents of the extension is not seen after clicking on extension icon for "CrunchHunt Chrome Extension"
Reported by
adha...@etouch.net,
Oct 5 2016
|
||||||||||||||||||||||||
Issue descriptionChrome Version : 55.0.2881.0 (Official Build) 6b08cd23a5bbe4e1d95bb7e0431fc743e6b0180c-refs/heads/master@{#423030} (32/64-bit) OS: Mac(10.10.5)(10.11.5), Windows(7,8,8.1,10), Linux(14.04 LTS) TEST URL:https://chrome.google.com/webstore/detail/crunchhunt-chrome-extensi/gddipdekcoklinkmnhffpgnabejbpeaa/related What steps will reproduce the problem? (1)Launch chrome,navigate to the above URL and click on add to chrome. (2)Click on extension icon in Extensions overlay. (3)Observe. Actual:Contents of the extension is not seen after clicking extension icon in Extensions overlay. Expected:Contents should be displayed after clicking extension icon in Extensions overlay. This is a Regression issue broken in M-55,will soon update other info. Good build:55.0.2841.0 Bad build:55.0.2842.0
,
Oct 10 2016
Able to reproduce the above issue on latest canary version i.e 56.0.2885.0 and on chrome latest Dev #55.0.2882.4
,
Oct 28 2016
,
Oct 28 2016
adharap@ are you still able to reproduce the issue on latest Chrome Beta(55.0.2883.28) and Dev(56.0.2902.0) channels,if so can you please re bisect the bug as requested.
,
Oct 31 2016
Unable to reproduce the issue on chrome Dev #56.0.2902.0 and chrome canary #56.0.2905.0 by following the steps mentioned in the comment #0 . @adharap-- could you please provide the bisect from your end . Thanks !
,
Oct 31 2016
Repro in Canary 56.0.2905.0 Win7SP1x64 Bisect: 427722 (good) - 427739 (bad) https://chromium.googlesource.com/chromium/src/+log/7a1f218b..006ed631?pretty=fuller Tracked in issue 624061. Broken by https://crrev.com/2392773002 Fixed by https://crrev.com/2430923007 (not yet in Canary at the moment) It should be noted that the popup is displayed after ~1 second delay, reported in issue 649942 (and still ignored for some mysterious reason).
,
Nov 2 2016
Able to reproduce the above issue on latest canary version i.e 56.0.2906.0 Narrow bisect info: https://chromium.googlesource.com/chromium/src/+log/252dbee7b15f43aa53242b68eb1bc41b272eaf26..620481ed0f278ec8d2116dd94088e0eb3747e65d?pretty=fuller&n=100 Suspecting:r419318?
,
Nov 2 2016
The popup devtools inspector console shows an error in affected builds: Unsafe JavaScript attempt to initiate navigation for frame with origin 'chrome-extension://gddipdekcoklinkmnhffpgnabejbpeaa' from frame with URL 'http://www.crunchhunt.com/'. The frame attempting navigation is targeting its top-level window, but is neither same-origin with its target nor is it processing a user gesture. See https://www.chromestatus.com/features/5851021045661696.
,
Nov 2 2016
,
Nov 2 2016
Bisect for 55.0.2841.0 - 55.0.2842.0: 414854 (good) - 414880 (BAD). https://chromium.googlesource.com/chromium/src/+log/2bff664c..9738e829?pretty=fuller Two commits related to "Site Isolation for Extensions" seem obvious culprits. The problem was fixed in 56.0.2894.0 by https://crrev.com/2413513004 The problem resurfaced in 56.0.2902.0 because of https://crrev.com/2392773002 for a different reason, see #6 above.
,
Nov 2 2016
Note that "Site Isolation for Extensions" was in field trials, which explains, presumably, why the issue wasn't confirmed earlier in #1: https://chromium.googlesource.com/chromium/src/+log/master/chrome/common/extensions/extension_process_policy.cc (the link takes a while to open, be patient)
,
Nov 2 2016
,
Nov 2 2016
It looks like the repro is broken: crunchhunt.com is showing a domain squatter, rather than the page that was trying and failing to navigate.
,
Nov 2 2016
I missed that the domain squatter site *is* the expected behavior. In that case, this is working for me on trunk. Does this require site isolation for extensions to be forced on/off?
,
Nov 3 2016
#13, #14: anything displayed beyond the white background is the expected behavior. I don't know about trunk's use of field trials variations but I can reliably repro the issue using bisect-builds.py as per my comment in #10 (it also explains that the cause has changed since!) as well as in current Canary 56.0.2907.0 (r429169) for a different reason (also explained in #10, #6, #8): now it's blocked due to attempted framebusting.
,
Nov 3 2016
Ok, I can't reproduce with bisect-builds.py either. Tried both with an existing profile and a fresh one. I did note, however, that in trunk builds, if I force isolate extensions on, the ad iframe inside crunchhunt.com doesn't load, but if I force isolate extensions off, it appears. Re: Comment #15, Note that it's possible that this is the same root cause: Framebusting was enabled for a few weeks (as of crrev.com/2092293002), then disabled for a few weeks (as of https://crrev.com/2413513004), then reenabled recently (https://crrev.com/2392773002). The good/bad revisions you're describing are consistent with framebusting being the root cause both times. It's just weird that I'm not seeing any framebusting attempts when I try to reproduce.
,
Nov 22 2016
I'm still not able to reproduce this. woxxom@, are you still having this issue?
,
Nov 23 2016
57.0.2928.0 canary (64-bit) still doesn't show anything, and the same framebusting error is printed in the popup's console, see the attached screenshot. I've used an empty user data dir to make sure nothing else was in the way. Variations from chrome://version 6a89113b-a7aa8ed 16e0dd70-3f4a17df a444064c-1410f10 da89714-4ad60575 241fff6c-7cadd29 1e528f0f-3b7f37f3 6025934e-3f4a17df e197bfc9-ca7d8d80 8364a5c2-19b59b09 7c1bc906-f55a7974 9b8606c7-ca7d8d80 5829eceb-ca7d8d80 1c752ce9-f23d1dea ba3f87da-d0f2c564 5ca89f9-3f4a17df 76b48ab8-a2567007 f15c1c09-ca7d8d80 9e201a2b-3f4a17df 5274eb09-3f4a17df 57f575bb-3f4a17df bcc907f7-f23d1dea 9773d3bd-f23d1dea a4566d9e-f23d1dea 93731dca-ed0f00cf 2e109477-bcf405c8 9e5c75f1-b0b33f96 6b121ae7-df25e660 f79cb77b-3f4a17df b7786474-d93a0620 23a898eb-ba11b537 4ea303a6-f23d1dea 3a007b7-3f4a17df 7aa46da5-4995b330 7a3692af-bc6856d9 f2e050c6-b8c27ec3 fe9bec35-186f5907 9736de91-3f4a17df 3326cd71-3f4a17df ad6d27cc-3e870323 ca314179-ca7d8d80 69bf80fa-3f4a17df c5073fab-f23d1dea f3ea30a0-ca7d8d80 867c4c68-3f4a17df b2f0086-3d47f4f4 99c41f12-3f4a17df 7fc902e8-f23d1dea adda5502-ca7d8d80 477f6800-bbfbea97 6844d8aa-669a04e0 3ac60855-486e2a9c f296190c-20e0bb3 4442aae2-4ad60575 ed1d377-e1cc0f14 75f0f0a0-e1cc0f14 e2b18481-6e597ede e7e71889-e1cc0f14 644b8345-726d8ace 61b920c1-48c6f5be
,
Dec 14 2016
I'm also not able to reproduce this unfortunately. Not really sure what we can do as next steps. Do we have contacts for the authors of the extension?
,
Dec 14 2016
,
Dec 15 2016
#16 >It's just weird that I'm not seeing any framebusting attempts when I try to reproduce. #19 >Not really sure what we can do as next steps The offending script may be loaded for specific geo/IP locations. I'll try to be of some help. After clicking the extension icon and observing the empty popup I've rightclicked its blank iframe, invoked devtools, observed the framebusting error in console occurred on line 242 of http://d3ujb2t8x8alxd.cloudfront.net/rmgdsc/newcafv2.js?ver=1 the excerpt follows: try { if (top) { /* line 242 */ top.location.href = url; } else { location.href = url; }; return; } catch (e) {}; Normally this exception should be consumed by try-catch but for some reason it's not (supposedly, a bug), thus the iframe loading process breaks resulting in an empty page. FWIW, I can debug any of the prebuilt snapshots (including ASAN builds fetchable with bisect-builds.py) in VS2015, provided you tell me what to look for.
,
May 11 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by brajkumar@chromium.org
, Oct 7 2016Labels: Needs-Feedback