[Content suggestions] Send user's language profile to Content Suggestions Server |
||||||||||||||
Issue descriptionChrome client contains language detection based on the CLD3 library. This allows to observe in which languages the user reads the web. We should create a keyed service that collects data about languages in browsing and builds a simple model on top of that. As the next step, frequency of the UI language in the model as well as the top non-UI language and its frequency should be sent to Content Suggestions Server.
,
Oct 7 2016
Issue 603891 has been merged into this issue.
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0de27079beae15d87fd0adb969ad536422031bf9 commit 0de27079beae15d87fd0adb969ad536422031bf9 Author: jkrcal <jkrcal@chromium.org> Date: Fri Oct 07 14:06:58 2016 [LanguageModel] Return top languages only with a reasonable sample set Before, the LanguageModel returned top languages even if it had only one data point. Thus the frequencies of top languages could change drastically in the warm-up phase of the model. This CL adds a minimum size of the sample set. The model returns empty list of top languages before this minimal size is reached. BUG= 653058 Review-Url: https://codereview.chromium.org/2391383005 Cr-Commit-Position: refs/heads/master@{#423849} [modify] https://crrev.com/0de27079beae15d87fd0adb969ad536422031bf9/components/translate/core/browser/language_model.cc [modify] https://crrev.com/0de27079beae15d87fd0adb969ad536422031bf9/components/translate/core/browser/language_model.h [modify] https://crrev.com/0de27079beae15d87fd0adb969ad536422031bf9/components/translate/core/browser/language_model_unittest.cc
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2dd3bbcfd8c37c233ba1663176de847b8a90023 commit c2dd3bbcfd8c37c233ba1663176de847b8a90023 Author: jkrcal <jkrcal@chromium.org> Date: Fri Oct 07 17:58:18 2016 Sending LanguageModel info to suggestions server This CL makes use of recently introduced translate::LanguageModel. It reveals top two languages from language model in requests to content suggestions server. As LanguageModel does not have an iOS factory yet, the iOS factory passes nullptr to NTPSnippetsFetcher at the moment. Achieving feature parity on iOS is left for follow-up CLs. BUG= 653058 Review-Url: https://codereview.chromium.org/2400133002 Cr-Commit-Position: refs/heads/master@{#423906} [modify] https://crrev.com/c2dd3bbcfd8c37c233ba1663176de847b8a90023/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc [modify] https://crrev.com/c2dd3bbcfd8c37c233ba1663176de847b8a90023/components/ntp_snippets/BUILD.gn [modify] https://crrev.com/c2dd3bbcfd8c37c233ba1663176de847b8a90023/components/ntp_snippets/DEPS [modify] https://crrev.com/c2dd3bbcfd8c37c233ba1663176de847b8a90023/components/ntp_snippets/remote/ntp_snippets_fetcher.cc [modify] https://crrev.com/c2dd3bbcfd8c37c233ba1663176de847b8a90023/components/ntp_snippets/remote/ntp_snippets_fetcher.h [modify] https://crrev.com/c2dd3bbcfd8c37c233ba1663176de847b8a90023/components/ntp_snippets/remote/ntp_snippets_fetcher_unittest.cc [modify] https://crrev.com/c2dd3bbcfd8c37c233ba1663176de847b8a90023/components/ntp_snippets/remote/ntp_snippets_service_unittest.cc [modify] https://crrev.com/c2dd3bbcfd8c37c233ba1663176de847b8a90023/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc
,
Oct 11 2016
,
Oct 12 2016
Verified on Canary 56.0.2887.3.
,
Oct 14 2016
Requesting to merge the commit from comment #5 to M55.
,
Oct 14 2016
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.
,
Oct 14 2016
Is this change applicable to any specific OS or all OS?
,
Oct 17 2016
It's relevant for Android only.
,
Oct 17 2016
,
Oct 19 2016
Ping dimu/govind: Can we merge this? Time is running out for M55 merges...
,
Oct 19 2016
//+amineer@ for android merge approvals
,
Oct 20 2016
Per launch bug 637030, we're delaying this feature to M56, so we won't need to merge after all. Sorry for the noise!
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c713e7093d3e93fabecd885f93c0522272325725 commit c713e7093d3e93fabecd885f93c0522272325725 Author: jkrcal <jkrcal@chromium.org> Date: Thu Oct 06 21:53:40 2016 Add LanguageModel, a keyed service that collects language info from CLD. Before this CL, user's statistics about language detection from the CLD3 library were not accessible to Chrome. This CL introduces a new keyed service called LanguageModel that collects such statistics and builds a simple model on top of that. This allows other parts of Chrome to see top languages in which the user consumes web content. A design doc: https://docs.google.com/a/google.com/document/d/1FBD79CEBUKkMtSJKk3fnF1xnlrXd23z2fHgIGQUFOE8/edit?usp=sharing BUG= 653058 Review-Url: https://codereview.chromium.org/2396783002 Cr-Commit-Position: refs/heads/master@{#423702} [modify] https://crrev.com/c713e7093d3e93fabecd885f93c0522272325725/chrome/browser/BUILD.gn [modify] https://crrev.com/c713e7093d3e93fabecd885f93c0522272325725/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/c713e7093d3e93fabecd885f93c0522272325725/chrome/browser/translate/chrome_translate_client.cc [modify] https://crrev.com/c713e7093d3e93fabecd885f93c0522272325725/chrome/browser/translate/chrome_translate_client.h [add] https://crrev.com/c713e7093d3e93fabecd885f93c0522272325725/chrome/browser/translate/language_model_factory.cc [add] https://crrev.com/c713e7093d3e93fabecd885f93c0522272325725/chrome/browser/translate/language_model_factory.h [modify] https://crrev.com/c713e7093d3e93fabecd885f93c0522272325725/components/translate/core/browser/BUILD.gn [modify] https://crrev.com/c713e7093d3e93fabecd885f93c0522272325725/components/translate/core/browser/DEPS [add] https://crrev.com/c713e7093d3e93fabecd885f93c0522272325725/components/translate/core/browser/language_model.cc [add] https://crrev.com/c713e7093d3e93fabecd885f93c0522272325725/components/translate/core/browser/language_model.h [add] https://crrev.com/c713e7093d3e93fabecd885f93c0522272325725/components/translate/core/browser/language_model_unittest.cc
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Dec 9 2016
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1625e24d6f256d9e8d966bbc133be6f9810ff59 commit d1625e24d6f256d9e8d966bbc133be6f9810ff59 Author: jkrcal <jkrcal@chromium.org> Date: Wed Jan 18 16:54:38 2017 [NTP Snippets Fetcher] Enable sending info from LanguageModel by default Enable the feature on trunk by default. The related Launch bug is: crbug.com/637030 BUG= 653058 Review-Url: https://codereview.chromium.org/2637183002 Cr-Commit-Position: refs/heads/master@{#444396} [modify] https://crrev.com/d1625e24d6f256d9e8d966bbc133be6f9810ff59/components/ntp_snippets/remote/ntp_snippets_json_request.cc |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 6 2016