bluetooth: macOS: cleanup when Chrome is not compiled for 10.8 |
||||
Issue descriptionSome methods are used defined in 10.9. To avoid compiler warnings, pragma instructions are being used: #pragma clang diagnostic ignored "-Wpartial-availability" -[CBCentralManager retrieveConnectedPeripheralsWithServices:] used in device/bluetooth/bluetooth_adapter_mac.mm, BluetoothAdapter::RetrievedConnectedPeripherals() defined in 10.9 -[<CBPeripheralDelegate> peripheral:didModifyServices:] used in device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm, [MockCBPeripheral didModifyServices:]. defined in 10.9
,
Oct 15 2016
,
Nov 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9c107f9476d72220f6ab128578183ba9f1b18f6 commit d9c107f9476d72220f6ab128578183ba9f1b18f6 Author: jlebel <jlebel@chromium.org> Date: Mon Nov 07 22:43:43 2016 bluetooth: mac: Removing #pragma clang diagnostic ignored "-Wpartial-availability" Now the macOS version target is 10.9, therefore the definition of -[<CBPeripheralDelegate> peripheral:didModifyServices:] is known by the bot compilers. Note that this method is optional for <CBPeripheralDelegate>. BUG= 653056 Review-Url: https://codereview.chromium.org/2485633002 Cr-Commit-Position: refs/heads/master@{#430405} [modify] https://crrev.com/d9c107f9476d72220f6ab128578183ba9f1b18f6/device/bluetooth/test/mock_bluetooth_cbperipheral_mac.mm
,
Nov 7 2016
,
Nov 7 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ortuno@chromium.org
, Oct 5 2016