New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 653044 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Undefined-shift in CJBig2_HuffmanTable::ParseFromCodedBuffer

Project Member Reported by ClusterFuzz, Oct 5 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5225288063778816

Fuzzer: libfuzzer_pdf_codec_jbig2_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  CJBig2_HuffmanTable::ParseFromCodedBuffer
  CJBig2_HuffmanTable::CJBig2_HuffmanTable
  parseTable
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=421422:421461

Minimized Testcase (0.03 Kb): https://cluster-fuzz.appspot.com/download/AMIfv947yJ_EUt7OprRSnLlAD8gVQGR8G0pkVtdoi07FBaQpQcmXyLETOIMoAIqPh5mnQTHIqtd5iS5TTu1ICzYxQnsAmoQT5TLwnAShxNUgjXGn9Pqon9c4uGruB4GJ8SWqcNMmP_sMl8V9kJxxjilDnTuy0GuHug?testcase_id=5225288063778816

Issue manually filed by: ranjitkan

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: ranjitkan@chromium.org
Components: Tools>Test>FindIt>CorrectResult
Labels: -Pri-1 -Type-Bug Findit-for-crash M-55 Te-Logged Pri-2 Type-Bug-Regression
Owner: dsinclair@chromium.org
Status: Assigned (was: Untriaged)
Author: Dan Sinclair
Project: chromium-pdfium
Changelist: https://pdfium.googlesource.com/pdfium.git/+/764ec513eecbebd12781bcc96ce81ed5e736ee92
Time: Mon Mar 14 13:35:12 2016 -0400
The CL last changed line 71 of file JBig2_HuffmanTable.cpp, which is stack frame 0.

Author: Dan Sinclair
Project: chromium-pdfium
Changelist: https://pdfium.googlesource.com/pdfium.git/+/764ec513eecbebd12781bcc96ce81ed5e736ee92
Time: Mon Mar 14 13:35:12 2016 -0400
The CL last changed line 26 of file JBig2_HuffmanTable.cpp, which is stack frame 1.

Author: Dan Sinclair
Project: chromium-pdfium
Changelist: https://pdfium.googlesource.com/pdfium.git/+/764ec513eecbebd12781bcc96ce81ed5e736ee92
Time: Mon Mar 14 13:35:12 2016 -0400
The CL last changed line 1234 of file JBig2_Context.cpp, which is stack frame 2.

Author: Dan Sinclair
Project: chromium-pdfium
Changelist: https://pdfium.googlesource.com/pdfium.git/+/764ec513eecbebd12781bcc96ce81ed5e736ee92
Time: Mon Mar 14 13:35:12 2016 -0400
The CL last changed line 411 of file JBig2_Context.cpp, which is stack frame 3.

Author: Dan Sinclair
Project: chromium-pdfium
Changelist: https://pdfium.googlesource.com/pdfium.git/+/764ec513eecbebd12781bcc96ce81ed5e736ee92
Time: Mon Mar 14 13:35:12 2016 -0400
The CL last changed line 330 of file JBig2_Context.cpp, which is stack frame 4.

Author: Dan Sinclair
Project: chromium-pdfium
Changelist: https://pdfium.googlesource.com/pdfium.git/+/764ec513eecbebd12781bcc96ce81ed5e736ee92
Time: Mon Mar 14 13:35:12 2016 -0400
The CL last changed line 86 of file JBig2_Context.cpp, which is stack frame 5.

Author: Dan Sinclair
Project: chromium-pdfium
Changelist: https://pdfium.googlesource.com/pdfium.git/+/764ec513eecbebd12781bcc96ce81ed5e736ee92
Time: Mon Mar 14 13:35:12 2016 -0400
The CL last changed line 118 of file JBig2_Context.cpp, which is stack frame 6.

@dsinclair: Assigning to you, request you to please take a look into it. Please help us to reassign if not with respect to your changes.

Thanks.!
Cc: kcwu@chromium.org

Comment 3 by kcwu@chromium.org, Oct 5 2016

I can help this one if you'd like.
Cc: -kcwu@chromium.org dsinclair@chromium.org
Owner: kcwu@chromium.org
Awesome, thank you.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 6 2016

Comment 7 by kcwu@chromium.org, Oct 6 2016

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/489d17d95a8b35a239cd2b63d38c24a7a3dfc92c

commit 489d17d95a8b35a239cd2b63d38c24a7a3dfc92c
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Thu Oct 06 21:18:19 2016

Roll src/third_party/pdfium/ ca03f7a1c..3a0a808ff (4 commits).

https://pdfium.googlesource.com/pdfium.git/+log/ca03f7a1c654..3a0a808ff546

$ git log ca03f7a1c..3a0a808ff --date=short --no-merges --format='%ad %ae %s'
2016-10-06 kcwu Fix assertion failure when decoding malform G4 fax image
2016-10-06 kcwu Reject JBig2 Huffman table with too large shift value
2016-10-06 npm Split m_InstalledTTFonts into two vectors to avoid sketchy logic.
2016-10-06 caryclark switch to new skia blend mode enum class

BUG= 653044 

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2395263002
Cr-Commit-Position: refs/heads/master@{#423683}

[modify] https://crrev.com/489d17d95a8b35a239cd2b63d38c24a7a3dfc92c/DEPS

Project Member

Comment 9 by ClusterFuzz, Oct 7 2016

ClusterFuzz has detected this issue as fixed in range 423677:423751.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5225288063778816

Fuzzer: libfuzzer_pdf_codec_jbig2_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  CJBig2_HuffmanTable::ParseFromCodedBuffer
  CJBig2_HuffmanTable::CJBig2_HuffmanTable
  parseTable
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=421422:421461
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=423677:423751

Minimized Testcase (0.03 Kb): https://cluster-fuzz.appspot.com/download/AMIfv947yJ_EUt7OprRSnLlAD8gVQGR8G0pkVtdoi07FBaQpQcmXyLETOIMoAIqPh5mnQTHIqtd5iS5TTu1ICzYxQnsAmoQT5TLwnAShxNUgjXGn9Pqon9c4uGruB4GJ8SWqcNMmP_sMl8V9kJxxjilDnTuy0GuHug?testcase_id=5225288063778816

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/489d17d95a8b35a239cd2b63d38c24a7a3dfc92c

commit 489d17d95a8b35a239cd2b63d38c24a7a3dfc92c
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Thu Oct 06 21:18:19 2016

Roll src/third_party/pdfium/ ca03f7a1c..3a0a808ff (4 commits).

https://pdfium.googlesource.com/pdfium.git/+log/ca03f7a1c654..3a0a808ff546

$ git log ca03f7a1c..3a0a808ff --date=short --no-merges --format='%ad %ae %s'
2016-10-06 kcwu Fix assertion failure when decoding malform G4 fax image
2016-10-06 kcwu Reject JBig2 Huffman table with too large shift value
2016-10-06 npm Split m_InstalledTTFonts into two vectors to avoid sketchy logic.
2016-10-06 caryclark switch to new skia blend mode enum class

BUG= 653044 

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2395263002
Cr-Commit-Position: refs/heads/master@{#423683}

[modify] https://crrev.com/489d17d95a8b35a239cd2b63d38c24a7a3dfc92c/DEPS

Comment 11 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 12 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment