New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 653009 link

Starred by 1 user
Status: Duplicate
Merged: issue 581865
Owner:
kkhorimoto@chromium.org
Closed: Oct 2016
Cc:
eugene...@chromium.org
█ jif@chromium.org
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

SupportsUserData's SetUserData 2nd parameter should be a std::unique_ptr

Project Member Reported by jif@chromium.org, Oct 5 2016 
This would make it obvious that SupportsUserData takes ownership of the pointer.

Comment 1 by eugene...@chromium.org, Oct 5 2016 

jif@ are you talking about base::SupportsUserData? The cost of changing the second parameter is very high (it's basically changing hundreds of Chromium files), why what is the advantage? This will be up to base OWNERS and they will need a good reasoning to make this change.

Comment 2 by jif@chromium.org, Oct 6 2016

Mergedinto: 581865
Status: Duplicate (was: Assigned)
When I filed the bug I hadn't realize that it wasn't a bling-specific class!
The advantage is that the passing of the ownership is explicit and enforced by the compiler.

Comment 3 by jasonkliu@chromium.org, Feb 9 2017

Labels: Hotlist-GoodFirstBug
►

Sign in to add a comment