New issue
Advanced search Search tips

Issue 652999 link

Starred by 1 user
Status: Fixed
Owner:
hirosh...@chromium.org
Closed: Oct 2016
Cc:
p...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove Resource::create() to make proper subclasses of Resource are created

Project Member Reported by hirosh...@chromium.org, Oct 5 2016 
Resource::create(Raw) creates Resource, not RawResource.
This breaks the assumption that a Resource with type Resource::Raw is always RawResource, and causes illegal downcasts e.g. from Resource to RawResource.

This causes CFI bot failures:
https://codereview.chromium.org/2391523002/#msg30
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce92d73d9adf9b97c1e7e207ea52867b32621e0

commit 1ce92d73d9adf9b97c1e7e207ea52867b32621e0
Author: hiroshige <hiroshige@chromium.org>
Date: Thu Oct 06 06:49:56 2016

Remove Resource::create() to ensure proper subclasses of Resource are created

- Resource::create() -> RawResource::create() etc.
- requestResource() + TestResourceFactory -> RawResource::fetch() etc.

BUG= 652999 

Review-Url: https://codereview.chromium.org/2399473002
Cr-Commit-Position: refs/heads/master@{#423454}

[modify] https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0/third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp
[modify] https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0/third_party/WebKit/Source/core/fetch/FontResource.h
[modify] https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0/third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp
[modify] https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0/third_party/WebKit/Source/core/fetch/Resource.h
[modify] https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
[modify] https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0/third_party/WebKit/Source/core/fetch/ResourceTest.cpp
[modify] https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0/third_party/WebKit/Source/core/frame/SubresourceIntegrityTest.cpp
[modify] https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

Comment 2 by hirosh...@chromium.org, Oct 7 2016

Status: Fixed (was: Started)
Done. The bot turned green.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce92d73d9adf9b97c1e7e207ea52867b32621e0

commit 1ce92d73d9adf9b97c1e7e207ea52867b32621e0
Author: hiroshige <hiroshige@chromium.org>
Date: Thu Oct 06 06:49:56 2016

Remove Resource::create() to ensure proper subclasses of Resource are created

- Resource::create() -> RawResource::create() etc.
- requestResource() + TestResourceFactory -> RawResource::fetch() etc.

BUG= 652999 

Review-Url: https://codereview.chromium.org/2399473002
Cr-Commit-Position: refs/heads/master@{#423454}

[modify] https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0/third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp
[modify] https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0/third_party/WebKit/Source/core/fetch/FontResource.h
[modify] https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0/third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp
[modify] https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0/third_party/WebKit/Source/core/fetch/Resource.h
[modify] https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
[modify] https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0/third_party/WebKit/Source/core/fetch/ResourceTest.cpp
[modify] https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0/third_party/WebKit/Source/core/frame/SubresourceIntegrityTest.cpp
[modify] https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

Comment 4 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment