New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652979 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression

Blocking:
issue 652393



Sign in to add a comment

webkit_tests(fast/events/inputevents/inputevent-drag-drop.html) is flakey

Project Member Reported by horo@chromium.org, Oct 5 2016

Issue description

webkit_tests failing on chromium.webkit/WebKit Mac10.11 (dbg)

Type: build-failure

Builders failed on: 
- WebKit Mac10.11 (dbg): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11__dbg_/5071/layout-test-results/fast/events/inputevents/inputevent-drag-drop-actual.txt

This is a testharness.js-based test.
FAIL Testing Drag and Drop, preventDefault() and Undo entry assert_equals: expected "abc" but got ""
FAIL Testing Drag and Drop event order assert_array_equals: Testing drag editable1 onto editable2 actual order: img:dragend lengths differ, expected 6 got 1
PASS Testing Drag and Drop dataTransfer 
PASS Testing Drag and Drop preventDefault() 
FAIL Testing element removed by event handler assert_array_equals: Testing drag editable1 onto editable2 actual order: editable1:dragend lengths differ, expected 4 got 1
Harness: the test ran to completion.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fevents%2Finputevents%2Finputevent-drag-drop.html%0A&showLargeExpectations=true

 

Comment 1 by horo@chromium.org, Oct 5 2016

Blocking: 652393
Owner: chongz@chromium.org
Status: Assigned (was: Available)
chongz@
Please fix this.

Comment 2 by horo@chromium.org, Oct 5 2016

Labels: -Sheriff-Chromium
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e54340ef786164feb8b97409a7c589176c2fe3ff

commit e54340ef786164feb8b97409a7c589176c2fe3ff
Author: chongz <chongz@chromium.org>
Date: Thu Oct 06 01:29:38 2016

[LayoutTest] Fix flakey test "inputevent-drag-drop.html"

On debug mode the WPT will start before image/document is loaded.

This CL changed the tests to use styled text (instead of image) as
drag data.

Also fixed a DCHECK, which would trigger when you do Drag&Drop and
then refresh the page. (introduced in crrev.com/2374743002)

BUG= 652979 

Review-Url: https://codereview.chromium.org/2393903003
Cr-Commit-Position: refs/heads/master@{#423379}

[modify] https://crrev.com/e54340ef786164feb8b97409a7c589176c2fe3ff/third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-drag-drop.html
[modify] https://crrev.com/e54340ef786164feb8b97409a7c589176c2fe3ff/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/e54340ef786164feb8b97409a7c589176c2fe3ff/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp

Components: Blink>Input
Labels: M-55 OS-All
Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e54340ef786164feb8b97409a7c589176c2fe3ff

commit e54340ef786164feb8b97409a7c589176c2fe3ff
Author: chongz <chongz@chromium.org>
Date: Thu Oct 06 01:29:38 2016

[LayoutTest] Fix flakey test "inputevent-drag-drop.html"

On debug mode the WPT will start before image/document is loaded.

This CL changed the tests to use styled text (instead of image) as
drag data.

Also fixed a DCHECK, which would trigger when you do Drag&Drop and
then refresh the page. (introduced in crrev.com/2374743002)

BUG= 652979 

Review-Url: https://codereview.chromium.org/2393903003
Cr-Commit-Position: refs/heads/master@{#423379}

[modify] https://crrev.com/e54340ef786164feb8b97409a7c589176c2fe3ff/third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-drag-drop.html
[modify] https://crrev.com/e54340ef786164feb8b97409a7c589176c2fe3ff/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/e54340ef786164feb8b97409a7c589176c2fe3ff/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp

Comment 7 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment