New issue
Advanced search Search tips

Issue 652978 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

webkit_tests(http/tests/media/encrypted-media/encrypted-media-encrypted-event-different-origin.html) is flakey on Linux Precise MSAN

Project Member Reported by horo@chromium.org, Oct 5 2016

Issue description

webkit_tests failing on chromium.webkit/WebKit Linux Precise MSAN

Type: build-failure

Builders failed on: 
- WebKit Linux Precise MSAN: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20MSAN


https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Precise_MSAN/387/layout-test-results/http/tests/media/encrypted-media/encrypted-media-encrypted-event-different-origin-crash-log.txt

crash log for renderer (pid <unknown>):
STDOUT: CONSOLE MESSAGE: line 23: 21:47:20.702: starting
STDOUT: CONSOLE MESSAGE: line 23: 21:47:20.751: setting src
STDOUT: CONSOLE MESSAGE: line 23: 21:47:20.800: onEncrypted
STDOUT: CONSOLE MESSAGE: line 23: 21:47:20.814: onEncrypted
STDOUT: CONSOLE MESSAGE: line 23: 21:47:20.817: done
STDOUT:  This is a testharness.js-based test.
STDOUT: PASS Initialization Data not returned when using different origin. 
STDOUT: Harness: the test ran to completion.
STDOUT: 
STDERR: ==4==WARNING: MemorySanitizer: use-of-uninitialized-value
STDERR:     #0 0x121b3627 in ~DecryptingDemuxerStream media/filters/decrypting_demuxer_stream.cc:178:17
STDERR:     #1 0x121b37ec in ?? media/filters/decrypting_demuxer_stream.cc:170:53
STDERR:     #2 0x121833bc in operator() buildtools/third_party/libc++/trunk/include/memory:2529:13
STDERR:     #3 0x121833bc in reset buildtools/third_party/libc++/trunk/include/memory:2735:0
STDERR:     #4 0x121833bc in ~DecoderStream media/filters/decoder_stream.cc:88:0
STDERR:     #5 0x1218439c in ?? media/filters/decoder_stream.cc:69:45
STDERR:     #6 0x12123943 in operator() buildtools/third_party/libc++/trunk/include/memory:2529:13
STDERR:     #7 0x12123943 in reset buildtools/third_party/libc++/trunk/include/memory:2735:0
STDERR:     #8 0x12123943 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2703:0
STDERR:     #9 0x12123943 in ~VideoRendererImpl media/renderers/video_renderer_impl.cc:82:0
STDERR:     #10 0x12123c6c in ?? media/renderers/video_renderer_impl.cc:71:41
STDERR:     #11 0x1210baf8 in operator() buildtools/third_party/libc++/trunk/include/memory:2529:13
STDERR:     #12 0x1210baf8 in reset buildtools/third_party/libc++/trunk/include/memory:2735:0
STDERR:     #13 0x1210baf8 in ~RendererImpl media/renderers/renderer_impl.cc:116:0
STDERR:     #14 0x1210c60c in ?? media/renderers/renderer_impl.cc:110:31
STDERR:     #15 0x8f6063b in operator() buildtools/third_party/libc++/trunk/include/memory:2529:13
STDERR:     #16 0x8f6063b in reset buildtools/third_party/libc++/trunk/include/memory:2735:0
STDERR:     #17 0x8f6063b in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2703:0
STDERR:     #18 0x8f6063b in DestroyRenderer media/base/pipeline_impl.cc:849:0
STDERR:     #19 0x8f6063b in Stop media/base/pipeline_impl.cc:274:0
STDERR:     #20 0x629bf90 in Run base/callback.h:64:12
STDERR:     #21 0x629bf90 in RunTask base/debug/task_annotator.cc:54:0
STDERR:     #22 0x60a61fa in RunTask base/message_loop/message_loop.cc:405:19
STDERR:     #23 0x60a7bda in DeferOrRunPendingTask base/message_loop/message_loop.cc:414:5
STDERR:     #24 0x60a9748 in DoWork base/message_loop/message_loop.cc:513:13
STDERR:     #25 0x60b5b5a in Run base/message_loop/message_pump_default.cc:35:31
STDERR:     #26 0x612f37c in Run base/run_loop.cc:35:10
STDERR:     #27 0x61c80fc in ThreadMain base/threading/thread.cc:333:3
STDERR:     #28 0x61b4855 in ThreadFunc base/threading/platform_thread_posix.cc:71:13
STDERR:     #29 0x7f12c5626e99 in start_thread /build/eglibc-rrybNj/eglibc-2.15/nptl/pthread_create.c:308:0
STDERR:     #30 0x7f12c4f0538c in ?? /build/eglibc-rrybNj/eglibc-2.15/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:112:0
STDERR: 
STDERR:   Uninitialized value was created by a heap deallocation
STDERR:     #0 0x4ad392 in operator delete(void*) ??:0
STDERR:     #1 0x1045dded in Release base/memory/ref_counted.h:137:7
STDERR:     #2 0x1045dded in Release base/memory/ref_counted.h:407:0
STDERR:     #3 0x1045dded in ~scoped_refptr base/memory/ref_counted.h:311:0
STDERR:     #4 0x1045dded in ~WebContentDecryptionModuleImpl media/blink/webcontentdecryptionmodule_impl.cc:84:0
STDERR:     #5 0x1045dded in ~WebContentDecryptionModuleImpl media/blink/webcontentdecryptionmodule_impl.cc:83:0
STDERR:     #6 0x5ce2b50 in notifyContextDestroyed third_party/WebKit/Source/platform/LifecycleNotifier.h:95:15
STDERR:     #7 0xc6495bc in notifyContextDestroyed third_party/WebKit/Source/core/dom/ExecutionContext.cpp:88:29
STDERR:     #8 0xc50a4a8 in shutdown third_party/WebKit/Source/core/dom/Document.cpp:2394:21
STDERR:     #9 0xe324cbf in prepareForCommit third_party/WebKit/Source/core/loader/FrameLoader.cpp:1262:26
STDERR:     #10 0xe32571d in commitProvisionalLoad third_party/WebKit/Source/core/loader/FrameLoader.cpp:1281:8
STDERR:     #11 0xe2a143d in commitIfReady third_party/WebKit/Source/core/loader/DocumentLoader.cpp:254:20
STDERR:     #12 0xe2a143d in finishedLoading third_party/WebKit/Source/core/loader/DocumentLoader.cpp:286:0
STDERR:     #13 0xe2a8f05 in maybeLoadEmpty third_party/WebKit/Source/core/loader/DocumentLoader.cpp:652:3
STDERR:     #14 0xe2a9251 in startLoadingMainResource third_party/WebKit/Source/core/loader/DocumentLoader.cpp:662:7
STDERR:     #15 0xe3219cb in startLoad third_party/WebKit/Source/core/loader/FrameLoader.cpp:1658:32
STDERR:     #16 0xe30f858 in load third_party/WebKit/Source/core/loader/FrameLoader.cpp:1136:3
STDERR:     #17 0xaeab54c in load third_party/WebKit/Source/web/WebLocalFrameImpl.cpp:1965:21
STDERR:     #18 0xaeabdb0 in loadRequest third_party/WebKit/Source/web/WebLocalFrameImpl.cpp:885:3
STDERR:     #19 0xaeabdb0 in ?? third_party/WebKit/Source/web/WebLocalFrameImpl.cpp:882:0
STDERR:     #20 0x5f82d90 in OnReset content/shell/renderer/layout_test/blink_test_runner.cc:983:45
STDERR:     #21 0x5f823ad in DispatchToMethodImpl<content::BlinkTestRunner *, void (content::BlinkTestRunner::*)(), const std::__1::tuple<> &> base/tuple.h:144:3
STDERR:     #22 0x5f823ad in DispatchToMethod<content::BlinkTestRunner *, void (content::BlinkTestRunner::*)(), const std::__1::tuple<> &> base/tuple.h:151:0
STDERR:     #23 0x5f823ad in DispatchToMethod<content::BlinkTestRunner, void (content::BlinkTestRunner::*)(), void, std::__1::tuple<> > ipc/ipc_message_templates.h:26:0
STDERR:     #24 0x5f823ad in Dispatch<content::BlinkTestRunner, content::BlinkTestRunner, void, void (content::BlinkTestRunner::*)()> ipc/ipc_message_templates.h:121:0
STDERR:     #25 0x5f80ef1 in OnMessageReceived content/shell/renderer/layout_test/blink_test_runner.cc:770:5
STDERR:     #26 0x9f18245 in OnMessageReceived content/renderer/render_view_impl.cc:1310:19
STDERR:     #27 0x117747a7 in RouteMessage ipc/message_router.cc:56:20
STDERR:     #28 0x9be2a26 in OnMessageReceived content/child/child_thread_impl.cc:790:18
STDERR: 
STDERR: SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/c/b/linux_layout/src/out/Release/content_shell+0x121b3627)
STDERR: Exiting
STDERR: [14408:14524:1004/214720:2228811904:WARNING:audio_sync_reader.cc(166)] AudioSyncReader::Read timed out, audio glitch count=1


http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmedia%2Fencrypted-media%2Fencrypted-media-encrypted-event-different-origin.html&showLargeExpectations=true


 

Comment 1 by horo@chromium.org, Oct 5 2016

Owner: jrumm...@chromium.org
Status: Assigned (was: Available)
jrummell@
Can you handle this?
Thank you.

Comment 2 by horo@chromium.org, Oct 5 2016

Labels: -Sheriff-Chromium

Comment 3 by horo@chromium.org, Oct 5 2016

Components: -Blink>MediaStream Internals>Media Internals>Media>Encrypted

Comment 4 Deleted

Comment 5 by horo@chromium.org, Oct 5 2016

Created a cl to update TestExpectations.
https://codereview.chromium.org/2393803002

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc9a6ce269bed0053a44bca54c1369ff42060192

commit cc9a6ce269bed0053a44bca54c1369ff42060192
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Wed Oct 05 10:30:09 2016

Add encrypted-media-encrypted-event-different-origin.html to TestExpectations

BUG= 652978 
TBR=jrummell@chromium.org

Review URL: https://codereview.chromium.org/2393803002 .

Cr-Commit-Position: refs/heads/master@{#423124}

[modify] https://crrev.com/cc9a6ce269bed0053a44bca54c1369ff42060192/third_party/WebKit/LayoutTests/TestExpectations

Summary: webkit_tests(http/tests/media/encrypted-media/encrypted-media-encrypted-event-different-origin.html) is flakey on Linux Precise MSAN (was: webkit_tests(http/tests/media/encrypted-media/encrypted-media-encrypted-event-different-origin.html) is flakey)
Issue 652985 has been merged into this issue.
 Issue 653247  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59e4787efb8b187e6f3701c3202ac69cfa72d8f9

commit 59e4787efb8b187e6f3701c3202ac69cfa72d8f9
Author: tkent <tkent@chromium.org>
Date: Thu Oct 06 05:54:51 2016

Mark more encrypted-media tests as flaky.

BUG= 652978 
TBR=jrummell@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2397833003
Cr-Commit-Position: refs/heads/master@{#423445}

[modify] https://crrev.com/59e4787efb8b187e6f3701c3202ac69cfa72d8f9/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e616ee95642ecc0b168a8e807abc86ff3633cda8

commit e616ee95642ecc0b168a8e807abc86ff3633cda8
Author: jrummell <jrummell@chromium.org>
Date: Sat Oct 08 02:15:44 2016

Keep reference to CDM to avoid it's premature destruction

Occassionally the CDM object is destroyed before the pipeline that
uses it is stopped, so have WebMediaPlayerImpl keep a reference to
it to prevent this from happening.

This worked in the past as the pipeline was destroyed from
HTMLMediaElement::stop() while the CDM was destroyed later from
MediaKeys::contextDestroyed(). A recent change merged stop()
and contextDestroyed(), so the CDM can be freed before
WebMediaPlayerImpl is done with it.

BUG= 652978 , 653001 
TEST=EME layout tests pass

Review-Url: https://codereview.chromium.org/2402563002
Cr-Commit-Position: refs/heads/master@{#424046}

[modify] https://crrev.com/e616ee95642ecc0b168a8e807abc86ff3633cda8/media/blink/cdm_session_adapter.cc
[modify] https://crrev.com/e616ee95642ecc0b168a8e807abc86ff3633cda8/media/blink/cdm_session_adapter.h
[modify] https://crrev.com/e616ee95642ecc0b168a8e807abc86ff3633cda8/media/blink/webcontentdecryptionmodule_impl.cc
[modify] https://crrev.com/e616ee95642ecc0b168a8e807abc86ff3633cda8/media/blink/webcontentdecryptionmodule_impl.h
[modify] https://crrev.com/e616ee95642ecc0b168a8e807abc86ff3633cda8/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/e616ee95642ecc0b168a8e807abc86ff3633cda8/media/blink/webmediaplayer_impl.h

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6be4d9fbc0b33047dfe901e2bbe2c322efda30cd

commit 6be4d9fbc0b33047dfe901e2bbe2c322efda30cd
Author: jrummell <jrummell@chromium.org>
Date: Tue Oct 11 00:10:46 2016

Reenable encrypted-media tests.

After https://codereview.chromium.org/2402563002/, the encrypted-media
tests are no longer crashing, so reenabling them.

BUG= 652978 , 653001 
TEST=EME layout tests pass

Review-Url: https://codereview.chromium.org/2406013002
Cr-Commit-Position: refs/heads/master@{#424297}

[modify] https://crrev.com/6be4d9fbc0b33047dfe901e2bbe2c322efda30cd/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 11 2016

Labels: merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6

commit f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6
Author: John Rummell <jrummell@chromium.org>
Date: Tue Oct 11 23:28:26 2016

Merge "Keep reference to CDM to avoid it's premature destruction"

Occassionally the CDM object is destroyed before the pipeline that
uses it is stopped, so have WebMediaPlayerImpl keep a reference to
it to prevent this from happening.

This worked in the past as the pipeline was destroyed from
HTMLMediaElement::stop() while the CDM was destroyed later from
MediaKeys::contextDestroyed(). A recent change merged stop()
and contextDestroyed(), so the CDM can be freed before
WebMediaPlayerImpl is done with it.

BUG= 652978 , 653001 
TEST=EME layout tests pass

Review-Url: https://codereview.chromium.org/2402563002
Cr-Commit-Position: refs/heads/master@{#424046}
(cherry picked from commit e616ee95642ecc0b168a8e807abc86ff3633cda8)

Review URL: https://codereview.chromium.org/2412773002 .

Cr-Commit-Position: refs/branch-heads/2883@{#51}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6/media/blink/cdm_session_adapter.cc
[modify] https://crrev.com/f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6/media/blink/cdm_session_adapter.h
[modify] https://crrev.com/f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6/media/blink/webcontentdecryptionmodule_impl.cc
[modify] https://crrev.com/f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6/media/blink/webcontentdecryptionmodule_impl.h
[modify] https://crrev.com/f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6/media/blink/webmediaplayer_impl.h

Status: Fixed (was: Assigned)
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc9a6ce269bed0053a44bca54c1369ff42060192

commit cc9a6ce269bed0053a44bca54c1369ff42060192
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Wed Oct 05 10:30:09 2016

Add encrypted-media-encrypted-event-different-origin.html to TestExpectations

BUG= 652978 
TBR=jrummell@chromium.org

Review URL: https://codereview.chromium.org/2393803002 .

Cr-Commit-Position: refs/heads/master@{#423124}

[modify] https://crrev.com/cc9a6ce269bed0053a44bca54c1369ff42060192/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 16 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59e4787efb8b187e6f3701c3202ac69cfa72d8f9

commit 59e4787efb8b187e6f3701c3202ac69cfa72d8f9
Author: tkent <tkent@chromium.org>
Date: Thu Oct 06 05:54:51 2016

Mark more encrypted-media tests as flaky.

BUG= 652978 
TBR=jrummell@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2397833003
Cr-Commit-Position: refs/heads/master@{#423445}

[modify] https://crrev.com/59e4787efb8b187e6f3701c3202ac69cfa72d8f9/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6

commit f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6
Author: John Rummell <jrummell@chromium.org>
Date: Tue Oct 11 23:28:26 2016

Merge "Keep reference to CDM to avoid it's premature destruction"

Occassionally the CDM object is destroyed before the pipeline that
uses it is stopped, so have WebMediaPlayerImpl keep a reference to
it to prevent this from happening.

This worked in the past as the pipeline was destroyed from
HTMLMediaElement::stop() while the CDM was destroyed later from
MediaKeys::contextDestroyed(). A recent change merged stop()
and contextDestroyed(), so the CDM can be freed before
WebMediaPlayerImpl is done with it.

BUG= 652978 , 653001 
TEST=EME layout tests pass

Review-Url: https://codereview.chromium.org/2402563002
Cr-Commit-Position: refs/heads/master@{#424046}
(cherry picked from commit e616ee95642ecc0b168a8e807abc86ff3633cda8)

Review URL: https://codereview.chromium.org/2412773002 .

Cr-Commit-Position: refs/branch-heads/2883@{#51}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6/media/blink/cdm_session_adapter.cc
[modify] https://crrev.com/f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6/media/blink/cdm_session_adapter.h
[modify] https://crrev.com/f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6/media/blink/webcontentdecryptionmodule_impl.cc
[modify] https://crrev.com/f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6/media/blink/webcontentdecryptionmodule_impl.h
[modify] https://crrev.com/f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/f5e4c23ccfb23ae1fe6e7aac3aed6b81664f29f6/media/blink/webmediaplayer_impl.h

Comment 18 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment