New issue
Advanced search Search tips

Issue 652959 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add a spinner to text input dialog

Project Member Reported by shaktisahu@chromium.org, Oct 5 2016

Issue description

The spinner should dismiss on HIDE_IME request.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d1c669b5c8b03dc232859960adb5d571c4c76db

commit 3d1c669b5c8b03dc232859960adb5d571c4c76db
Author: shaktisahu <shaktisahu@chromium.org>
Date: Sat Nov 05 00:53:28 2016

Blimp: Added spinner to text input dialog

Added a spinner (ProgressBar with indeterminate style) to the text input
AlertDialog. The spinner is shown when user hits enter/OK, and is
dismissed on receiving a hide IME request or if the user hasn't changed
the text or cancelling the dialog through back button/touching outside.
During submission, the EditText background changes to a dotted line.

In an unrelated change, fixed the IME editor options (following similar
structure as ImeUtils.java). This enables multi-line input for text area.

BUG= 652959 

Review-Url: https://codereview.chromium.org/2393443004
Cr-Commit-Position: refs/heads/master@{#430105}

[add] https://crrev.com/3d1c669b5c8b03dc232859960adb5d571c4c76db/blimp/client/app/android/java/res/drawable/dotted_line.xml
[modify] https://crrev.com/3d1c669b5c8b03dc232859960adb5d571c4c76db/blimp/client/app/android/java/res/layout/text_input_popup.xml
[add] https://crrev.com/3d1c669b5c8b03dc232859960adb5d571c4c76db/blimp/client/app/android/java/res/layout/web_input_bottom_panel.xml
[modify] https://crrev.com/3d1c669b5c8b03dc232859960adb5d571c4c76db/blimp/client/app/android/java/res/values/colors.xml
[modify] https://crrev.com/3d1c669b5c8b03dc232859960adb5d571c4c76db/blimp/client/app/android/java/res/values/dimens.xml
[modify] https://crrev.com/3d1c669b5c8b03dc232859960adb5d571c4c76db/blimp/client/app/android/java/strings/android_blimp_strings.grd
[modify] https://crrev.com/3d1c669b5c8b03dc232859960adb5d571c4c76db/blimp/client/core/contents/BUILD.gn
[modify] https://crrev.com/3d1c669b5c8b03dc232859960adb5d571c4c76db/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/input/ImeEditText.java
[modify] https://crrev.com/3d1c669b5c8b03dc232859960adb5d571c4c76db/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/input/ImeHelperDialog.java
[add] https://crrev.com/3d1c669b5c8b03dc232859960adb5d571c4c76db/blimp/client/core/contents/android/java/src/org/chromium/blimp/core/contents/input/WebInputConfirmationPanel.java
[modify] https://crrev.com/3d1c669b5c8b03dc232859960adb5d571c4c76db/blimp/engine/feature/engine_render_widget_feature.cc
[modify] https://crrev.com/3d1c669b5c8b03dc232859960adb5d571c4c76db/blimp/engine/feature/engine_render_widget_feature.h
[modify] https://crrev.com/3d1c669b5c8b03dc232859960adb5d571c4c76db/build/android/lint/suppressions.xml

Status: Fixed (was: Started)
Labels: Archive-Blimp

Sign in to add a comment