New issue
Advanced search Search tips

Issue 652957 link

Starred by 1 user
Status: Fixed
Owner:
karandeepb@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MacViews: Composition not cancelled on mouse click and extra composition commit.

Project Member Reported by karandeepb@chromium.org, Oct 5 2016 
An active composition should be cancelled on a mouse click.

Steps-
1) Enable chrome://flags/#mac-views-native-dialogs.
2) Change input method to Katakana.
3) Enter some text in the Name textfield so that the IME popup shows.
4) Click in the name textfield.

Expected
The IME popup should close.

Actual
The IME popup doesn't close.

Comment 1 by karandeepb@chromium.org, Oct 20 2016 

Related bug-

1) Enable chrome://flags/#mac-views-native-dialogs.
2) Change input method to Katakana.
3) Enter some text in the Name textfield so that the IME popup shows.
4) Click in the name textfield. The composition underline should be removed indicated the composition text was confirmed.
5) Press Esc.

The composition text is committed again, which is a bug.

Comment 2 by karandeepb@chromium.org, Oct 20 2016

Summary: MacViews: Cancel composition on mouse click and extra composition commit. (was: MacViews: Cancel composition on mouse click.)

Comment 3 by karandeepb@chromium.org, Oct 20 2016

Summary: MacViews: Composition not cancelled on mouse click and extra composition commit. (was: MacViews: Cancel composition on mouse click and extra composition commit.)

Comment 4 by karandeepb@chromium.org, Oct 26 2016

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de65bcf491e13a0a7e0724e8732977561588072e

commit de65bcf491e13a0a7e0724e8732977561588072e
Author: karandeepb <karandeepb@chromium.org>
Date: Wed Oct 26 00:56:02 2016

MacViews: Implement InputMethodMac::CancelComposition.

Currently, clicking inside a Textfield with an active composition, commits the
composition text but does not close the IME candidate window. Hence, while
Views::Textfield has committed the composition, the Cocoa text system does not
know about it, leading to an incorrect state where the composition text may be
committed once more.

This CL implements InputMethodMac::CancelComposition which signals the Cocoa
text system to close the IME candidate window and discard the composition text.

BUG= 652957 

Review-Url: https://codereview.chromium.org/2434433006
Cr-Commit-Position: refs/heads/master@{#427557}

[modify] https://crrev.com/de65bcf491e13a0a7e0724e8732977561588072e/ui/base/ime/BUILD.gn
[modify] https://crrev.com/de65bcf491e13a0a7e0724e8732977561588072e/ui/base/ime/input_method_mac.mm
►

Sign in to add a comment