New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652939 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

[DevTools] move debugger-script.js to native

Project Member Reported by kozyatinskiy@chromium.org, Oct 5 2016

Issue description

It's main mirrors client in v8-inspector.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/377533fc06cb43e84a765775ebf057c053961973

commit 377533fc06cb43e84a765775ebf057c053961973
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Wed Oct 19 02:00:21 2016

[inspector] move changeBreakpointState from debugger-script to native

* introduced v8::DebugInterface::ChangeBreakOnException(Isolate*,ExceptionBreakState);
* migrated inspector to new API;
* added cctest for new API;
* added inspector test for setPauseOnExceptionState.

BUG= chromium:652939 , v8:5510 
R=dgozman@chromium.org,yangguo@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2396193002
Cr-Commit-Position: refs/heads/master@{#40413}

[modify] https://crrev.com/377533fc06cb43e84a765775ebf057c053961973/src/api.cc
[modify] https://crrev.com/377533fc06cb43e84a765775ebf057c053961973/src/debug/debug-interface.h
[modify] https://crrev.com/377533fc06cb43e84a765775ebf057c053961973/src/inspector/debugger-script.js
[modify] https://crrev.com/377533fc06cb43e84a765775ebf057c053961973/src/inspector/debugger_script_externs.js
[modify] https://crrev.com/377533fc06cb43e84a765775ebf057c053961973/src/inspector/injected-script.cc
[modify] https://crrev.com/377533fc06cb43e84a765775ebf057c053961973/src/inspector/injected-script.h
[modify] https://crrev.com/377533fc06cb43e84a765775ebf057c053961973/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/377533fc06cb43e84a765775ebf057c053961973/src/inspector/v8-debugger.cc
[modify] https://crrev.com/377533fc06cb43e84a765775ebf057c053961973/src/inspector/v8-debugger.h
[modify] https://crrev.com/377533fc06cb43e84a765775ebf057c053961973/test/cctest/test-debug.cc
[add] https://crrev.com/377533fc06cb43e84a765775ebf057c053961973/test/inspector/debugger/break-on-exception-expected.txt
[add] https://crrev.com/377533fc06cb43e84a765775ebf057c053961973/test/inspector/debugger/break-on-exception.js

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/859eddbdefdd99a25164f2286b33a39051356ca4

commit 859eddbdefdd99a25164f2286b33a39051356ca4
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu Oct 20 05:37:14 2016

[inspector] migrate stepping related methods to debug-interface

* introduced DebugInterface::PrepareStep and DebugInterface::ClearStepping method.
Inspector calls these methods only on pause and not interseted in calling this for not current break_id so we don't need to expose debug interface with break_id argument and can only check that current break_id is valid.

BUG= chromium:652939 , v8:5510 
R=yangguo@chromium.org,dgozman@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2423153002
Cr-Commit-Position: refs/heads/master@{#40450}

[modify] https://crrev.com/859eddbdefdd99a25164f2286b33a39051356ca4/src/api.cc
[modify] https://crrev.com/859eddbdefdd99a25164f2286b33a39051356ca4/src/debug/debug-interface.h
[modify] https://crrev.com/859eddbdefdd99a25164f2286b33a39051356ca4/src/debug/debug.h
[modify] https://crrev.com/859eddbdefdd99a25164f2286b33a39051356ca4/src/inspector/debugger-script.js
[modify] https://crrev.com/859eddbdefdd99a25164f2286b33a39051356ca4/src/inspector/debugger_script_externs.js
[modify] https://crrev.com/859eddbdefdd99a25164f2286b33a39051356ca4/src/inspector/v8-debugger.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5006df44c39564cf70d460b8689bb1899566734f

commit 5006df44c39564cf70d460b8689bb1899566734f
Author: machenbach <machenbach@chromium.org>
Date: Thu Oct 20 08:31:52 2016

Revert of [inspector] migrate stepping related methods to debug-interface (patchset #3 id:40001 of https://chromiumcodereview.appspot.com/2423153002/ )

Reason for revert:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10808

https://github.com/v8/v8/wiki/Blink-layout-tests

Original issue's description:
> [inspector] migrate stepping related methods to debug-interface
>
> * introduced DebugInterface::PrepareStep and DebugInterface::ClearStepping method.
> Inspector calls these methods only on pause and not interseted in calling this for not current break_id so we don't need to expose debug interface with break_id argument and can only check that current break_id is valid.
>
> BUG= chromium:652939 , v8:5510 
> R=yangguo@chromium.org,dgozman@chromium.org

TBR=yangguo@chromium.org,dgozman@chromium.org,kozyatinskiy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:652939 , v8:5510 

Review-Url: https://chromiumcodereview.appspot.com/2441583002
Cr-Commit-Position: refs/heads/master@{#40455}

[modify] https://crrev.com/5006df44c39564cf70d460b8689bb1899566734f/src/api.cc
[modify] https://crrev.com/5006df44c39564cf70d460b8689bb1899566734f/src/debug/debug-interface.h
[modify] https://crrev.com/5006df44c39564cf70d460b8689bb1899566734f/src/debug/debug.h
[modify] https://crrev.com/5006df44c39564cf70d460b8689bb1899566734f/src/inspector/debugger-script.js
[modify] https://crrev.com/5006df44c39564cf70d460b8689bb1899566734f/src/inspector/debugger_script_externs.js
[modify] https://crrev.com/5006df44c39564cf70d460b8689bb1899566734f/src/inspector/v8-debugger.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/24e5dfb546d01394f375b61d55862201fa7df872

commit 24e5dfb546d01394f375b61d55862201fa7df872
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu Oct 20 18:51:34 2016

[inspector] migrate stepping related methods to debug-interface

* introduced DebugInterface::PrepareStep and DebugInterface::ClearStepping method.
Inspector calls these methods only on pause and not interseted in calling this for not current break_id so we don't need to expose debug interface with break_id argument and can only check that current break_id is valid.

BUG= chromium:652939 , v8:5510 
R=yangguo@chromium.org,dgozman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://chromiumcodereview.appspot.com/2423153002
Cr-Commit-Position: refs/heads/master@{#40483}

[modify] https://crrev.com/24e5dfb546d01394f375b61d55862201fa7df872/src/api.cc
[modify] https://crrev.com/24e5dfb546d01394f375b61d55862201fa7df872/src/debug/debug-interface.h
[modify] https://crrev.com/24e5dfb546d01394f375b61d55862201fa7df872/src/debug/debug.h
[modify] https://crrev.com/24e5dfb546d01394f375b61d55862201fa7df872/src/inspector/debugger-script.js
[modify] https://crrev.com/24e5dfb546d01394f375b61d55862201fa7df872/src/inspector/debugger_script_externs.js
[modify] https://crrev.com/24e5dfb546d01394f375b61d55862201fa7df872/src/inspector/v8-debugger.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/194a578e9c943b3f203fbc008d639a260b90e87c

commit 194a578e9c943b3f203fbc008d639a260b90e87c
Author: machenbach <machenbach@chromium.org>
Date: Fri Oct 21 12:27:48 2016

Request new layout test baseline for V8 change

Was rebaselined while
https://chromiumcodereview.appspot.com/2423153002 landed in
V8, which changed the line numbers again.

BUG= 656622 , 652939 , v8:5510 

TBR=clemensh@chromium.org, kozyatinskiy@chromium.org
NOTRY=true

Review-Url: https://chromiumcodereview.appspot.com/2442733002
Cr-Commit-Position: refs/heads/master@{#426774}

[modify] https://crrev.com/194a578e9c943b3f203fbc008d639a260b90e87c/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f7f591ab6b0061abc302120ad3040e51e2c43852

commit f7f591ab6b0061abc302120ad3040e51e2c43852
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Sat Oct 29 02:17:38 2016

[inspector] migrate scriptParsed and getCompiledScripts to native

* Introduced DebugInterface::Script - native wrapper on internal::Script.
* Migrated getCompildScripts and scriptParsed to native wrapper.

BUG= chromium:652939 ,  v8:5510 
R=yangguo@chromium.org,dgozman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2449213002
Cr-Commit-Position: refs/heads/master@{#40660}

[modify] https://crrev.com/f7f591ab6b0061abc302120ad3040e51e2c43852/src/api.cc
[modify] https://crrev.com/f7f591ab6b0061abc302120ad3040e51e2c43852/src/api.h
[modify] https://crrev.com/f7f591ab6b0061abc302120ad3040e51e2c43852/src/debug/debug-interface.h
[modify] https://crrev.com/f7f591ab6b0061abc302120ad3040e51e2c43852/src/inspector/debugger-script.js
[modify] https://crrev.com/f7f591ab6b0061abc302120ad3040e51e2c43852/src/inspector/v8-debugger-script.cc
[modify] https://crrev.com/f7f591ab6b0061abc302120ad3040e51e2c43852/src/inspector/v8-debugger-script.h
[modify] https://crrev.com/f7f591ab6b0061abc302120ad3040e51e2c43852/src/inspector/v8-debugger.cc
[add] https://crrev.com/f7f591ab6b0061abc302120ad3040e51e2c43852/test/inspector/debugger/script-on-after-compile-expected.txt
[add] https://crrev.com/f7f591ab6b0061abc302120ad3040e51e2c43852/test/inspector/debugger/script-on-after-compile.js

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5

commit c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu Jul 27 15:57:30 2017

[inspector] move stack trace and scope inspection to native

This CL moves us much closer to the point where we can remove debugger-script.js and usage of debugger context from inspector.
There are three main parts left:
- managing breakpoints,
- inspecting stack and scopes (this CL),
- LiveEdit.

In this CL I moved all stack/scope inspection to native. As side effect running debugger and inspector tests are 10-20% faster (it's significant since not all of tests requesting break).

R=yangguo@chromium.org,jgruber@chromium.org

Bug:  chromium:652939 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I409396a687e18e9c0554c0c9c35b6e1064627be8
Reviewed-on: https://chromium-review.googlesource.com/580645
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46947}
[modify] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/BUILD.gn
[modify] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/api.cc
[modify] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/debug/debug-interface.h
[add] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/debug/debug-scope-iterator.cc
[add] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/debug/debug-scope-iterator.h
[modify] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/debug/debug-scopes.cc
[modify] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/debug/debug-scopes.h
[add] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/debug/debug-stack-trace-iterator.cc
[add] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/debug/debug-stack-trace-iterator.h
[modify] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/inspector/BUILD.gn
[modify] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/inspector/debugger-script.js
[modify] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/inspector/debugger_script_externs.js
[modify] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/inspector/inspector.gypi
[delete] https://crrev.com/b4f1e24078b572aa99cb90ce203a36d8ca99b2c3/src/inspector/java-script-call-frame.cc
[delete] https://crrev.com/b4f1e24078b572aa99cb90ce203a36d8ca99b2c3/src/inspector/java-script-call-frame.h
[modify] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/inspector/v8-debugger-agent-impl.h
[modify] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/inspector/v8-debugger.cc
[modify] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/inspector/v8-debugger.h
[modify] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/v8.gyp
[modify] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/wasm/wasm-debug.cc
[modify] https://crrev.com/c5e9416b1d2e55a4d052e8dcd9848c18e4f3d8a5/src/wasm/wasm-objects.h
[delete] https://crrev.com/b4f1e24078b572aa99cb90ce203a36d8ca99b2c3/test/inspector/debugger/script-with-negative-offset-expected.txt
[delete] https://crrev.com/b4f1e24078b572aa99cb90ce203a36d8ca99b2c3/test/inspector/debugger/script-with-negative-offset.js

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4

commit 6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Jul 28 21:55:05 2017

[inspector] move SetScriptSource call to native

To avoid using debugging context and debugger-script.js on inspector side we can move SetScriptSource call to v8::internal::Debug. Theoretically we can move live edit implementation to native completely but since it will be reimplemented it looks redundant.

R=yangguo@chromium.org,jgruber@chromium.org

Bug:  chromium:652939 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: Id09492c2d2a93efbde429c9cc1bc181d5fdda19b
Reviewed-on: https://chromium-review.googlesource.com/590736
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46985}
[modify] https://crrev.com/6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4/src/api.cc
[modify] https://crrev.com/6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4/src/debug/debug-interface.h
[modify] https://crrev.com/6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4/src/debug/debug.cc
[modify] https://crrev.com/6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4/src/debug/debug.h
[modify] https://crrev.com/6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4/src/debug/liveedit.js
[modify] https://crrev.com/6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4/src/inspector/debugger-script.js
[modify] https://crrev.com/6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4/src/inspector/debugger_script_externs.js
[modify] https://crrev.com/6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4/src/inspector/v8-debugger-script.cc
[modify] https://crrev.com/6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4/src/inspector/v8-debugger-script.h
[modify] https://crrev.com/6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4/src/inspector/v8-debugger.cc
[modify] https://crrev.com/6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4/src/inspector/v8-debugger.h
[add] https://crrev.com/6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4/test/inspector/debugger/set-script-source-2-expected.txt
[add] https://crrev.com/6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4/test/inspector/debugger/set-script-source-2.js
[modify] https://crrev.com/6b0bf1659e734d2e1c67cc874bd08c60a2b24cf4/test/inspector/protocol-test.js

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f2fe13f663f424f7fe324c2640c4063252b9fd39

commit f2fe13f663f424f7fe324c2640c4063252b9fd39
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Mon Jul 31 21:23:27 2017

[inspector] don't call clearAllBreakpoints

This call from inspector side is redundant, V8 will clear all breakpoints on removing debug delegate in v8::internal::Debug::Unload method.

In any case for correct support of multiclient we need to clear breakpoints in V8DebuggerAgentImpl::disable method.

R=dgozman@chromium.org

Bug:  v8:5510 , chromium:652939 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I66f9b97797860bad28884a099928d54ac3560428
Reviewed-on: https://chromium-review.googlesource.com/592281
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47022}
[modify] https://crrev.com/f2fe13f663f424f7fe324c2640c4063252b9fd39/src/inspector/debugger-script.js
[modify] https://crrev.com/f2fe13f663f424f7fe324c2640c4063252b9fd39/src/inspector/debugger_script_externs.js
[modify] https://crrev.com/f2fe13f663f424f7fe324c2640c4063252b9fd39/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/f2fe13f663f424f7fe324c2640c4063252b9fd39/src/inspector/v8-debugger.cc
[modify] https://crrev.com/f2fe13f663f424f7fe324c2640c4063252b9fd39/src/inspector/v8-debugger.h
[add] https://crrev.com/f2fe13f663f424f7fe324c2640c4063252b9fd39/test/inspector/debugger/clear-breakpoints-on-disable-expected.txt
[add] https://crrev.com/f2fe13f663f424f7fe324c2640c4063252b9fd39/test/inspector/debugger/clear-breakpoints-on-disable.js

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25

commit cd9e86a59e99ab94cf6cefdb79fd1140cb813e25
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Wed Aug 02 19:20:26 2017

[inspector] move breakpoint management to native

My goal was to move breakpoint API to native with minimal changes around, so on inspector side we use v8::debug::BreakpointId instead of String16, on v8::internal::Debug we use i::BreakPoint object instead of break point object created inside of debug.js.

There are a lot of opportunities how we can improve breakpoints (at least we can avoid some of linear lookups to speedup implementation) but I think that as first step we need to remove mirrors/debug.js APIs.

Drive by: debugger-script.js and usage of debugger context in inspector code base.

R=yangguo@chromium.org,jgruber@chromium.org,clemensh@chromium.org

Bug:  v8:5510 , chromium:652939 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I0b17972c39053dd4989bbe26db2bb0b88ca378f7
Reviewed-on: https://chromium-review.googlesource.com/593156
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47091}
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/api.cc
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/debug/debug-interface.h
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/debug/debug.cc
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/debug/debug.h
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/debug/interface-types.h
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/factory.cc
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/factory.h
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/BUILD.gn
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/PRESUBMIT.py
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/build/compile-scripts.py
[delete] https://crrev.com/41daf8a5798fc2ae603bea8274790a57942394f3/src/inspector/debugger-script.js
[delete] https://crrev.com/41daf8a5798fc2ae603bea8274790a57942394f3/src/inspector/debugger_script_externs.js
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/injected-script.cc
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/inspected-context.cc
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/inspector.gyp
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/inspector.gypi
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/v8-console.cc
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/v8-debugger-agent-impl.h
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/v8-debugger-script.cc
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/v8-debugger-script.h
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/v8-debugger.cc
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/v8-debugger.h
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/v8-injected-script-host.cc
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/v8-inspector-impl.cc
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/v8-inspector-impl.h
[rename] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/v8-value-utils.cc
[rename] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/inspector/v8-value-utils.h
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/objects-inl.h
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/objects.h
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/objects/debug-objects-inl.h
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/objects/debug-objects.cc
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/objects/debug-objects.h
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/v8.gyp
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/src/wasm/wasm-debug.cc
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/test/cctest/compiler/test-run-bytecode-graph-builder.cc
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/test/cctest/wasm/test-wasm-breakpoints.cc
[modify] https://crrev.com/cd9e86a59e99ab94cf6cefdb79fd1140cb813e25/test/debugger/debug/debug-script.js

Status: Fixed (was: Assigned)

Sign in to add a comment