New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652926 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature
Proj-XR
Proj-XR-VR

Blocked on:
issue 644785
issue 653671



Sign in to add a comment

Enable WebVR Origin Trial experiment

Project Member Reported by amp@chromium.org, Oct 5 2016

Issue description

WebVR is already set as a RuntimeFeature, but needs integration into the origin trials framework before experiments can begin.

Intent to experiment: https://groups.google.com/a/chromium.org/d/msg/blink-dev/zGAzqfi0e00/atXaz8UCAQAJ

 

Comment 1 by amp@chromium.org, Oct 7 2016

Blockedon: 653671
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96e5488ff8ee752b774b20c3eea3ffd0227a70d6

commit 96e5488ff8ee752b774b20c3eea3ffd0227a70d6
Author: amp <amp@chromium.org>
Date: Fri Oct 07 19:20:02 2016

Enable WebVR origin trial experiments.

Intent to Experiment discussion:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/zGAzqfi0e00/atXaz8UCAQAJ

BUG= 652926 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2385123005
Cr-Commit-Position: refs/heads/master@{#423925}

[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/modules/gamepad/Gamepad.idl
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/modules/gamepad/GamepadButton.idl
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/modules/gamepad/GamepadPose.idl
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/modules/vr/NavigatorVR.idl
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/modules/vr/VRDisplay.idl
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/modules/vr/VRDisplayCapabilities.idl
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/modules/vr/VRDisplayEvent.idl
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/modules/vr/VRDisplayEventInit.idl
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/modules/vr/VREyeParameters.idl
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/modules/vr/VRFieldOfView.idl
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/modules/vr/VRFrameData.idl
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/modules/vr/VRLayer.idl
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/modules/vr/VRPose.idl
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/modules/vr/VRStageParameters.idl
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/96e5488ff8ee752b774b20c3eea3ffd0227a70d6/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Comment 3 by amp@chromium.org, Oct 7 2016

Blockedon: 644785
Labels: -Type-Bug M-56 Type-Feature
Owner: meganlindsay@chromium.org
Status: Assigned (was: Started)
Code is in place.  Full release is blocked on a bug in the trials framework, and getting all the parts into the official Chrome release.  Setting this blocking on getting the GVR library into the build (which I think is the last major task for getting into official builds).

We still need to sync up with the origin trials team to get WebVR added to the list of available experiments on their sign up page (and possibly some other devrel steps such as adding a README to our samples site with instructions for how to get a token).

See https://github.com/jpchase/OriginTrials/blob/gh-pages/ship-as-trial.md for the full description of what needs to be done.

Assigning to Megan to finish off those parts (or reassign as needed).

Comment 4 by amp@chromium.org, Oct 19 2016

Some clarification about the trials framework bug.

crbug/653671 blocks the ability to enable the trial via an html meta tag in the header.  If the trial token is included the the http headers it should work fine.

Comment 5 by amp@chromium.org, Nov 21 2016

The origin trial is now working in M56 canary.  I'm not sure if we want to mark this as fixed now, or after the trial sign up ui is enabled.

Comment 6 by sko...@chromium.org, Nov 21 2016

Let's close it once the sign up UI has landed.
Labels: Proj-VR

Comment 8 by amp@chromium.org, Dec 13 2016

Status: Fixed (was: Assigned)
Blog post went out and sign up ui is ready.  Marking as fixed.

Sign in to add a comment