Show warnings when APKs are downloaded on Clank |
||||||||
Issue descriptionThe new download manager removed these warnings.
,
Oct 5 2016
I'll wait to push this out till this hits canary, to verify it doesn't break anything, since it may be hitting new code.
,
Oct 7 2016
It shows a broken warning, so I'll revert the APK config until http://crbug.com/653961 is fixed.
,
Oct 7 2016
,
Oct 7 2016
,
Oct 7 2016
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84c632df136adb79c1282df0509daff8747e088c commit 84c632df136adb79c1282df0509daff8747e088c Author: nparker <nparker@chromium.org> Date: Fri Oct 07 22:53:06 2016 Revert "Mark APK downloads as dangerous on Android" This reverts commit a82b8f2fdf6f365cb38c8792ec67f420cd762db4, but increments the version number since we should only go up. BUG= 652907 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2405533002 Cr-Commit-Position: refs/heads/master@{#423995} [modify] https://crrev.com/84c632df136adb79c1282df0509daff8747e088c/chrome/browser/resources/safe_browsing/download_file_types.asciipb
,
Oct 13 2016
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07e489926caff61e1c7f60df7a93ee29e2d13fd4 commit 07e489926caff61e1c7f60df7a93ee29e2d13fd4 Author: nparker <nparker@chromium.org> Date: Tue Oct 25 21:24:57 2016 Re-mark APKs as dangerous on Android We can do this now that http://crbug.com/653961 is fixed. Revert "Revert "Mark APK downloads as dangerous on Android"" This reverts commit 84c632df136adb79c1282df0509daff8747e088c. BUG= 652907 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2445893002 Cr-Commit-Position: refs/heads/master@{#427479} [modify] https://crrev.com/07e489926caff61e1c7f60df7a93ee29e2d13fd4/chrome/browser/resources/safe_browsing/download_file_types.asciipb
,
Oct 27 2016
This works on Canary. I've just pushed a new component update via push_file_type_proto.py.
,
Nov 1 2016
Hello! How long will it take to get this fix to stable version? I am still getting no warning at 54.0.2840.68. We are going to publish the blogpost about usage of this bug in the end of this week.
,
Nov 1 2016
asanka & qinmin -- Can you comment on when the download-manager-in-chrome experiment will roll out to stable? The component update has already hit >99% of users.
,
Nov 1 2016
it will be 100% for M55, M54 is running at 50% now
,
Nov 1 2016
This is definitely good news, guys! Ok, then we will release the blogpost approximately on Tuesday. Thank you for your help! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 5 2016