New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652898 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Font fallback not working when run with --no-sandbox option

Reported by kevinsaw...@gmail.com, Oct 4 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36

Steps to reproduce the problem:
1. Download https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/text/font-fallback-win.html to a local file 
2. Launch Chrome with --no-sandbox option
3. Open downloaded font-fallback-win.html in Chrome window

What is the expected behavior?
All Characters render

What went wrong?
Some characters show as box character

Did this work before? No 

Chrome version: 53.0.2785.116  Channel: stable
OS Version: 10
Flash Version: Shockwave Flash 23.0 r0
 
Screen Shot 2016-10-04 at 3.57.32 PM.png
17.1 KB View Download
Components: UI>OSIntegration
Owner: kulshin@chromium.org
Status: Assigned (was: Unconfirmed)
https://jsfiddle.net/3cnmnq4w/

This is likely due to the right font fallback interfaces not being propagated to Blink/Skia when the font proxy initialization is skipped. While that could be fixed by getting the interfaces directly from DWrite, there's also no reason to not use the proxy when not using the sandbox, so we should just do that.

Also, note that running with the --no-sandbox flag is not secure and should be avoided whenever possible.

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ae5d7f0001e8c138f2468450e3091216e0c35c3

commit 8ae5d7f0001e8c138f2468450e3091216e0c35c3
Author: kulshin <kulshin@chromium.org>
Date: Thu Oct 06 18:35:32 2016

Initialize the font proxy even when not using the sandbox

Now that we removed the font cache, there is no reason for
the font proxy to be tied to sandbox initialization.

BUG= 652898 

Review-Url: https://codereview.chromium.org/2387373003
Cr-Commit-Position: refs/heads/master@{#423599}

[modify] https://crrev.com/8ae5d7f0001e8c138f2468450e3091216e0c35c3/content/renderer/renderer_main_platform_delegate_win.cc

Status: Fixed (was: Assigned)

Comment 5 by ajha@chromium.org, Oct 10 2016

Labels: TE-Verified-55.0.2883.6 TE-Verified-M55
Verified the fix on the latest M-55(55.0.2883.6) on Windows-10 by launching the chrome with --no-sandbox and opening the jsfiddle from C#2. This is working as intended.


652898.png
112 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ae5d7f0001e8c138f2468450e3091216e0c35c3

commit 8ae5d7f0001e8c138f2468450e3091216e0c35c3
Author: kulshin <kulshin@chromium.org>
Date: Thu Oct 06 18:35:32 2016

Initialize the font proxy even when not using the sandbox

Now that we removed the font cache, there is no reason for
the font proxy to be tied to sandbox initialization.

BUG= 652898 

Review-Url: https://codereview.chromium.org/2387373003
Cr-Commit-Position: refs/heads/master@{#423599}

[modify] https://crrev.com/8ae5d7f0001e8c138f2468450e3091216e0c35c3/content/renderer/renderer_main_platform_delegate_win.cc

Comment 7 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Components: -UI>OSIntegration Internals>PlatformIntegration

Sign in to add a comment