New issue
Advanced search Search tips

Issue 652896 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

content_browsertests failing on chromium.android/Lollipop Phone Tester

Project Member Reported by sgu...@chromium.org, Oct 4 2016

Issue description

content_browsertests failing on chromium.android/Lollipop Phone Tester

Type: build-failure

Builders failed on: 
- Lollipop Phone Tester: 
  https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester

failures:
BrowserMediaSessionManagerBrowserTest.TestNullMetadata
SRC_ClearKey/EncryptedMediaTest.Playback_VideoAudio_WebM_Opus/0
SRC_ClearKey/EncryptedMediaTest.Playback_VideoClearAudio_WebM_Opus/0
MSE_ClearKey/EncryptedMediaTest.Playback_VideoClearAudio_WebM_Opus/0
MSE_ClearKey/EncryptedMediaTest.Playback_AudioOnly_WebM_Opus/0
CaptureScreenshotTest.CaptureScreenshot
MSE_ClearKey/EncryptedMediaTest.Playback_VideoAudio_WebM_Opus/0
SRC_ClearKey/EncryptedMediaTest.Playback_AudioOnly_WebM_Opus/0
 

also failing in Lollipop Low-end Tester and Marshmallow Tablet Tester


 
Cc: dalecur...@chromium.org
Owner: jrumm...@chromium.org
The failure seems to have started in build 4102
https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/4102

Some CLs that I think may be related are:
 https://codereview.chromium.org/2382023005 https://codereview.chromium.org/2349813002

assigning to jrummel

can you please take a look? can this be related to your CL.

No idea about the non-EncryptedMediaTests (BrowserMediaSessionManagerBrowserTest.TestNullMetadata, CaptureScreenshotTest.CaptureScreenshot).

However, the EncryptedMedia tests (just the WebM_Opus ones) are failing with:
"FAIL: NotSupportedError None of the requested configurations were supported."

Investigating.
The tests all have:
    #if defined(OS_ANDROID)
      if (!media::PlatformHasOpusSupport())
        return;
    #endif

PlatformHasOpusSupport() is defined as android_sdk_int() >= 21. Wonder if that is not true.

(My change simply provided the audio/video capabilities to RequestMediaKeySystemAccess(), rather than just [] which is no longer allowed in the EME spec.)
Labels: Pri-1
Status: Assigned (was: Available)
The six EncryptedMediaTests listed in the original bug report have been failing consistently since the changes in comment #1 landed. Bumping this up to P1.

I suspect that the failures are due to 
"EME: Update MediaKeySystemConfiguration defaults; check capabilities" https://chromium.googlesource.com/chromium/src/+/2737b99610b13c7fcaad6ec3041cce4b538b372f
Status: Started (was: Assigned)
Found the problem. Old code in key_systems.cc was removing OPUS and VP9 from the list of supported codecs (on Android only). Will fix.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b3840dcaad1e52f50053230327259eeb26eba89

commit 7b3840dcaad1e52f50053230327259eeb26eba89
Author: jrummell <jrummell@chromium.org>
Date: Thu Oct 06 04:15:46 2016

Enable OPUS and VP9 codecs on Android for Clear Key key system

Code in MimeUtil::IsCodecSupportedOnPlatform() now does the correct
check to determine if OPUS or VP9 is supported on the platform, so
the old code that disabled those codecs on Android is no longer needed.

BUG= 652896 

Review-Url: https://codereview.chromium.org/2394873004
Cr-Commit-Position: refs/heads/master@{#423428}

[modify] https://crrev.com/7b3840dcaad1e52f50053230327259eeb26eba89/media/base/key_systems.cc

Status: Fixed (was: Started)
The bot is passing content_browsertests now. Thank you!
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b3840dcaad1e52f50053230327259eeb26eba89

commit 7b3840dcaad1e52f50053230327259eeb26eba89
Author: jrummell <jrummell@chromium.org>
Date: Thu Oct 06 04:15:46 2016

Enable OPUS and VP9 codecs on Android for Clear Key key system

Code in MimeUtil::IsCodecSupportedOnPlatform() now does the correct
check to determine if OPUS or VP9 is supported on the platform, so
the old code that disabled those codecs on Android is no longer needed.

BUG= 652896 

Review-Url: https://codereview.chromium.org/2394873004
Cr-Commit-Position: refs/heads/master@{#423428}

[modify] https://crrev.com/7b3840dcaad1e52f50053230327259eeb26eba89/media/base/key_systems.cc

Comment 9 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment