Some Media related tests are broken on low end devices |
||||||
Issue descriptionThese tests below are broken lollipop low end tester https://uberchromegw.corp.google.com/i/chromium.android/waterfall?show=Lollipop%20Low-end%20Tester org.chromium.chrome.browser.media.remote.CastNotificationTest#testNotificationPause ( Code Search ) org.chromium.chrome.browser.media.remote.CastPositionTransferTest#testLocalToRemotePositionTransfer ( Code Search ) org.chromium.chrome.browser.media.remote.CastPositionTransferTest#testRemoteToLocalPositionTransfer ( Code Search ) org.chromium.chrome.browser.media.remote.CastStartStopTest#testCastingGenericVideo ( Code Search ) org.chromium.chrome.browser.media.remote.CastStartStopTest#testStopFromNotification ( Code Search ) org.chromium.chrome.browser.media.remote.CastStartStopTest#testStopFromVideoControls ( Code Search ) org.chromium.chrome.browser.media.remote.CastVideoControlsTest#testPauseButton ( Code Search ) org.chromium.chrome.browser.video.VideoTest#testLoadMediaUrl ( Code Search ) In a similar kind of failure, Toby tracked the failure reason to https://codereview.chromium.org/2344353003 which disables autoplay on low-end devices and fixed it by adding a play button to start. see crbug/652389 for the other broken tests and fixed in android_webview.
,
Oct 4 2016
foolip: Dale is OOO. Can you help forward this crbug to the right person to fix the tests. Let's not leave them broken till then.
,
Oct 5 2016
Can we just revert that patch?
,
Oct 5 2016
I'm looking into fixing the Cast tests. +Dan and David to take a look at the EME tests that I think are failing for the same reason: https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Low-end%20Tester/builds/4118/steps/content_browsertests/logs/stdio
,
Oct 5 2016
What device is this? Is it possible its hardware decoders are blacklisted?
,
Oct 5 2016
Just FWIW, on low end devices the GPU process is in in-process mode (running as a thread in the browser process). Not sure whether this could be related. See a previous low-end bug (issue 609905) for the context.
,
Oct 5 2016
Just in case it's related, you can use --in-process-gpu for testing/repro.
,
Oct 5 2016
It's an Android 1 with LMY47W. Do these tests rely on the default preload to load the media? If not, perhaps, we should split it into another bug.
,
Oct 5 2016
Have https://codereview.chromium.org/2400543002 out for the Cast tests.
,
Oct 5 2016
Based on the logs, it seems the EME failures are in requestMediaKeySystemAccess(), and has no reliance on load(). The tests do expect play() to work without interaction, but we are using --disable-gesture-requirement-for-media-playback to avoid that. Seems like a different bug.
,
Oct 6 2016
The EME failures are being tracked in issue 652896 . As sandersd@ noted, they are failures in requestMediaKeySystemAccess().
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e5b06e0201d483a1596aedf438fb931fbbe7b42 commit 6e5b06e0201d483a1596aedf438fb931fbbe7b42 Author: avayvod <avayvod@chromium.org> Date: Fri Oct 07 01:33:42 2016 [Cast, Tests] Handle low end and JB devices that don't preload videos BUG= 652872 , 652389 TEST=run_chrome_public_test_apk --verbose --gtest_filter=org.chromium.chrome.browser.media.remote.* on both low end and not a low end device. Since https://codereview.chromium.org/2344353003 on low-end and JB devices videos are not preloaded so we have to trigger that in a button onclick handler. Review-Url: https://codereview.chromium.org/2400543002 Cr-Commit-Position: refs/heads/master@{#423775} [modify] https://crrev.com/6e5b06e0201d483a1596aedf438fb931fbbe7b42/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastSwitchVideoTest.java [modify] https://crrev.com/6e5b06e0201d483a1596aedf438fb931fbbe7b42/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java [modify] https://crrev.com/6e5b06e0201d483a1596aedf438fb931fbbe7b42/chrome/test/data/android/media/simple_video.html [modify] https://crrev.com/6e5b06e0201d483a1596aedf438fb931fbbe7b42/chrome/test/data/android/media/simple_video2.html [modify] https://crrev.com/6e5b06e0201d483a1596aedf438fb931fbbe7b42/chrome/test/data/android/media/two_videos.html
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/680764f10bc0dc6f8aa7bfaef566b685983599cd commit 680764f10bc0dc6f8aa7bfaef566b685983599cd Author: rockot <rockot@chromium.org> Date: Fri Oct 07 05:22:30 2016 Revert of [Cast, Tests] Handle low end and JB devices that don't preload videos (patchset #1 id:1 of https://codereview.chromium.org/2400543002/ ) Reason for revert: Speculative revert because cast tests started flaking very heavily at this revision and it's effectively blocking things in the CQ. See https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng?numbuilds=200 for example failures Original issue's description: > [Cast, Tests] Handle low end and JB devices that don't preload videos > > BUG= 652872 , 652389 > TEST=run_chrome_public_test_apk --verbose --gtest_filter=org.chromium.chrome.browser.media.remote.* on both low end and not a low end device. > > Since https://codereview.chromium.org/2344353003 on low-end and JB devices videos > are not preloaded so we have to trigger that in a button onclick handler. > > Committed: https://crrev.com/6e5b06e0201d483a1596aedf438fb931fbbe7b42 > Cr-Commit-Position: refs/heads/master@{#423775} TBR=mlamouri@chromium.org,avayvod@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 652872 , 652389 Review-Url: https://codereview.chromium.org/2394273003 Cr-Commit-Position: refs/heads/master@{#423799} [modify] https://crrev.com/680764f10bc0dc6f8aa7bfaef566b685983599cd/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastSwitchVideoTest.java [modify] https://crrev.com/680764f10bc0dc6f8aa7bfaef566b685983599cd/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java [modify] https://crrev.com/680764f10bc0dc6f8aa7bfaef566b685983599cd/chrome/test/data/android/media/simple_video.html [modify] https://crrev.com/680764f10bc0dc6f8aa7bfaef566b685983599cd/chrome/test/data/android/media/simple_video2.html [modify] https://crrev.com/680764f10bc0dc6f8aa7bfaef566b685983599cd/chrome/test/data/android/media/two_videos.html
,
Oct 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9928e0a0cadbb5e824dfa616e5a1870484ec16b commit a9928e0a0cadbb5e824dfa616e5a1870484ec16b Author: avayvod <avayvod@chromium.org> Date: Fri Oct 07 19:13:04 2016 [Cast, Tests, Android] Disable failing Cast tests for low-end devices BUG= 652872 ,653623 TEST=Run the tests locally, verified they're passing. Follow-up on my sheriff duty as the straightforward fix (https://codereview.chromium.org/2400543002) made the tests much flakier. Review-Url: https://codereview.chromium.org/2400283002 Cr-Commit-Position: refs/heads/master@{#423923} [modify] https://crrev.com/a9928e0a0cadbb5e824dfa616e5a1870484ec16b/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastNotificationTest.java [modify] https://crrev.com/a9928e0a0cadbb5e824dfa616e5a1870484ec16b/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastPositionTransferTest.java [modify] https://crrev.com/a9928e0a0cadbb5e824dfa616e5a1870484ec16b/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastStartStopTest.java [modify] https://crrev.com/a9928e0a0cadbb5e824dfa616e5a1870484ec16b/chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastVideoControlsTest.java
,
Apr 28 2017
avayvod@, is there anything else to do here? Should we close? or maybe re-assess priority?
,
Oct 18 2017
Assigning all my bugs to Mounir for him to triage and close/reassign later.
,
Oct 24 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sgu...@chromium.org
, Oct 4 2016