Crash when running WorkspaceLayoutManagers that create backdrop |
||||||||
Issue descriptionHere's the output: sky@sky-linux:/secondary/builds/build1/src$ ./out/Debug2/mash_unittests --gtest_filter=WorkspaceLayoutManagerBackdropTest.BackdropCrashTest IMPORTANT DEBUGGING NOTE: batches of tests are run inside their own process. For debugging a test inside a debugger, use the --gtest_filter=<your_test_name> flag along with --single-process-tests. Using sharding settings from environment. This is shard 0/1 Using 1 parallel jobs. Note: Google Test filter = WorkspaceLayoutManagerBackdropTest.BackdropCrashTest [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from WorkspaceLayoutManagerBackdropTest [ RUN ] WorkspaceLayoutManagerBackdropTest.BackdropCrashTest [21655:21655:1004/151502:2439758897164:ERROR:wm_shell_mus.cc(325)] Not implemented reached in virtual void ash::mus::WmShellMus::RecordUserMetricsAction(ash::UserM\ etricsAction) [21655:21655:1004/151502:2439758902086:ERROR:shell_delegate_mus.cc(207)] Not implemented reached in virtual ash::MediaDelegate *ash::ShellDelegateMus::CreateMediaD\ elegate() [21655:21655:1004/151502:2439758902125:ERROR:shell_delegate_mus.cc(213)] Not implemented reached in virtual std::unique_ptr<PaletteDelegate> ash::ShellDelegateMus:\ :CreatePaletteDelegate() [21655:21655:1004/151502:2439758902211:ERROR:wm_shell_mus.cc(400)] Not implemented reached in virtual void ash::mus::WmShellMus::AddDisplayObserver(ash::WmDisplayO\ bserver *) [21655:21655:1004/151502:2439758902550:ERROR:wm_shell_mus.cc(211)] Not implemented reached in virtual ash::WmWindow *ash::mus::WmShellMus::NewWindow(ui::wm::Window\ Type, ui::LayerType) [21655:21655:1004/151502:2439758902653:ERROR:wm_window_mus.cc(985)] Not implemented reached in virtual void ash::mus::WmWindowMus::OnWindowSharedPropertyChanged(ui\ ::Window *, const std::string &, const std::vector<uint8_t> *, const std::vector<uint8_t> *) [21655:21655:1004/151502:2439758902877:ERROR:wm_window_mus.cc(579)] Not implemented reached in virtual void ash::mus::WmWindowMus::SetChildWindowVisibilityChangesA\ nimated() [21655:21655:1004/151502:2439758903138:ERROR:wm_window_mus.cc(584)] Not implemented reached in virtual void ash::mus::WmWindowMus::SetMasksToBounds(bool) [21655:21655:1004/151502:2439758909036:ERROR:wm_window_mus.cc(563)] Not implemented reached in virtual void ash::mus::WmWindowMus::SetVisibilityAnimationTransition\ (::wm::WindowVisibilityAnimationTransition) [21655:21655:1004/151502:2439758911441:ERROR:screen_base.cc(59)] Not implemented reached in virtual display::Display display::ScreenBase::GetDisplayNearestWindow(g\ fx::NativeView) const [21655:21655:1004/151502:2439758912325:ERROR:native_widget_mus.cc(824)] Not implemented reached in virtual void views::NativeWidgetMus::ReorderNativeViews() [21655:21655:1004/151502:2439758912495:ERROR:native_widget_mus.cc(1300)] Not implemented reached in virtual void views::NativeWidgetMus::OnRootViewLayout() [21655:21655:1004/151502:2439758912585:ERROR:native_widget_mus.cc(828)] Not implemented reached in virtual void views::NativeWidgetMus::ViewRemoved(views::View *) [21655:21655:1004/151502:2439758981650:ERROR:shell_delegate_mus.cc(101)] Not implemented reached in virtual ash::MediaCaptureState ash::(anonymous namespace)::Medi\ aDelegateStub::GetMediaCaptureState(UserIndex) [21655:21655:1004/151502:2439758994712:ERROR:native_widget_mus.cc(888)] Not implemented reached in virtual void views::NativeWidgetMus::GetWindowPlacement(gfx::Rec\ t *, ui::WindowShowState *) const [21655:21655:1004/151502:2439758996929:ERROR:native_widget_mus.cc(1228)] Not implemented reached in virtual bool views::NativeWidgetMus::IsMouseEventsEnabled() con\ st [21655:21655:1004/151502:2439758996967:ERROR:screen_base.cc(39)] Not implemented reached in virtual gfx::Point display::ScreenBase::GetCursorScreenPoint() [21655:21655:1004/151502:2439758998143:ERROR:wm_shell_mus.cc(257)] Not implemented reached in virtual bool ash::mus::WmShellMus::IsInUnifiedMode() const [21655:21655:1004/151502:2439758998677:ERROR:root_window_controller.cc(152)] Not implemented reached in void ash::mus::RootWindowController::SetWorkAreaInests(cons\ t gfx::Insets &) [21655:21655:1004/151502:2439759004423:ERROR:wm_shell_mus.cc(282)] Not implemented reached in virtual bool ash::mus::WmShellMus::IsPinned() [21655:21655:1004/151502:2439759004503:ERROR:wm_window_mus.cc(261)] Not implemented reached in virtual ui::Layer *ash::mus::WmWindowMus::GetLayer() [21655:21655:1004/151502:2439759004640:ERROR:wm_window_mus.cc(332)] Not implemented reached in virtual bool ash::mus::WmWindowMus::GetTargetVisibility() const [21655:21657:1004/151502:2439759061750:ERROR:gl_surface_osmesa_x11.cc(85)] XGetWindowAttributes failed for window 1. [21655:21657:1004/151502:2439759061856:ERROR:in_process_command_buffer.cc(351)] Could not create GLSurface. [21655:21655:1004/151502:2439759062132:ERROR:gl_in_process_context.cc(125)] Failed to initialize InProcessCommmandBuffer [21655:21657:1004/151502:2439759066343:WARNING:x11_util.cc(1404)] X error received: serial 41, error_code 3 (BadWindow (invalid Window parameter)), request_code 3,\ minor_code 0 (X_GetWindowAttributes) [21655:21655:1004/151502:2439759066765:FATAL:compositor.cc(485)] Check failed: false. #0 0x7fc7e23f629e base::debug::StackTrace::StackTrace() #1 0x7fc7e245cc8c logging::LogMessage::~LogMessage() #2 0x7fc7dede233b ui::Compositor::DidFailToInitializeCompositorFrameSink() #3 0x7fc7df954e7f cc::LayerTreeHostInProcess::DidFailToInitializeCompositorFrameSink() #4 0x7fc7df9e1f7f cc::SingleThreadProxy::SetCompositorFrameSink() #5 0x7fc7df95488c cc::LayerTreeHostInProcess::SetCompositorFrameSink() #6 0x7fc7dede0f95 ui::Compositor::SetCompositorFrameSink() #7 0x00000089139c ui::InProcessContextFactory::CreateCompositorFrameSink() #8 0x7fc7dede22a9 ui::Compositor::RequestNewCompositorFrameSink() #9 0x7fc7df954bea cc::LayerTreeHostInProcess::RequestNewCompositorFrameSink() #10 0x7fc7df9e1c33 cc::SingleThreadProxy::RequestNewCompositorFrameSink() #11 0x7fc7df6be1be _ZN4base8internal13FunctorTraitsIMN2cc28ScrollbarAnimationControllerEFvvEvE6InvokeIRKNS_7WeakPtrIS3_EEJEEEvS5_OT_DpOT0_ #12 0x7fc7df9e7faa _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN2cc17SingleThreadProxyEFvvERKNS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_ #13 0x7fc7df9e7f32 _ZN4base8internal7InvokerINS0_9BindStateIMN2cc17SingleThreadProxyEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEvOT_OT0_N\ S_13IndexSequenceIJXspT1_EEEE #14 0x7fc7df9e7e7c _ZN4base8internal7InvokerINS0_9BindStateIMN2cc17SingleThreadProxyEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #15 0x7fc7df6be4eb base::internal::RunMixin<>::Run() #16 0x7fc7df6bdf29 base::CancelableCallback<>::Forward() #17 0x7fc7df6be1be _ZN4base8internal13FunctorTraitsIMN2cc28ScrollbarAnimationControllerEFvvEvE6InvokeIRKNS_7WeakPtrIS3_EEJEEEvS5_OT_DpOT0_ #18 0x7fc7df6be11a _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMNS_18CancelableCallbackIFvvEEEKFvvERKNS_7WeakPtrIS6_EEJEEEvOT_OT0_DpOT1_ #19 0x7fc7df6be0a2 _ZN4base8internal7InvokerINS0_9BindStateIMNS_18CancelableCallbackIFvvEEEKFvvEJNS_7WeakPtrIS5_EEEEES4_E7RunImplIRKS7_RKSt5tupleIJS9_EEJLm0EEEEvOT\ _OT0_NS_13IndexSequenceIJXspT1_EEEE #20 0x7fc7df6bdfec _ZN4base8internal7InvokerINS0_9BindStateIMNS_18CancelableCallbackIFvvEEEKFvvEJNS_7WeakPtrIS5_EEEEES4_E3RunEPNS0_13BindStateBaseE #21 0x7fc7e23c90db base::internal::RunMixin<>::Run() #22 0x7fc7e23fb2e1 base::debug::TaskAnnotator::RunTask() #23 0x7fc7e2482834 base::MessageLoop::RunTask() #24 0x7fc7e2482a64 base::MessageLoop::DeferOrRunPendingTask() #25 0x7fc7e2482d2e base::MessageLoop::DoWork() #26 0x7fc7e2497996 base::MessagePumpGlib::Run() #27 0x7fc7e2482431 base::MessageLoop::RunHandler() #28 0x7fc7e251bf34 base::RunLoop::Run() #29 0x7fc7e251c169 base::RunLoop::RunUntilIdle() #30 0x0000004a5140 ash::(anonymous namespace)::WorkspaceLayoutManagerBackdropTest::ShowTopWindowBackdrop() #31 0x0000004a508a ash::WorkspaceLayoutManagerBackdropTest_BackdropCrashTest_Test::TestBody() #32 0x0000008dc45a testing::internal::HandleSehExceptionsInMethodIfSupported<>() #33 0x0000008cb31e testing::internal::HandleExceptionsInMethodIfSupported<>() #34 0x0000008c0055 testing::Test::Run() #35 0x0000008c0778 testing::TestInfo::Run() #36 0x0000008c0d1a testing::TestCase::Run() #37 0x0000008c606c testing::internal::UnitTestImpl::RunAllTests() #38 0x0000008e110a testing::internal::HandleSehExceptionsInMethodIfSupported<>() #39 0x0000008cce2e testing::internal::HandleExceptionsInMethodIfSupported<>() #40 0x0000008c5d0f testing::UnitTest::Run() #41 0x000000866de1 RUN_ALL_TESTS() #42 0x000000865d82 base::TestSuite::Run() #43 0x00000045e5c9 _ZN4base8internal13FunctorTraitsIMNS_9TestSuiteEFivEvE6InvokeIPN4mash4test13MashTestSuiteEJEEEiS4_OT_DpOT0_ #44 0x00000045e4f1 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMNS_9TestSuiteEFivEJPN4mash4test13MashTestSuiteEEEEiOT_DpOT0_ #45 0x00000045e497 _ZN4base8internal7InvokerINS0_9BindStateIMNS_9TestSuiteEFivEJNS0_17UnretainedWrapperIN4mash4test13MashTestSuiteEEEEEEFivEE7RunImplIRKS5_RKSt5tup\ leIJSA_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE #46 0x00000045e3ac _ZN4base8internal7InvokerINS0_9BindStateIMNS_9TestSuiteEFivEJNS0_17UnretainedWrapperIN4mash4test13MashTestSuiteEEEEEEFivEE3RunEPNS0_13BindStateB\ aseE #47 0x0000004835bb base::internal::RunMixin<>::Run() #48 0x000000868af1 base::(anonymous namespace)::LaunchUnitTestsInternal() #49 0x000000868984 base::LaunchUnitTests() #50 0x00000045e167 MasterProcessMain() #51 0x0000004b05c4 main #52 0x7fc7db854f45 __libc_start_main #53 0x00000045d915 <unknown> [1004/151502:ERROR:kill_posix.cc(84)] Unable to terminate process group 21655: No such process I'm in the process of porting the tests, so for the time being you can't actually run this test in mash. Will update once I land the supporting code.
,
Oct 11 2016
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2df26e737f98f72f03dfe4ac1fe1ea91545bab2 commit c2df26e737f98f72f03dfe4ac1fe1ea91545bab2 Author: sadrul <sadrul@chromium.org> Date: Tue Oct 11 19:45:52 2016 mash: Use null AcceleratedWidget for widgets in tests When running in tests, the ui::ContextFactory creates test contexts that do not support real GL operations. Some of the code (e.g. InProcessContextProvider) expects a null widget for ui::Compositor::widget() in this situation. So update WindowTreeHostMus to follow this. Also, re-enable the tests, and make sure the test context factory are destroyed correctly during test tear-down. BUG= 652871 Review-Url: https://codereview.chromium.org/2409053002 Cr-Commit-Position: refs/heads/master@{#424515} [modify] https://crrev.com/c2df26e737f98f72f03dfe4ac1fe1ea91545bab2/ash/common/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/c2df26e737f98f72f03dfe4ac1fe1ea91545bab2/mash/test/mash_test_suite.cc [modify] https://crrev.com/c2df26e737f98f72f03dfe4ac1fe1ea91545bab2/ui/views/mus/window_tree_host_mus.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8335eeddd6a5bc06515eb7c577a9196112f4583c commit 8335eeddd6a5bc06515eb7c577a9196112f4583c Author: sky <sky@chromium.org> Date: Thu Oct 06 23:25:09 2016 Converts most of WorkspaceLayoutManager tests to use common code A couple triggers crashes, which I've filed separately. The keyboard ones won't work in mash. I plan to move those out of this file separately. BUG= 624172 , 652871 TEST=covered by tests R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2391153002 Cr-Commit-Position: refs/heads/master@{#423732} [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/BUILD.gn [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/aura/wm_window_aura.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/aura/wm_window_aura.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/common/test/ash_test.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/common/test/ash_test.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/common/test/ash_test_impl.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/common/wm/default_state.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/common/wm/fullscreen_window_finder.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/common/wm_window.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/mus/bridge/wm_window_mus.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/mus/bridge/wm_window_mus.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/mus/test/ash_test_impl_mus.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/mus/test/ash_test_impl_mus.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/mus/test/wm_test_base.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/system/chromeos/power/power_event_observer_unittest.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/test/ash_test_base.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/test/ash_test_base.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/test/ash_test_impl_aura.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/test/ash_test_impl_aura.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/test/test_session_state_delegate.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/test/test_session_state_delegate.h [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/wm/lock_state_controller_unittest.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/8335eeddd6a5bc06515eb7c577a9196112f4583c/ui/aura/window.h
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Mar 7 2017
This crash no longer happens, so closing.
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 6 2016