Close EME sessions on CDM crash |
||
Issue descriptionThe EME specification specifies that a session may be closed at any time, including "when system resources are lost" [1]. If the CDM crashes Chrome should close any existing MediaKeySession objects, to indicate that they are no longer available. [1] http://w3c.github.io/encrypted-media/#session-closed
,
Nov 16 2016
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f3429ba51d768e7461bb702afb74b234efb7337 commit 1f3429ba51d768e7461bb702afb74b234efb7337 Author: xhwang <xhwang@chromium.org> Date: Wed Dec 07 04:16:01 2016 media: Avoid access violation in MojoCdm after connection error Upon connection error during CDM initialization, after we rejected and dropped the promise, MojoCdm could be destructed. We should not try to close pending sessions in this case, and in fact we shouldn't have any sessions open before the CDM is successfully initialized. Added a unittest to cover the case where CDM creation failed due to connection error. BUG= 652856 , 657069 TEST=Manually tested. Also added a new unittest. Review-Url: https://codereview.chromium.org/2551333002 Cr-Commit-Position: refs/heads/master@{#436857} [modify] https://crrev.com/1f3429ba51d768e7461bb702afb74b234efb7337/media/base/cdm_session_tracker.cc [modify] https://crrev.com/1f3429ba51d768e7461bb702afb74b234efb7337/media/base/cdm_session_tracker.h [modify] https://crrev.com/1f3429ba51d768e7461bb702afb74b234efb7337/media/mojo/BUILD.gn [modify] https://crrev.com/1f3429ba51d768e7461bb702afb74b234efb7337/media/mojo/clients/mojo_cdm.cc [modify] https://crrev.com/1f3429ba51d768e7461bb702afb74b234efb7337/media/mojo/clients/mojo_cdm.h [add] https://crrev.com/1f3429ba51d768e7461bb702afb74b234efb7337/media/mojo/clients/mojo_cdm_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Nov 16 2016