New issue
Advanced search Search tips

Issue 652847 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: 2019-01-08
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Delete or Re-enable More Aggressive Custom Search Engine Experimental Code

Project Member Reported by mpear...@chromium.org, Oct 4 2016

Issue description


In https://codereview.chromium.org/1411543011 ("Omnibox: Make Keyword Provide More Generous with Matching"), I added experimental code to make the omnibox more aggressive at providing suggestions from keywords even if the user didn't type the full keyword.  E.g., the input "amazon test" will rank the suggestion for "search amazon.com for test" more strongly than before, strongly enough to likely be displayed.

The experiment evaluating this on desktop was murky.  See bug 566608 for details.  It might be a tiny win but there were effects I don't understand and, given that, it's not worth launching.

However, as Android (and iOS) do not have the tab-to-search feature, allowing keyword suggestions to appear more prominently might be the only way users end up seeing them.  Thus, this experimental code might prove much more valuable on that platform.

I am leaving the experiment code in the code base in hopes that these platforms will make all the UI and other changes to enable keyword suggestions (tracking bug 488898), and then we turn up the ranking knobs easily.

If those platforms end up not enabling the keyword provider, we should remove the code.  (I imagine though that if this is more than a year from the date of filing this bug, we could simply try re-evaluating this change on desktop before doing so.  Maybe the effect will be different?)

 
Components: UI>Browser>Omnibox>TabToSearch
Labels: Hotlist-CodeHealth
NextAction: 2018-01-09
Labels: Hotlist-OmniboxRanking
The NextAction date has arrived: 2018-01-09
NextAction: 2019-01-08
This year we're going to revisit / rethink what we want to do with keyword searches.  Let's not disable this code yet.  Punting this bug for next year.
Owner: ----
Status: Available (was: Assigned)
No need for this bug to be assigned to me at the moment, given that we're punting it to next year.
The NextAction date has arrived: 2019-01-08

Sign in to add a comment