Rename FileEntry to FileSystemEntry (and friends), drop [NoInterfaceObject] |
|||||
Issue descriptionPer previous discussion [1] [2] [1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_6Euwqv366U [2] https://github.com/WICG/entries-api/issues/6 ... the desire is to (a) rename the types and (b) and drop [NoInterfaceObject] so the types can be referenced by name: [1] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_6Euwqv366U [2] https://github.com/WICG/entries-api/issues/6 DOMFileSystem → FileSystem Entry → FileSystemEntry FileEntry → FileSystemFileEntry DirectoryEntry → FileSystemDirectoryEntry DirectoryReader → FileSystemDirectoryReader https://wicg.github.io/entries-api - Spec has been updated. Moz plans to ship in FF51. Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/xTfeHGlcIQg/X0Q4iDJHAgAJ
,
Apr 4 2017
,
Jan 6 2018
,
Jan 6 2018
,
Sep 20
I'd like take this issue if nobody is working on it.
,
Sep 20
When I tried I ran into issues with test code (internal to chrome and also via the closure library) that asserted the interface names (via `Object.prototype.toString.call()`) and gave up. Be warned that the IDL change itself is straightforward, but renaming the classes transitively across the code base is a long slog. (That's the reason this is not marked Hotlist-GoodFirstBug)
,
Sep 20
Previous efforts: * A pure rename: https://codereview.chromium.org/2297043002/ - if split up to do this interface-by-interface this might be possible. * A variation where I duplicated the interfaces where used for drag/drop, but left the use for the filesystem API alone: https://chromium-review.googlesource.com/c/chromium/src/+/583774
,
Sep 27
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jsb...@chromium.org
, Oct 4 2016