New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652803 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Change "Manage other people" indicator

Project Member Reported by bettes@chromium.org, Oct 4 2016

Issue description

Change the indicator from an "open-in-new" to an arrow for "Manage other people." The user manager isn't an outside web property so we should address it as more of a dialog like CBD. 
 
Since Manage other people opens another window, it seems like a larger jump than Theme settings or Advanced font settings that only open a new tab in the same window. Clear browser data opens a dialog rather than a new window. It seems like Manage other people is opening UI in a new space (i.e. open-in-new). I'm not sure what is meant by "an outside web property". Can you help me see what I'm missing (when to use open-in-new and when not to?

P.S. The actual icon change is trivial. So it's no problem to change the icon, I'm just trying to understand when to use each icon.
Owner: bettes@chromium.org
Cc: -dbeam@chromium.org
Owner: dbeam@chromium.org
I view the user manager as a chrome internal property that is drawn by Chrome, similar to a dialog like CBD. From that definition, the SU dashboard, my activity dashboard, and the chrome web store are slightly a different class of UI. 

That's my rationale at least. :) 


Owner: dschuyler@chromium.org
Wrong owner!
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0621a8672ffe73a70dae79c26f95e84db4c5c08c

commit 0621a8672ffe73a70dae79c26f95e84db4c5c08c
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Oct 06 18:51:20 2016

[MD settings] right arrow for manage other people setting row

Alan requested that the settings row for Manage other people have the
right arrow icon.

BUG= 652803 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2392283004
Cr-Commit-Position: refs/heads/master@{#423608}

[modify] https://crrev.com/0621a8672ffe73a70dae79c26f95e84db4c5c08c/chrome/browser/resources/settings/people_page/people_page.html

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0621a8672ffe73a70dae79c26f95e84db4c5c08c

commit 0621a8672ffe73a70dae79c26f95e84db4c5c08c
Author: dschuyler <dschuyler@chromium.org>
Date: Thu Oct 06 18:51:20 2016

[MD settings] right arrow for manage other people setting row

Alan requested that the settings row for Manage other people have the
right arrow icon.

BUG= 652803 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2392283004
Cr-Commit-Position: refs/heads/master@{#423608}

[modify] https://crrev.com/0621a8672ffe73a70dae79c26f95e84db4c5c08c/chrome/browser/resources/settings/people_page/people_page.html

Comment 9 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment