[Big]: macro-blocking appear on video screen while watching video |
|||||||||||||||||
Issue descriptiongoogle Chrome 55.0.2878.0 (Official Build) dev Platform 8861.0.0 (Official Build) dev-channel JavaScript V8 5.5.335.1 Flash 23.0.0.185 -r1 What steps will reproduce the problem? 1. Play live video on go.cnn.com or ustream.tv 2. Observed issue, macro-blocking appear on video screen during playback What is the expected output? There is no macro-blocking on video What do you see instead? macro-blocking appear on video screen during playback Feedback: Report ID: 12739495491 *******Note********* 1. issue only see on big device 2. issue no reproduce if disable HW decode 3. issue no see on youtube live
,
Oct 18 2016
Just to be clear, this is only on big, not on blaze? If this is only on big, we may have a freon regression on our hands.
,
Oct 18 2016
,
Oct 18 2016
I can reproduce this with go.cnn.com on nyan_big. Screenshot attached.
,
Oct 18 2016
CC NVIDIA folks. Video playback corruption with the freon enabled drivers.
,
Oct 18 2016
,
Oct 18 2016
,
Oct 18 2016
@nvidia: It seems like there is a tiling mismatch somewhere. Is the video decoder producing linear or tiled frames? If it can only produce linear, then we might not be allocating the memory correctly in minigbm.
,
Oct 18 2016
,
Oct 18 2016
Joseph, is this reproducible on Nyan-Blaze?
,
Oct 18 2016
The chrome ui log does not seem to print any errors. There are some stuff printed from NvMMLite and TVMR that pertains to video, but they look ok to me. [WARNING:flash/platform/pepper/pep_hw_video_decompressor_instance_ave.cpp(718)] Creating Pepper HW VideoDecoder NvMMLiteOpen : Block : BlockType = 261 TVMR: NvMMLiteTVMRDecBlockOpen: 7487: NvMMLiteBlockOpen NvMMLiteBlockCreate : Block : BlockType = 261 [WARNING:flash/platform/pepper/pep_url_request_info.cpp(195)] Illegal HTTP header field: "User-Agent". [WARNING:flash/platform/pepper/pep_url_request_info.cpp(195)] Illegal HTTP header field: "Connection". ".ARNING:flash/platform/pepper/pep_url_request_info.cpp(219)] Missing colon in HTTP header line " TVMR: cbBeginSequence: 1114: BeginSequence 768x432, bVPR = 0, fFrameRate = 23.976024 TVMR: LowCorner Frequency = 120000000 TVMR: cbBeginSequence: 1489: DecodeBuffers = 5, pnvsi->eCodec = 4, codec = 0 TVMR: cbBeginSequence: 1550: Display Resolution : (768x432) TVMR: cbBeginSequence: 1551: Display Aspect Ratio : (768x432) TVMR: cbBeginSequence: 1593: ColorFormat : 5 TVMR: cbBeginSequence:1607 ColorSpace = NvColorSpace_YCbCr601 TVMR: cbBeginSequence: 1731: SurfaceLayout = 3 TVMR: cbBeginSequence: 1807: NumOfSurfaces = 6, InteraceStream = 0, InterlaceEnabled = 0, bSecure = 0, MVC = 0 Semiplanar = 1, bReinit = 1, BitDepthForSurface = 8 LumaBitDepth = 8, ChromaBitDepth = 8, ChromaFormat = 5 TVMR: FrameRate = 10000000
,
Oct 18 2016
The allocation doesn't go through minigbm, actually it's allocated on the V4L2 side, and then imported into egl with dmabuf import. I suspect we need to pass different modifiers from the v4l2 tegra VDA. So the fix could be: - change chrome V4L2 tegra VDA to pass the modifiers - modify libGLES to support more modifier formats (the one which video uses). What do you think?
,
Oct 18 2016
Alternatively, it could be that the video engine is outputting a compressed stream...
,
Oct 18 2016
Can confirm that both the flash path and the HTML5 path (e.g. "Big Buck Bunny" H.264 HTML5) go through the same V4L2VideoDecodeAccelerator path with H.264 codec type. Since HTML5 shows no corruption, the problem may lie elsewhere that's pepper flash specific.
,
Oct 18 2016
HTML5 and Flash both use same accelerated path as said in comment #15, since HTML5 shows no corruption, there is no issue with the VDA path.
,
Oct 18 2016
Flash uses GL_TEXTURE_EXTERNAL_OES. Is this the same for html5?
,
Oct 18 2016
On Tegra, EGLImage target is set to EGL_GL_TEXTURE_2D_KHR while creating EGLImage however as per VDA code @ https://cs.chromium.org/chromium/src/media/gpu/v4l2_video_decode_accelerator.cc?q=v4l2_video_decode_accelerator&sq=package:chromium&l=458 it is bind to GL_TEXTURE_EXTERNAL_OES, can this be the issue ? This same works for non-Freon build platform 8799.0.0 though. I am also seeing following warnings from pepper/flash plugin code. [WARNING:flash/platform/pepper/pep_hw_video_decompressor_instance.cpp(732)] Pepper HW VideoDecoder NotifyError=4. [WARNING:flash/platform/pepper/pep_frame_video_plane.cpp(330)] Decompressor context lost (possible texture leak).
,
Oct 18 2016
Re:#18 what is the recommended target? I have tried to use GL_TEXTURE_EXTERNAL_OES in eglCreateImageKHR and simply get failures and falling back to SW: [18989:18989:1018/115017:ERROR:tegra_v4l2_device.cc(217)] Unable to create EGL image [18989:18989:1018/115017:ERROR:v4l2_video_decode_accelerator.cc(464)] CreateEGLImageFor(): could not create EGLImageKHR, index=0 texture_id=47 [18989:18989:1018/115017:ERROR:v4l2_video_decode_accelerator.cc(466)] CreateEGLImageFor(): Setting error state:4 [18989:18989:1018/115017:ERROR:tegra_v4l2_device.cc(217)] Unable to create EGL image [18989:18989:1018/115017:ERROR:v4l2_video_decode_accelerator.cc(464)] CreateEGLImageFor(): could not create EGLImageKHR, index=1 texture_id=50 [18989:18989:1018/115017:ERROR:v4l2_video_decode_accelerator.cc(466)] CreateEGLImageFor(): Setting error state:4 [18989:18989:1018/115017:ERROR:tegra_v4l2_device.cc(217)] Unable to create EGL image [18989:18989:1018/115017:ERROR:v4l2_video_decode_accelerator.cc(464)] CreateEGLImageFor(): could not create EGLImageKHR, index=2 texture_id=51 [18989:18989:1018/115017:ERROR:v4l2_video_decode_accelerator.cc(466)] CreateEGLImageFor(): Setting error state:4 [18989:18989:1018/115017:ERROR:tegra_v4l2_device.cc(217)] Unable to create EGL image Any ideas? I think for the short term we should disable flash video HW decode until this is investigated.
,
Oct 18 2016
Let's disable flash HW video decode for now.
,
Oct 19 2016
,
Oct 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/0a247c422032dd049f42856dd9811af69e774d85 commit 0a247c422032dd049f42856dd9811af69e774d85 Author: Haixia Shi <hshi@chromium.org> Date: Tue Oct 18 20:42:55 2016 overlay-nyan: disable flash HW video decode. We're seeing flash HW video decode corruption. BUG= chromium:652799 TEST=build_packages and verify chrome cmdline args Change-Id: I8a48c422267a5d004042bbec0e33aa317193464d Reviewed-on: https://chromium-review.googlesource.com/400009 Commit-Ready: Haixia Shi <hshi@chromium.org> Tested-by: Haixia Shi <hshi@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> [modify] https://crrev.com/0a247c422032dd049f42856dd9811af69e774d85/overlay-nyan/make.conf
,
Oct 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/02af964138a1711a1e97058613f0fdc4fcc1177e commit 02af964138a1711a1e97058613f0fdc4fcc1177e Author: Haixia Shi <hshi@chromium.org> Date: Tue Oct 18 21:08:33 2016 lib-chromeos-use-flags: add disable_flash_hw_video_decode flag. BUG= chromium:652799 TEST=build_packages --board nyan_big and verify chrome cmdline args Change-Id: I762d618d19b598418515f9f8bd29d9e7aad07096 Reviewed-on: https://chromium-review.googlesource.com/399945 Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> Tested-by: Haixia Shi <hshi@chromium.org> [rename] https://crrev.com/02af964138a1711a1e97058613f0fdc4fcc1177e/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1-r19.ebuild [modify] https://crrev.com/02af964138a1711a1e97058613f0fdc4fcc1177e/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1.ebuild
,
Oct 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a70786aa4eafa0080d87b3d41987912773c98bf5 commit a70786aa4eafa0080d87b3d41987912773c98bf5 Author: Haixia Shi <hshi@chromium.org> Date: Tue Oct 18 20:45:23 2016 libchromeos-ui: add flag to disable flash HW video decode. BUG= chromium:652799 TEST=build_packages --board nyan Change-Id: I9ae74bff97ff5d9a7eabcd50d564b7723f126258 Reviewed-on: https://chromium-review.googlesource.com/399944 Reviewed-by: Mike Frysinger <vapier@chromium.org> Commit-Queue: Haixia Shi <hshi@chromium.org> Tested-by: Haixia Shi <hshi@chromium.org> Trybot-Ready: Haixia Shi <hshi@chromium.org> [modify] https://crrev.com/a70786aa4eafa0080d87b3d41987912773c98bf5/libchromeos-ui/chromeos/ui/chromium_command_builder.cc
,
Oct 19 2016
,
Oct 19 2016
,
Oct 19 2016
,
Oct 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a825ef2657157fe18c0aa43dc65bf56fc6fcbeeb commit a825ef2657157fe18c0aa43dc65bf56fc6fcbeeb Author: Haixia Shi <hshi@chromium.org> Date: Tue Oct 18 20:45:23 2016 libchromeos-ui: add flag to disable flash HW video decode. BUG= chromium:652799 TEST=build_packages --board nyan Change-Id: I9ae74bff97ff5d9a7eabcd50d564b7723f126258 Reviewed-on: https://chromium-review.googlesource.com/399944 Reviewed-by: Mike Frysinger <vapier@chromium.org> Commit-Queue: Haixia Shi <hshi@chromium.org> Tested-by: Haixia Shi <hshi@chromium.org> Trybot-Ready: Haixia Shi <hshi@chromium.org> (cherry picked from commit a70786aa4eafa0080d87b3d41987912773c98bf5) Reviewed-on: https://chromium-review.googlesource.com/399936 Reviewed-by: Haixia Shi <hshi@chromium.org> [modify] https://crrev.com/a825ef2657157fe18c0aa43dc65bf56fc6fcbeeb/libchromeos-ui/chromeos/ui/chromium_command_builder.cc
,
Oct 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7344202208d5e3fdcb0d9fdda3363ee35ffb4ee3 commit 7344202208d5e3fdcb0d9fdda3363ee35ffb4ee3 Author: Haixia Shi <hshi@chromium.org> Date: Tue Oct 18 21:08:33 2016 lib-chromeos-use-flags: add disable_flash_hw_video_decode flag. BUG= chromium:652799 TEST=build_packages --board nyan_big and verify chrome cmdline args Change-Id: I762d618d19b598418515f9f8bd29d9e7aad07096 Reviewed-on: https://chromium-review.googlesource.com/399945 Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> Tested-by: Haixia Shi <hshi@chromium.org> (cherry picked from commit 02af964138a1711a1e97058613f0fdc4fcc1177e) Reviewed-on: https://chromium-review.googlesource.com/399955 Reviewed-by: Haixia Shi <hshi@chromium.org> Commit-Queue: Haixia Shi <hshi@chromium.org> Trybot-Ready: Haixia Shi <hshi@chromium.org> [rename] https://crrev.com/7344202208d5e3fdcb0d9fdda3363ee35ffb4ee3/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1-r19.ebuild [modify] https://crrev.com/7344202208d5e3fdcb0d9fdda3363ee35ffb4ee3/chromeos-base/libchromeos-use-flags/libchromeos-use-flags-0.0.1.ebuild
,
Oct 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/01e3a92731a047c70e62cb4f0783900dbe60aae6 commit 01e3a92731a047c70e62cb4f0783900dbe60aae6 Author: Haixia Shi <hshi@chromium.org> Date: Tue Oct 18 20:42:55 2016 nyan_freon: disable flash HW video decode. We're seeing flash HW video decode corruption on nyan_freon. Note that this is not a straight cherry-pick of CL:400009 on master. We only need to disable flash HW video decode for nyan_freon on R55. BUG= chromium:652799 TEST=build_packages and verify chrome cmdline args Change-Id: I8a48c422267a5d004042bbec0e33aa317193464d Reviewed-on: https://chromium-review.googlesource.com/400009 Commit-Ready: Haixia Shi <hshi@chromium.org> Tested-by: Haixia Shi <hshi@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> (cherry picked from commit 0a247c422032dd049f42856dd9811af69e774d85) Reviewed-on: https://chromium-review.googlesource.com/399896 Reviewed-by: Haixia Shi <hshi@chromium.org> Commit-Queue: Haixia Shi <hshi@chromium.org> Trybot-Ready: Haixia Shi <hshi@chromium.org> [modify] https://crrev.com/01e3a92731a047c70e62cb4f0783900dbe60aae6/overlay-variant-nyan-freon/make.conf
,
Oct 19 2016
,
Oct 19 2016
,
Oct 20 2016
Verified on 8872.18.0/55.0.2883.20 |
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by hsiangc@chromium.org
, Oct 4 2016