Issue metadata
Sign in to add a comment
|
16.5% regression in smoothness.key_desktop_move_cases at 422483:422541 |
||||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 4 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8999707215119864400
,
Oct 4 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Revert of Move synthetic gesture input to be aligned with BeginFrame. (patchset #2 id:20001 of https://codereview.chromium.org/2372873003/ ) Author : dtapuska Commit description: Reason for revert: Appears RenderWidgetHostViewChildFrame ends up calling a virtual during the constructor and this isn't getting called. This is an existing bug. But the change in this CL reveals this bug so reverting this change for now. Original issue's description: > Move synthetic gesture input to be aligned with BeginFrame. > > The timing of synthetic events seems almost random. It is best to align > it with something that doesn't fluctuate. Android already rAF aligns its > synthetic input so do this for aura and mac as well. > > BUG= 646369 > > Committed: https://crrev.com/5248d2a4cc2ac706f0404b6c6edf196f5b491539 > Cr-Commit-Position: refs/heads/master@{#421528} TBR=sadrul@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 646369 Review-Url: https://codereview.chromium.org/2390813002 Cr-Commit-Position: refs/heads/master@{#422509} Commit : dfb4211ebbd9934c01cca376edf70fe44daa381f Date : Mon Oct 03 20:23:19 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@422482 18.4498 0.488318 5 good chromium@422497 18.3744 0.26506 5 good chromium@422505 18.1536 0.174471 5 good chromium@422507 18.4749 0.275825 5 good chromium@422508 18.5227 0.104164 5 good chromium@422509 20.7122 0.154301 5 bad <-- chromium@422512 21.0602 0.503175 5 bad chromium@422541 20.9582 0.362526 5 bad Bisect job ran on: win_x64_perf_bisect Bug ID: 652797 Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.key_desktop_move_cases Test Metric: mean_frame_time/mean_frame_time Relative Change: 13.60% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_x64_perf_bisect/builds/1494 Job details: https://chromeperf.appspot.com/buildbucket_job_status/8999707215119864400 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5837298283839488 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you! |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by tdres...@chromium.org
, Oct 4 2016