New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652792 link

Starred by 4 users

Issue metadata

Status: Fixed
Merged: issue 642814
Owner:
Use other robhogan account instead.
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Table headers overwrite body text on printed output

Reported by maddalo...@gmail.com, Oct 4 2016

Issue description

Chrome Version       : Version 53.0.2785.143 (64-bit)
URLs (if applicable) :N/A
Other browsers tested:
  Add OK or FAIL, along with the version, after other browsers where you
have tested this issue:
     Safari:OK
    Firefox:OK
         IE:OK

What steps will reproduce the problem?
(1) Open the attached StandardReports_BadHeader.htm in the latest version of Chrome
(2) Do File -> Print
(3) See in the print preview how the header line is replicated on all pages and on pages and later the header is overwriting body text. 

What is the expected result? I would prefer the original Chrome behavior of having the header line not printed on subsequent pages. Alternatively I would like the header line justfied at the top of the page and not over the body text. 


What happens instead? The header row gets re-printed at the top of each page overwriting body text. 


Please provide any additional information below. Attach a screenshot if
possible.

See the PDF for an example. This occurs in printing and preview printing of HTML pages. In our reports a <CAPTION><div...></Caption> precedes the <thead> on page one where they show up correctly. Until recently, the thead row was not printed on subsequent pages. Now the thead is printed on subsequent pages but appears to be offset from the top of the page similar to the first page where it was under the caption. This pushes the thead row down into the body rows. Is there a way to keep the thead row from showing up on subsequent pages? If not, your most expeditious attention to fixing this would be greatly appreciated since it is breaking reporting for our customers in our application on Chrome. This occurs on Mac and Windows. 

MS Edge shows the header on every page correctly formatted.
Mac/FireFox shows the header on every page correctly formatted
MS IE 11 does not show the header on every page. 

 
StandardReports_BadHeader.htm
27.2 KB View Download
Standard Reports.pdf
197 KB Download
I just checked and this is NOT fixed in Version 55.0.2880.0 canary (64-bit)
Cc: kkaluri@chromium.org
Components: Internals>Printing
Labels: -Type-Bug -Pri-3 M-55 hasbisect OS-Linux OS-Mac OS-Windows Pri-2 Type-Bug-Regression
Owner: robhogan@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on Windows 10, Mac 10.12 and Ubuntu 14.04 on latest chrome Stable version 53.0.2785.143. Issue is broken in M53. Below are the bisect details for the same:

Bisect Info:
===========
Good Build : 53.0.2758.0 , Revision Range (397861)                                           
Bad Build  : 53.0.2759.0 , Revision Range (397936)

Change Log:
-----------
https://chromium.googlesource.com/chromium/src/+log/25966f2863c58fb04faa48986150c363d30be6fa..7737b321ccfb843469dd625bb01dadda17a3a66f

From the above CL suspecting the below change
Review URL:https://codereview.chromium.org/2021703002

robhogan @- Could please look into this issue, if it's released to your change?  if not could you please help us to reassign this issue to the right owner.

Thanks.!
I have a simpler example file. Adding it to the ticket. You can see that if the CAPTION is removed then the problem does not occur. So it is related to the caption offset I think. 
sampleHTML.html
7.5 KB View Download

Comment 4 by robho...@gmail.com, Oct 5 2016

Mergedinto: 642814
Status: Duplicate (was: Assigned)

Comment 5 by robho...@gmail.com, Oct 12 2016

Status: Assigned (was: Duplicate)
 Issue 655098  has been merged into this issue.
Hi I have a couple questions. Is this a distinct issue from  Issue 642814 ? If so should it perhaps be un-merged? Is there any estimate available for when this issue with the caption causing the overwrite might be addressed? Thanks!
Components: Blink>Layout
It is currently unmerged, as the Status is "Assigned" and not "Duplicate". The Merged line is a weird artifact left over from when it was marked as a duplicate.
Labels: Merge-Request-55
@maddalozzo - this is fixed in the latest canary builds and will be fixed in the M55 release.

Comment 12 by dimu@chromium.org, Oct 27 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 27 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ec55a26615743c726e3c56bccc1eea659f33c53

commit 8ec55a26615743c726e3c56bccc1eea659f33c53
Author: Robert Hogan <robhogan@gmail.com>
Date: Thu Oct 27 08:45:31 2016

Repeating header groups should align properly when captions are present

BUG= 652792 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://chromiumcodereview.appspot.com/2422953003
Cr-Commit-Position: refs/heads/master@{#426243}
(cherry picked from commit 42151f9c0132a60a7be3b1793295a1966f532ca6)

Review URL: https://codereview.chromium.org/2453023003 .

Cr-Commit-Position: refs/branch-heads/2883@{#331}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[add] https://crrev.com/8ec55a26615743c726e3c56bccc1eea659f33c53/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-with-caption-expected.html
[add] https://crrev.com/8ec55a26615743c726e3c56bccc1eea659f33c53/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-with-caption.html
[add] https://crrev.com/8ec55a26615743c726e3c56bccc1eea659f33c53/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-with-two-captions-expected.html
[add] https://crrev.com/8ec55a26615743c726e3c56bccc1eea659f33c53/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-with-two-captions.html
[modify] https://crrev.com/8ec55a26615743c726e3c56bccc1eea659f33c53/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp

@robhogan Works for me on the canary build tested on MacOS El Capitan 10.11.6. Thanks!
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ec55a26615743c726e3c56bccc1eea659f33c53

commit 8ec55a26615743c726e3c56bccc1eea659f33c53
Author: Robert Hogan <robhogan@gmail.com>
Date: Thu Oct 27 08:45:31 2016

Repeating header groups should align properly when captions are present

BUG= 652792 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://chromiumcodereview.appspot.com/2422953003
Cr-Commit-Position: refs/heads/master@{#426243}
(cherry picked from commit 42151f9c0132a60a7be3b1793295a1966f532ca6)

Review URL: https://codereview.chromium.org/2453023003 .

Cr-Commit-Position: refs/branch-heads/2883@{#331}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[add] https://crrev.com/8ec55a26615743c726e3c56bccc1eea659f33c53/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-with-caption-expected.html
[add] https://crrev.com/8ec55a26615743c726e3c56bccc1eea659f33c53/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-with-caption.html
[add] https://crrev.com/8ec55a26615743c726e3c56bccc1eea659f33c53/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-with-two-captions-expected.html
[add] https://crrev.com/8ec55a26615743c726e3c56bccc1eea659f33c53/third_party/WebKit/LayoutTests/fragmentation/single-line-cells-repeating-thead-with-two-captions.html
[modify] https://crrev.com/8ec55a26615743c726e3c56bccc1eea659f33c53/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp

Comment 16 by e...@chromium.org, Nov 2 2016

Status: Fixed (was: Assigned)

Comment 17 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment