DragEvent location is wrong on ChromeOS with pinch scale |
|||||
Issue descriptionSteps to reproduce: 1. enable pinch scale on chrome book by going to chrome://flags and enable Pinch Scale 2. go to www.textarea.org and finger pinch zoom in 3. type some texts in multiple lines. 4. select a line of text and begin drag and drop 5. notice that the insertion cursor is at the wrong place. This is because ChromeOS' code for setting the drag event location does not consider page scale factor.
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d4fa85236725f161e2870a69faaca75c4e2a67d commit 3d4fa85236725f161e2870a69faaca75c4e2a67d Author: hush <hush@chromium.org> Date: Wed Oct 05 19:26:41 2016 Convert drag event position to root frame. The drag event positions are in viewport's coordinates when they are passed in blink::WebView. We then need to convert these coordinates into the root frame. In this way, the page scale factor is properly factored into the coordination conversion. BUG=651626, 652789 Review-Url: https://codereview.chromium.org/2396693002 Cr-Commit-Position: refs/heads/master@{#423250} [modify] https://crrev.com/3d4fa85236725f161e2870a69faaca75c4e2a67d/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java [modify] https://crrev.com/3d4fa85236725f161e2870a69faaca75c4e2a67d/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/3d4fa85236725f161e2870a69faaca75c4e2a67d/third_party/WebKit/Source/web/WebViewImpl.h [modify] https://crrev.com/3d4fa85236725f161e2870a69faaca75c4e2a67d/third_party/WebKit/public/web/WebView.h
,
Oct 5 2016
,
Oct 5 2016
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4eab7d2715b508e2893a6bd62919aa44a3c20f41 commit 4eab7d2715b508e2893a6bd62919aa44a3c20f41 Author: Hui Shu <hush@google.com> Date: Wed Oct 05 20:21:25 2016 Convert drag event position to root frame. The drag event positions are in viewport's coordinates when they are passed in blink::WebView. We then need to convert these coordinates into the root frame. In this way, the page scale factor is properly factored into the coordination conversion. BUG=651626, 652789 Review-Url: https://codereview.chromium.org/2396693002 Cr-Commit-Position: refs/heads/master@{#423250} (cherry picked from commit 3d4fa85236725f161e2870a69faaca75c4e2a67d) Conflicts: third_party/WebKit/Source/web/WebViewImpl.cpp third_party/WebKit/Source/web/WebViewImpl.h third_party/WebKit/public/web/WebView.h Review URL: https://codereview.chromium.org/2397883002 . Cr-Commit-Position: refs/branch-heads/2840@{#653} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/4eab7d2715b508e2893a6bd62919aa44a3c20f41/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java [modify] https://crrev.com/4eab7d2715b508e2893a6bd62919aa44a3c20f41/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/4eab7d2715b508e2893a6bd62919aa44a3c20f41/third_party/WebKit/Source/web/WebViewImpl.h [modify] https://crrev.com/4eab7d2715b508e2893a6bd62919aa44a3c20f41/third_party/WebKit/public/web/WebView.h
,
Oct 5 2016
Chrome tpm: please don't be alarmed about #5. This issues does not have a merge request tag because it is a duplicate of 651626.
,
Oct 6 2016
Hello QA: could you test this issue is fixed on on ChromeOS? Please follow the steps to reproduce in the original post.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d4fa85236725f161e2870a69faaca75c4e2a67d commit 3d4fa85236725f161e2870a69faaca75c4e2a67d Author: hush <hush@chromium.org> Date: Wed Oct 05 19:26:41 2016 Convert drag event position to root frame. The drag event positions are in viewport's coordinates when they are passed in blink::WebView. We then need to convert these coordinates into the root frame. In this way, the page scale factor is properly factored into the coordination conversion. BUG=651626, 652789 Review-Url: https://codereview.chromium.org/2396693002 Cr-Commit-Position: refs/heads/master@{#423250} [modify] https://crrev.com/3d4fa85236725f161e2870a69faaca75c4e2a67d/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java [modify] https://crrev.com/3d4fa85236725f161e2870a69faaca75c4e2a67d/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/3d4fa85236725f161e2870a69faaca75c4e2a67d/third_party/WebKit/Source/web/WebViewImpl.h [modify] https://crrev.com/3d4fa85236725f161e2870a69faaca75c4e2a67d/third_party/WebKit/public/web/WebView.h
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4eab7d2715b508e2893a6bd62919aa44a3c20f41 commit 4eab7d2715b508e2893a6bd62919aa44a3c20f41 Author: Hui Shu <hush@google.com> Date: Wed Oct 05 20:21:25 2016 Convert drag event position to root frame. The drag event positions are in viewport's coordinates when they are passed in blink::WebView. We then need to convert these coordinates into the root frame. In this way, the page scale factor is properly factored into the coordination conversion. BUG=651626, 652789 Review-Url: https://codereview.chromium.org/2396693002 Cr-Commit-Position: refs/heads/master@{#423250} (cherry picked from commit 3d4fa85236725f161e2870a69faaca75c4e2a67d) Conflicts: third_party/WebKit/Source/web/WebViewImpl.cpp third_party/WebKit/Source/web/WebViewImpl.h third_party/WebKit/public/web/WebView.h Review URL: https://codereview.chromium.org/2397883002 . Cr-Commit-Position: refs/branch-heads/2840@{#653} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/4eab7d2715b508e2893a6bd62919aa44a3c20f41/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java [modify] https://crrev.com/4eab7d2715b508e2893a6bd62919aa44a3c20f41/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/4eab7d2715b508e2893a6bd62919aa44a3c20f41/third_party/WebKit/Source/web/WebViewImpl.h [modify] https://crrev.com/4eab7d2715b508e2893a6bd62919aa44a3c20f41/third_party/WebKit/public/web/WebView.h |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by hush@chromium.org
, Oct 4 2016Status: Assigned (was: Untriaged)