New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652783 link

Starred by 15 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature


Sign in to add a comment

DevTools: support OOPIF from the same frontend

Project Member Reported by dgozman@chromium.org, Oct 4 2016

Issue description

The time has come to work on this.

The plan is to have multiple targets+connections to frames exposed via Target domain. Certain functionality should be disabled for frames (like device emulation).
 
Blockedon: 547112 472642 648126
Blockedon: 648775

Comment 3 by nasko@chromium.org, Oct 13 2016

Cc: nasko@chromium.org
 Issue 655151  has been merged into this issue.

Comment 4 by creis@chromium.org, Oct 18 2016

Cc: creis@chromium.org alph@chromium.org
 Issue 641777  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d61cd0b7c463ee9907c8fb90b22a11c19829e486

commit d61cd0b7c463ee9907c8fb90b22a11c19829e486
Author: dgozman <dgozman@chromium.org>
Date: Wed Nov 09 23:42:04 2016

[DevTools] Force contexts initialization in OOPIF case.

This happens when you connect DevTools to the page without context.

Previously, we checked for the main frame being a local frame.
Now we force for every local frame in the subtree.

BUG= 652783 

Review-Url: https://codereview.chromium.org/2491063002
Cr-Commit-Position: refs/heads/master@{#431082}

[modify] https://crrev.com/d61cd0b7c463ee9907c8fb90b22a11c19829e486/third_party/WebKit/Source/core/page/Page.cpp

Blockedon: 667533
Blockedon: 667429

Comment 8 by creis@chromium.org, Jan 5 2017

Cc: kozyatinskiy@chromium.org
Status: Started (was: Assigned)
This work is in progress and available behind an experimental feature in DevTools.

For reference, here's how to experiment with it today:
1) Enable "Developer Tools experiments" on chrome://flags, and restart.
2) Open DevTools Settings, go to Experiments tab, and press Shift 7 times.
3) Check "Auto-attach to cross-process subframes."
4) Open a new DevTools instance on a page that has an OOPIF (e.g., http://csreis.github.io/tests/cross-site-iframe-simple.html when running with --site-per-process).

Comment 9 by creis@chromium.org, Jan 5 2017

Blockedon: 678435
Blockedon: 678442
Blockedon: 678447
Labels: Proj-TopDocumentIsolation-BlockingLaunch
Blockedon: 683321
Blockedon: 684209
Cc: dgozman@chromium.org
 Issue 697743  has been merged into this issue.
 Issue 697126  has been merged into this issue.

Comment 17 by woxxom@gmail.com, Mar 6 2017

Hopefully, it'll be possible to use element picker to select DOM elements interactively inside OOPIF. Currently the entire iframe element is selected in the main DOM tree of the page.
This is already possible, if you follow steps from #c8.

Comment 19 by woxxom@gmail.com, Mar 6 2017

>This is already possible, if you follow steps from #c8.

Uhm, I did follow the steps, this thread is short enough for me to notice the instruction. A second DOM tree for OOPIF is displayed in the Elements panel but element picker can't select inside OOPIF on the test site from c#8.
Re #c19: sorry, I misunderstood what you are talking about. Indeed, that does not work. I'll fix it.
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d20a42b6f8b1f703717dac5c7936223ba129e1a3

commit d20a42b6f8b1f703717dac5c7936223ba129e1a3
Author: dgozman <dgozman@chromium.org>
Date: Tue Mar 07 18:29:50 2017

[DevTools] Pass events to remote frames in inspect mode.

Before, we inspected a frame owner element for remote frame on click.
Now we clear highlight and do not consume event so that remote frame
could handle it and inspect proper node inside.

BUG= 652783 

Review-Url: https://codereview.chromium.org/2736603004
Cr-Commit-Position: refs/heads/master@{#455147}

[modify] https://crrev.com/d20a42b6f8b1f703717dac5c7936223ba129e1a3/third_party/WebKit/Source/web/InspectorOverlay.cpp

Blockedon: 701506
 Issue 703185  has been merged into this issue.
Project Member

Comment 24 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2a5081b066eb679783fc84c7fb4b11480ffb696

commit a2a5081b066eb679783fc84c7fb4b11480ffb696
Author: dgozman <dgozman@chromium.org>
Date: Fri May 05 01:49:00 2017

[DevTools] Enable "auto attach to sub frames" by default

Also made "Inspect Element" open DevTools for main page now.

BUG= 652783 

Review-Url: https://codereview.chromium.org/2859063002
Cr-Commit-Position: refs/heads/master@{#469568}

[modify] https://crrev.com/a2a5081b066eb679783fc84c7fb4b11480ffb696/chrome/browser/devtools/devtools_window.cc
[modify] https://crrev.com/a2a5081b066eb679783fc84c7fb4b11480ffb696/third_party/WebKit/Source/devtools/front_end/main/Main.js

Status: Fixed (was: Started)
The main work is done here. We are tracking the reset in separate issues.

Sign in to add a comment