New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 652779 link

Starred by 1 user
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Missing WindowFeaturesStructTraits.cpp dependency on mojom

Project Member Reported by roc...@chromium.org, Oct 4 2016 
Some builders are failing flakily because the mojom header isn't generated by the time WindowFeaturesStructTraits.cpp is compiled.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6d9f1684e068e90f0fbdd00ea61fc99ba530561

commit a6d9f1684e068e90f0fbdd00ea61fc99ba530561
Author: rockot <rockot@chromium.org>
Date: Tue Oct 04 20:57:24 2016

Fix window_features.mojom Blink traits dependency

The traits impl was depending on the wrong generator target,
leading to potential build flag.

BUG= 652779 
TBR=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2392903003
Cr-Commit-Position: refs/heads/master@{#422925}

[modify] https://crrev.com/a6d9f1684e068e90f0fbdd00ea61fc99ba530561/third_party/WebKit/public/BUILD.gn

Comment 2 by roc...@chromium.org, Oct 4 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment