Findit unittests failing in master |
||||||
Issue description
Known-good Version: git hash 535f86f
Known-bad Version: git hash 094ae0a
Running `./util_scripts/run.sh test` results in a bunch of failures that look like the following:
Traceback (most recent call last):
File "/usr/local/google/home/wrengr/chromium-srcs/infra/ENV/local/lib/python2.7/site-packages/expect_tests/pipeline.py", line 397, in process_test
subresult = subtest.run()
File "/usr/local/google/home/wrengr/chromium-srcs/infra/ENV/local/lib/python2.7/site-packages/expect_tests/type_definitions.py", line 240, in run
return self.func_call(context=context)
File "/usr/local/google/home/wrengr/chromium-srcs/infra/ENV/local/lib/python2.7/site-packages/expect_tests/type_definitions.py", line 155, in __call__
return f.func(*f.args, **f.kwargs)
File "/usr/local/google/home/wrengr/chromium-srcs/infra/ENV/local/lib/python2.7/site-packages/expect_tests/unittest_helper.py", line 40, in _RunTestCaseSingle
return Result(test_method())
File "/usr/local/google/home/wrengr/chromium-srcs/infra/appengine/findit/common/test/time_util_test.py", line 44, in testGetDateTimeInTimezone
'US/Pacific', utc_datetime)
File "/usr/local/google/home/wrengr/chromium-srcs/infra/appengine/findit/common/time_util.py", line 60, in GetDatetimeInTimezone
return date_time.astimezone(pytz.timezone(timezone_name))
File "/usr/local/google/home/wrengr/chromium-srcs/infra/appengine/findit/third_party/pytz/__init__.py", line 173, in timezone
raise UnknownTimeZoneError(zone)
UnknownTimeZoneError: 'US/Pacific'
,
Oct 4 2016
,
Oct 4 2016
Thanks for the bug. Fix is just CQed. https://codereview.chromium.org/2391063002/
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/4a1905687b069669d910806d67775bef70d7377a commit 4a1905687b069669d910806d67775bef70d7377a Author: stgao <stgao@chromium.org> Date: Tue Oct 04 18:41:50 2016 [Findit] Fix flaky tests due to importing pytz. BUG= 652777 Review-Url: https://codereview.chromium.org/2391063002 [modify] https://crrev.com/4a1905687b069669d910806d67775bef70d7377a/appengine/findit/common/test/time_util_test.py [modify] https://crrev.com/4a1905687b069669d910806d67775bef70d7377a/appengine/findit/common/time_util.py [modify] https://crrev.com/4a1905687b069669d910806d67775bef70d7377a/appengine/findit/waterfall/flake/recursive_flake_pipeline.py [modify] https://crrev.com/4a1905687b069669d910806d67775bef70d7377a/appengine/findit/waterfall/flake/test/recursive_flake_pipeline_test.py
,
Oct 4 2016
I think this should be fixed by the CL. Please feel free to reopen if it happens again.
,
Nov 30 2016
,
Nov 30 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by wrengr@chromium.org
, Oct 4 2016