New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652777 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 644372



Sign in to add a comment

Findit unittests failing in master

Project Member Reported by wrengr@chromium.org, Oct 4 2016

Issue description

Known-good Version: git hash 535f86f
Known-bad Version: git hash 094ae0a


Running `./util_scripts/run.sh test` results in a bunch of failures that look like the following:

Traceback (most recent call last):
  File "/usr/local/google/home/wrengr/chromium-srcs/infra/ENV/local/lib/python2.7/site-packages/expect_tests/pipeline.py", line 397, in process_test
    subresult = subtest.run()
  File "/usr/local/google/home/wrengr/chromium-srcs/infra/ENV/local/lib/python2.7/site-packages/expect_tests/type_definitions.py", line 240, in run
    return self.func_call(context=context)
  File "/usr/local/google/home/wrengr/chromium-srcs/infra/ENV/local/lib/python2.7/site-packages/expect_tests/type_definitions.py", line 155, in __call__
    return f.func(*f.args, **f.kwargs)
  File "/usr/local/google/home/wrengr/chromium-srcs/infra/ENV/local/lib/python2.7/site-packages/expect_tests/unittest_helper.py", line 40, in _RunTestCaseSingle
    return Result(test_method())
  File "/usr/local/google/home/wrengr/chromium-srcs/infra/appengine/findit/common/test/time_util_test.py", line 44, in testGetDateTimeInTimezone
    'US/Pacific', utc_datetime)
  File "/usr/local/google/home/wrengr/chromium-srcs/infra/appengine/findit/common/time_util.py", line 60, in GetDatetimeInTimezone
    return date_time.astimezone(pytz.timezone(timezone_name))
  File "/usr/local/google/home/wrengr/chromium-srcs/infra/appengine/findit/third_party/pytz/__init__.py", line 173, in timezone
    raise UnknownTimeZoneError(zone)
UnknownTimeZoneError: 'US/Pacific'
 
Blocking: 615262
Blocking: 644372

Comment 3 by st...@chromium.org, Oct 4 2016

Owner: st...@chromium.org
Status: Started (was: Untriaged)
Thanks for the bug.

Fix is just CQed. https://codereview.chromium.org/2391063002/

Comment 5 by st...@chromium.org, Oct 4 2016

Status: Fixed (was: Started)
I think this should be fixed by the CL. Please feel free to reopen if it happens again.
Blocking: -615262

Comment 7 by st...@chromium.org, Nov 30 2016

Status: Verified (was: Fixed)

Sign in to add a comment