New issue
Advanced search Search tips

Issue 652757 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 0
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

Android accessibility actions broken inside iframes

Project Member Reported by dmazz...@chromium.org, Oct 4 2016

Issue description

Many accessibility actions from Android accessibility services do not work inside iframes. It looks like this has been broken since crrev.com/379775

What was NOT broken:
* Touch exploration to elements inside iframes
* Navigation to elements inside iframes by swiping left / right
* Double-tapping to click on an element inside an iframe

What was broken:
* Scrolling an element in an iframe into view
* Clicking an element in an iframe with ACTION_CLICK (sent by switch access, for example)
* Incrementing/decrementing a slider inside an iframe
* Explicitly setting the value of a control inside an iframe

This wasn't caught because the first three things worked just fine, and those are the most common actions taken. For small iframes with only clickable elements this bug wouldn't have been noticed.

Internal bug: b/31636155

 

Comment 1 by torne@chromium.org, Oct 5 2016

Labels: M-54 ReleaseBlock-Stable
Marking as M54 release blocker for now pending discussion on internal thread.
[Bulk edit]

URGENT: This issue is marked as an RB-Stable for Android M54.  If it is going to block the release, it needs to be fixed ASAP, and merged back to branch 2840 by 5 PM PT Oct 11.

Please review and if you cannot get it fixed by then, ping me; if you don't believe you are the right owner, and you cannot find another one - please ping me.
Labels: Merge-Request-53 Merge-Request-54
Status: Fixed (was: Started)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/909ee6ee26be0ad7f89e07806c96f142328e0993

commit 909ee6ee26be0ad7f89e07806c96f142328e0993
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue Oct 04 19:38:55 2016

Android accessibility actions inside iframes not sent to right frame

When sending a message from the BrowserAccessibilityManagerAndroid to the
render process to perform some accessibility action on a node, we need to
send it to the right frame by calling the delegate function on the node's
BrowserAccessibilityManager. We were incorrectly calling it on the current
BrowserAccessibilityManager, which is only the same for elements in the
root frame.

BUG=562757

Review-Url: https://codereview.chromium.org/2395533002
Cr-Commit-Position: refs/heads/master@{#422887}

[modify] https://crrev.com/909ee6ee26be0ad7f89e07806c96f142328e0993/content/browser/accessibility/browser_accessibility_manager_android.cc

Labels: -Merge-Request-53 -Merge-Request-54 Merge-Approved-53 Merge-Approved-55 Merge-Approved-54
Merge approved for M53 minibranch (2785_124), M54 (2840) and M55 (2883).
commit 1b94912ecff1b6589af8f5a8b8379b48deac0bcc
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date:   Mon Oct 10 11:07:00 2016 -0700

    Merge to M53: Android accessibility actions inside iframes not sent to right frame
    
    When sending a message from the BrowserAccessibilityManagerAndroid to the
    render process to perform some accessibility action on a node, we need to
    send it to the right frame by calling the delegate function on the node's
    BrowserAccessibilityManager. We were incorrectly calling it on the current
    BrowserAccessibilityManager, which is only the same for elements in the
    root frame.
    
    BUG=562757
    
    Review-Url: https://codereview.chromium.org/2395533002
    Cr-Commit-Position: refs/heads/master@{#422887}
    (cherry picked from commit 909ee6ee26be0ad7f89e07806c96f142328e0993)
    
    Review URL: https://codereview.chromium.org/2408743003 .
    
    Cr-Commit-Position: refs/branch-heads/2785_124@{#4}
    Cr-Branched-From: 7f5781e9210f9b7c8914adbc018590eec1ede150-refs/branch-heads/2785@{#902}
    Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}



commit 852c2f7299bca42d9885b5f2cefab577b2d76964
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date:   Mon Oct 10 11:38:35 2016 -0700

    Merge to M54: Android accessibility actions inside iframes not sent to right frame
    
    When sending a message from the BrowserAccessibilityManagerAndroid to the
    render process to perform some accessibility action on a node, we need to
    send it to the right frame by calling the delegate function on the node's
    BrowserAccessibilityManager. We were incorrectly calling it on the current
    BrowserAccessibilityManager, which is only the same for elements in the
    root frame.
    
    BUG=562757
    
    Review-Url: https://codereview.chromium.org/2395533002
    Cr-Commit-Position: refs/heads/master@{#422887}
    (cherry picked from commit 909ee6ee26be0ad7f89e07806c96f142328e0993)
    
    Review URL: https://codereview.chromium.org/2403953002 .
    
    Cr-Commit-Position: refs/branch-heads/2840@{#703}
    Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

Labels: -Merge-Approved-53 -Merge-Approved-54
Still need M55 (if required), removing approvals for items already merged.
Project Member

Comment 7 by sheriffbot@chromium.org, Oct 14 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
[Bulk edit]

Please process this M55 merge by landing the appropriate CLs on branch 2883 by Monday at 5 PM PT, or it will miss our beta candidate build.  Ping me if you have questions / concerns.
Project Member

Comment 9 by sheriffbot@chromium.org, Oct 18 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by aluo@chromium.org, Oct 19 2016

Verified on Nexus 5x, NRD91N, 54.0.2840.68
Status: Verified (was: Fixed)
Verified on Asus Zenphone (LRX 21V) with webview 54.0.2840.68 
Labels: -M-54 -ReleaseBlock-Stable -Merge-Approved-55
This patch landed before M55 was branched so no merge is needed.

It's already been merged to M54 and M53, so removing all labels.

Sign in to add a comment