New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652755 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Bad mojo renderer IPC call stacks useless from the IO thread

Project Member Reported by roc...@chromium.org, Oct 4 2016

Issue description

We PostTask to the UI thread before reporting a bad Mojo IPC in RenderProcessHostImpl. This makes the call stack useless and requires digging into a minidump to deduce the source of the crash.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f050c89a2ba1799844b3615884000d5fa7a03e11

commit f050c89a2ba1799844b3615884000d5fa7a03e11
Author: rockot <rockot@chromium.org>
Date: Wed Oct 05 01:28:28 2016

Better bad message reporting from IO thread

This makes crash dumping optional for RPH::ShutdownForBadMessage,
and changes the thread-safe bad_message::ReceivedBadMessage to
generate its own crash dump immediately, before potentially posting
a UI thread task.

All other call sites have been updated to opt into crash dumping,
preserving previous behavior.

This ensures that bad message reports from the IO thread have a
useful crash stack.

BUG= 652755 
R=jam@chromium.org

Review-Url: https://codereview.chromium.org/2387113004
Cr-Commit-Position: refs/heads/master@{#423040}

[modify] https://crrev.com/f050c89a2ba1799844b3615884000d5fa7a03e11/chrome/browser/bad_message.cc
[modify] https://crrev.com/f050c89a2ba1799844b3615884000d5fa7a03e11/components/password_manager/content/browser/bad_message.cc
[modify] https://crrev.com/f050c89a2ba1799844b3615884000d5fa7a03e11/content/browser/bad_message.cc
[modify] https://crrev.com/f050c89a2ba1799844b3615884000d5fa7a03e11/content/browser/media/android/browser_media_session_manager.cc
[modify] https://crrev.com/f050c89a2ba1799844b3615884000d5fa7a03e11/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/f050c89a2ba1799844b3615884000d5fa7a03e11/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/f050c89a2ba1799844b3615884000d5fa7a03e11/content/public/browser/render_process_host.h
[modify] https://crrev.com/f050c89a2ba1799844b3615884000d5fa7a03e11/content/public/test/mock_render_process_host.cc
[modify] https://crrev.com/f050c89a2ba1799844b3615884000d5fa7a03e11/content/public/test/mock_render_process_host.h
[modify] https://crrev.com/f050c89a2ba1799844b3615884000d5fa7a03e11/extensions/browser/bad_message.cc

Status: Fixed (was: Assigned)

Sign in to add a comment