New issue
Advanced search Search tips

Issue 652754 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 718921
Owner: ----
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Android captive portal login app crashing in RunJavaScriptDialog

Project Member Reported by torne@chromium.org, Oct 4 2016

Issue description

The android captive portal login app seems to crash fairly frequently in RunJavaScriptDialog. Since we have the source for this app we should look into this, to confirm whether it's an app bug (in which case we can file an internal bug to get it fixed) or whether it's maybe our fault. See:

https://crash.corp.google.com/browse?q=product.name%3D%27AndroidWebView%27%20AND%20special_protos.user_feedback.mobile_data.build_data.sdk_int%3E%3D21%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BAndroid%20Java%20Exception%5D%20android_webview%3A%3AAwContentsClientBridge%3A%3ARunJavaScriptDialog%27%20AND%20special_protos.user_feedback.mobile_data.package_data.package_name%3D%27com.android.captiveportallogin.100500.8590045411%27&ignore_case=false&enable_rewrite=true&omit_field_name=&omit_field_value=&omit_field_opt=%3D

This has been happening since at least M51, so it's not a recent regression.
 

Comment 1 by boliu@chromium.org, Oct 10 2016

captiveportallogin isn't very interesting. webview is inflated, so webview should get an activity

it doesn't override WebChromeClient.onJsPrompt, which means it gets the default implementation and just returns false. Then in WebViewContentsClientAdapter, it ends up calling showDefaultJsDialog, but first does an Activity check.

So basically no idea. GSA's tricks can render Activity check useless, but I don't see that happening in captiveportallogin. Someone has to try reproducing this and see what the actual java stack is. meh
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 11 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by ctzsm@chromium.org, Oct 20 2017

Mergedinto: 718921
Status: Duplicate (was: Untriaged)
Given the crash only happens in below M60 and the corresponding tracking  issue 718921  is fixed already, I am going to dup this to 718921.

Sign in to add a comment