Add rollback check to recovery initramfs scripts |
||||||
Issue descriptionIf a recovery image is properly signed, it will always work on a given system. There is no way to lock out that image if it is buggy or vulnerable. This is intentional, because whatever rollback information is stored on the system could theoretically become corrupt and a recovery image would need to be able to boot to fix that. But that means that we can't currently lock out old recovery images. Instead, put the rollback check at the start of the recovery image's initramfs script. That way, the recovery image will lock itself out before its attack surface grows very far. And because the check is in the recovery image, in the event that devices are somehow broken in a way which makes the check fail, we can release a new recovery image which works around that breakage. (This won't help existing recovery images, but it will help new ones...)
,
Oct 4 2016
Here's a standalone script which has the important implementationy bits in it. It just needs incorporating into all of the initramfs scripts, then testing.
,
Oct 4 2016
Do you want to include the addition of the delay in this bug, or do you want me to file a new bug for that?
,
Oct 4 2016
Re#3: Let's make that a separate bug. It's a different feature.
,
Oct 4 2016
Filed issue 652796 for the delay.
,
Feb 1 2017
,
Feb 25 2017
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/initramfs/+/a0f0b6ba3da4e4bcf9ffd277e903b19c75501fca commit a0f0b6ba3da4e4bcf9ffd277e903b19c75501fca Author: Shelley Chen <shchen@chromium.org> Date: Fri Mar 03 04:17:44 2017 Recovery: Adding FW rollback check BUG= chromium:652748 BRANCH=None TEST=build recovery image and ran it on chell & sentry. Change-Id: I3e07dd76adfe98b92e2c53daf3b8b5866cf1cd62 Signed-off-by: Shelley Chen <shchen@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/437592 Reviewed-by: Randall Spangler <rspangler@chromium.org> [modify] https://crrev.com/a0f0b6ba3da4e4bcf9ffd277e903b19c75501fca/recovery/init [modify] https://crrev.com/a0f0b6ba3da4e4bcf9ffd277e903b19c75501fca/recovery/recovery_init.sh
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rspangler@chromium.org
, Oct 4 2016