Issue 652744 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	█ kevcheng@chromium.org Last visit > 30 days ago
Closed:	Oct 2016
Cc:	█ kevcheng@chromium.org
Components:	Infra>Client>ChromeOS
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

servod repair uses the wrong 'stop servod' command for servo V4

Reported by jrbarnette@chromium.org, Oct 4 2016

Issue description

The _RestartServod repair action includes this call to stop servod:
        host.run('stop servod || true')

That command is wrong; it doesn't include a 'PORT=' argument, which
means it will fail on a servo V4 if there's more than one servod
instance.

Comment 1 by autumn@chromium.org, Oct 12 2016

Owner: kevcheng@chromium.org

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/15948ac45c621eeb27ac17c4cb418ad159b7674a

commit 15948ac45c621eeb27ac17c4cb418ad159b7674a
Author: Kevin Cheng <kevcheng@chromium.org>
Date: Tue Oct 18 22:04:54 2016

[autotest] Update servo repair to pass in servo port when stopping servod

BUG= chromium:652744 
TEST=None

Change-Id: I11f583cd97128e2d37883a2d426989a1688795f0
Reviewed-on: https://chromium-review.googlesource.com/400620
Commit-Ready: Dan Shi <dshi@google.com>
Tested-by: Kevin Cheng <kevcheng@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/15948ac45c621eeb27ac17c4cb418ad159b7674a/server/hosts/servo_repair.py