[NaCl SDK] nacl_sdk builders are broken on 53 and 54 branches |
||||||||||
Issue descriptionhttps://build.chromium.org/p/client.nacl.sdk/builders/linux-sdk-multirel/builds/5067/steps/generate_build_files/logs/stdio ``` Traceback (most recent call last): File "/mnt/data/b/build/slave/sdk-rel/build/src/tools/mb/mb.py", line 59, in Main ret = self.args.func() File "/mnt/data/b/build/slave/sdk-rel/build/src/tools/mb/mb.py", line 253, in CmdGen vals = self.Lookup() File "/mnt/data/b/build/slave/sdk-rel/build/src/tools/mb/mb.py", line 580, in Lookup config = self.ConfigFromArgs() File "/mnt/data/b/build/slave/sdk-rel/build/src/tools/mb/mb.py", line 659, in ConfigFromArgs (self.args.master, self.args.config_file)) MBErr: Master name "client.nacl.sdk" not found in "/mnt/data/b/build/slave/sdk-rel/build/src/tools/mb/mb_config.pyl" step returned non-zero exit code: 1 ``` Looks like the fix is simply to backport the trivial change to mb_config_pyl: https://chromium.googlesource.com/chromium/src/tools/mb/+/128ef100bdefa5cf0dead4a2156df216e319b3b7%5E%21/
,
Oct 4 2016
For Chrome Desktop, there is no more M53 stable release plan.
,
Oct 5 2016
[Automated comment] Request affecting a post-stable build (M53), manual review required.
,
Oct 5 2016
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.
,
Oct 5 2016
[Automated comment] Request affecting a post-stable build (M53), manual review required.
,
Oct 5 2016
OK, lets just go for 54 then.
,
Oct 6 2016
The fix looks safe (adding a nacl sdk entry to mb_config.pyl) and it would be get the builders fixed. Approving for merging into M54
,
Oct 7 2016
Please confirm whether this change is verified in Canary? If yes, merge your change to M54 (branch: 2840) ASAP so that we could take the CL for next weeks last M54 Beta Release.
,
Oct 7 2016
yes, the canary builds are working fine after this change: https://build.chromium.org/p/client.nacl.sdk/builders/linux-sdk-multirel Will merge now.
,
Oct 7 2016
,
Oct 7 2016
Confirming that Cl is merged to M54 - https://chromium.googlesource.com/chromium/src.git/+/db3e57062ccd28f272806d423b83eda7f4995ef6 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by sbc@chromium.org
, Oct 4 2016Labels: Merge-Request-53 Merge-Request-54