arc: Fix context menu for Arc app in app launcher |
|||||||
Issue descriptionInner bug: b/30646620 Fixing following issues: 1. "Show app info" is disabled until Arc is started. 2. Before "Uninstall" was not shown when Arc is not started. This also makes it disable in this case for consistency. 3. Add separator before "Uninstall/Show app info" group regardless "Uninstall" item is shown or not. Before, "Show app info" menu was not separated in case uninstall was not present. 4. "Uninstall" shortcut is available always, regardless of Arc enabled or disabled. 5. No menu items for non-existing Arc app.
,
Oct 5 2016
,
Oct 5 2016
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.
,
Oct 5 2016
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c4646fc5319d88f5cb63461013d9bf122658247 commit 5c4646fc5319d88f5cb63461013d9bf122658247 Author: khmel <khmel@chromium.org> Date: Thu Oct 06 01:25:22 2016 [Merge-M54] arc: Fix Arc app item context menu. This fixes arc context menu. Original bug requests to make "Show app info" menu item disable when Arc is not ready only. This also includes following related fixes: 1. "Show app info" is disabled until Arc is started. 2. Before "Uninstall" was not shown when Arc is not started. This also makes it disable in this case for consistency. 3. Add separator before "Uninstall/Show app info" group regardless "Uninstall" item is shown or not. Before, "Show app info" menu was not separated in case uninstall was not present. 4. "Uninstall" shortcut is available always, regardless of Arc enabled or disabled. 5. No menu items for non-existing Arc app. TEST=Manually on the device. TEST=Extended unit_tests. BUG= 652741 BUG=b/30646620 TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2393453002 Review-Url: https://codereview.chromium.org/2393793003 Cr-Original-Commit-Position: refs/heads/master@{#422831} Cr-Commit-Position: refs/branch-heads/2840@{#660} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/5c4646fc5319d88f5cb63461013d9bf122658247/chrome/browser/ui/app_list/app_context_menu_unittest.cc [modify] https://crrev.com/5c4646fc5319d88f5cb63461013d9bf122658247/chrome/browser/ui/app_list/arc/arc_app_context_menu.cc [modify] https://crrev.com/5c4646fc5319d88f5cb63461013d9bf122658247/chrome/browser/ui/app_list/arc/arc_app_context_menu.h
,
Oct 6 2016
,
Oct 13 2016
Verified on 54.0.2840.59/8743.65.0
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c4646fc5319d88f5cb63461013d9bf122658247 commit 5c4646fc5319d88f5cb63461013d9bf122658247 Author: khmel <khmel@chromium.org> Date: Thu Oct 06 01:25:22 2016 [Merge-M54] arc: Fix Arc app item context menu. This fixes arc context menu. Original bug requests to make "Show app info" menu item disable when Arc is not ready only. This also includes following related fixes: 1. "Show app info" is disabled until Arc is started. 2. Before "Uninstall" was not shown when Arc is not started. This also makes it disable in this case for consistency. 3. Add separator before "Uninstall/Show app info" group regardless "Uninstall" item is shown or not. Before, "Show app info" menu was not separated in case uninstall was not present. 4. "Uninstall" shortcut is available always, regardless of Arc enabled or disabled. 5. No menu items for non-existing Arc app. TEST=Manually on the device. TEST=Extended unit_tests. BUG= 652741 BUG=b/30646620 TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2393453002 Review-Url: https://codereview.chromium.org/2393793003 Cr-Original-Commit-Position: refs/heads/master@{#422831} Cr-Commit-Position: refs/branch-heads/2840@{#660} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/5c4646fc5319d88f5cb63461013d9bf122658247/chrome/browser/ui/app_list/app_context_menu_unittest.cc [modify] https://crrev.com/5c4646fc5319d88f5cb63461013d9bf122658247/chrome/browser/ui/app_list/arc/arc_app_context_menu.cc [modify] https://crrev.com/5c4646fc5319d88f5cb63461013d9bf122658247/chrome/browser/ui/app_list/arc/arc_app_context_menu.h |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Oct 4 2016