New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 652726 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Gerrit for Chromium: make non sticky LGTMs for non-committer patches

Project Member Reported by tandrii@chromium.org, Oct 4 2016

Issue description

Can we make LGTM non-sticky for non-committers? Or in other words, make LGTM sticky only if patch author is a committer?
 
Cc: phajdan@google.com
Labels: Type-Feature
I am in favor of this for security reasons.

However, I don't know how do this using built-in features. It's clearly possible with a plugin, but it would have non-negligible maintenance cost on infra side.
BTW, Gerrit understands differences between patchsets, returned in "kind" field[1], quote:

> Valid values are REWORK, TRIVIAL_REBASE, MERGE_FIRST_PARENT_UPDATE, NO_CODE_CHANGE, and NO_CHANGE.

For a moment I thought that would be path to a solution, but I don't see how any more. Maybe others have an idea?

[1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#revision-info
Labels: -Milestone-Launch Milestone-Afterglow
and because this is strictly a new feature vs Rietveld, this is afterglow.
Status: Available (was: Untriaged)

Comment 6 by benhenry@google.com, Oct 25 2016

Labels: Pri-2
Project Member

Comment 7 by sheriffbot@chromium.org, Oct 26 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
still valid.
Labels: -Milestone-Afterglow
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
Project Member

Comment 10 by sheriffbot@chromium.org, Jan 4

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-2 Pri-3
Status: Available (was: Untriaged)

Sign in to add a comment