Gerrit for Chromium: make non sticky LGTMs for non-committer patches |
||||||||||
Issue descriptionCan we make LGTM non-sticky for non-committers? Or in other words, make LGTM sticky only if patch author is a committer?
,
Oct 4 2016
I am in favor of this for security reasons. However, I don't know how do this using built-in features. It's clearly possible with a plugin, but it would have non-negligible maintenance cost on infra side.
,
Oct 4 2016
BTW, Gerrit understands differences between patchsets, returned in "kind" field[1], quote: > Valid values are REWORK, TRIVIAL_REBASE, MERGE_FIRST_PARENT_UPDATE, NO_CODE_CHANGE, and NO_CHANGE. For a moment I thought that would be path to a solution, but I don't see how any more. Maybe others have an idea? [1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#revision-info
,
Oct 4 2016
and because this is strictly a new feature vs Rietveld, this is afterglow.
,
Oct 10 2016
,
Oct 25 2016
,
Oct 26 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 26 2017
still valid.
,
Jan 3 2018
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
,
Jan 4
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 4
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by phajdan.jr@chromium.org
, Oct 4 2016