New issue
Advanced search Search tips

Issue 652722 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 689652
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Gerrit git cl upload: better user error message if CL is abandoned

Project Member Reported by tandrii@chromium.org, Oct 4 2016

Issue description

When this happens in git push:

To https://chromium.googlesource.com/infra/infra.git
 ! [remote rejected] 3bc5eb6aac21699e421b6da2f3d13a870f50fa13 -> refs/for/refs/heads/master%notify=NONE,cc=chromium-reviews@chromium.org,cc=infra-reviews+infra@chromium.org (change https://chromium-review.googlesource.com/392826 closed)


the whole stacktrace is printed. Either parse the message OR check that CL is not abandoned before upload. I prefer former because
a) it doesn't create extra lag
b) no race positions
c) will work even CL issue isn't set, but Change-Id is set in commit message.
 
FTR: Rietveld allowed uploading to closed CL.

Comment 2 by benhenry@google.com, Oct 25 2016

Labels: Pri-2

Comment 3 by aga...@chromium.org, Mar 27 2017

Labels: -Milestone-Dogfood Milestone-Launch
Status: Fixed (was: Available)
I'm pretty sure I fixed this already.
Owner: tandrii@chromium.org
Here: https://chromium-review.googlesource.com/c/443325/
Mergedinto: 689652
Owner: ----
Status: Duplicate (was: Fixed)

Sign in to add a comment