New issue
Advanced search Search tips

Issue 652712 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Implement nominal range for rolloffFactor

Project Member Reported by rtoy@chromium.org, Oct 4 2016

Issue description

The valid ranges of the rolloffFactor for the PannerNode was never clearly specified.  Until now.

Issue: https://github.com/WebAudio/web-audio-api/issues/606
Fix: https://github.com/WebAudio/web-audio-api/pull/1023
Spec: https://webaudio.github.io/web-audio-api/#widl-PannerNode-rolloffFactor
 

Comment 1 by rtoy@chromium.org, Oct 10 2016

Owner: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bf21fc15e3736058a625862c1d3bb4d990bcf6d

commit 3bf21fc15e3736058a625862c1d3bb4d990bcf6d
Author: rtoy <rtoy@chromium.org>
Date: Tue Oct 11 00:36:58 2016

Clamp PannerNode rolloffFactor to nominal range

The rolloff factor for the PannerNode is clamped to the nominal range,
depending on the distanceModel used for the PannerNode.

Feature: https://www.chromestatus.com/feature/4939796648558592

BUG= 652712 
TEST=panner-rolloff-clamping.html

Review-Url: https://codereview.chromium.org/2389133006
Cr-Commit-Position: refs/heads/master@{#424306}

[add] https://crrev.com/3bf21fc15e3736058a625862c1d3bb4d990bcf6d/third_party/WebKit/LayoutTests/webaudio/panner-rolloff-clamping.html
[modify] https://crrev.com/3bf21fc15e3736058a625862c1d3bb4d990bcf6d/third_party/WebKit/Source/platform/audio/Distance.cpp

Comment 3 by rtoy@chromium.org, Oct 17 2016

Status: Fixed (was: Started)

Sign in to add a comment